Add new JS linter rules (#17699)

* Add new JS linter rules

Adds a few useful rules from eslint-plugin-github. Notable changes:

- Forbid dataset usage, its camel-casing behaviour makes it hard to
  grep for attributes.
- Forbid .then() and .catch(), we should generally prefer await for new
  code. For rare cases where they are useful, a eslint-disable-line
  directive can be set.
- Add docs js to linting

* also enable github/array-foreach

* small tweak

Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

package.json

@@ -45,6 +45,7 @@
   "devDependencies": {
     "editorconfig-checker": "4.0.2",
     "eslint": "8.2.0",
+    "eslint-plugin-github": "4.3.5",
     "eslint-plugin-html": "6.2.0",
     "eslint-plugin-import": "2.25.3",
     "eslint-plugin-unicorn": "38.0.1",