Lunny Xiao
e96ef97989
Upgrade dependencies ( #35384 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
- ~Upgrade golang to 1.25~ blocked by the issue
https://github.com/go-swagger/go-swagger/issues/3220
- Upgrade minor versions of most dependencies
- Upgrade github.com/google/go-github version to v74
- Fix meilisearch because of sdk interface change
- Use github.com/Necoro/html2text which is a fork instead of html2text
because of https://github.com/jaytaylor/html2text/issues/67 which
resulted in complie failure.
- Fix some deprecated methods of gitlab go client.
2025-09-02 23:13:38 -04:00
Lunny Xiao
1717af72c4
Move some functions from package git to gitrepo ( #33910 )
...
Follow #33874
2025-09-01 19:13:18 +00:00
Lunny Xiao
d2e994db2c
Move git config/remote to gitrepo package and add global lock to resolve possible conflict when updating repository git config file ( #35151 )
...
Partially fix #32018
`git config` and `git remote` write operations create a temporary file
named `config.lock`. Since these operations are not atomic, they must
not be run in parallel. If two requests attempt to modify the same
repository concurrently—such as during a compare operation—one may fail
due to the presence of an existing `config.lock` file.
In cases where `config.lock` is left behind due to an unexpected program
exit, a global lock mechanism could allow us to safely remove the stale
lock file when a related error is detected. While this behavior is not
yet implemented in this PR, it is planned for a future enhancement.
---------
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-01 18:47:04 +00:00
Lunny Xiao
4e1b8db1fc
Move HasWiki to repository service package ( #33912 )
...
Move HasWiki out of the models package to avoid referencing the absolute
wiki path directly.
2025-09-01 11:12:58 -07:00
Lunny Xiao
fb056bf4ed
Use gitrepo.SetDefaultBranch when set default branch of wiki repository ( #33911 )
2025-08-28 06:06:39 +00:00
Lunny Xiao
7636d581d9
Deleting branch could delete broken branch which has database record but git branch is missing ( #35360 )
...
For some reasons, branches between database and git are not synced. If a
branch exists in database but not in the git, it should be able to be
deleted.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-08-27 22:32:22 -07:00
wxiaoguang
0cbaa0b662
Remove incorrect "db.DefaultContext" usages ( #35366 )
2025-08-28 03:52:43 +00:00
wxiaoguang
60246730b5
Remove wrong "git.DefaultContext" ( #35364 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
2025-08-27 16:31:21 +00:00
wxiaoguang
e837c998b7
Fix context usages ( #35348 )
2025-08-27 11:00:01 +00:00
LyricWulf
da5ce5c8e7
Instance signing rule pubkey
should allow all public keys, not just GPG ( #35357 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Instance signing rule `pubkey` is described as "Only sign if the user
has a public key", however if the user only has SSH public keys, this
check will fail, as it only checks for GPG keys.
Changed the `pubkey` checks to call a helper `userHasPubkeys` which
sequentially checks for GPG, then SSH keys.
Related #34341
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-08-26 15:06:37 -07:00
NorthRealm
c7b99c8cc7
Prevent duplicate actions email ( #35215 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Trying to prevent duplicate action emails by adding an extra check on job status.
---------
Signed-off-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com >
Co-authored-by: Christopher Homberger <christopher.homberger@web.de >
2025-08-24 09:30:56 -07:00
techknowlogick
a2d88cd597
Remove deprecated auth sources ( #35272 )
...
Entra ID users should use the OIDC oauth2 provider.
They will still be shown if the instance has a previous Azure AD source
configured.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-08-23 20:39:05 +00:00
Lunny Xiao
e1fd9e3cd1
Always return the relevant status information, even if no status exists. ( #35335 )
2025-08-23 18:48:44 +00:00
Lunny Xiao
c0f24bd803
Move organization's visibility change to danger zone. ( #34814 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
<img width="1185" alt="image"
src="https://github.com/user-attachments/assets/d48c4db2-df7c-43b3-986c-62e042190a51 "
/>
<img width="829" alt="image"
src="https://github.com/user-attachments/assets/772b8a14-6837-41f2-9d78-9f0489ef1c7d "
/>
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-08-20 20:57:42 -07:00
LePau
08a7e65c84
Fix LFS range size header response ( #35277 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Fix #35276
Signed-off-by: LePau <101608950+LePau@users.noreply.github.com >
2025-08-16 16:51:45 +00:00
wxiaoguang
621f2fcadb
Skip "parentsigned" check when the repo is empty ( #35292 )
...
Fix #35280
2025-08-16 19:24:30 +03:00
Alex Blackie
9549c6641a
Fix GitHub release assets URL validation ( #35287 )
...
GitHub changed where the attachments on releases are stored, which means
repo migrations with releases now fail because the redirect URLs don't
match the base URL validation. We need to update the base URL check to
check for the `release-assets` subdomain as well.
2025-08-15 17:50:05 -04:00
Tim Biermann
4ff8cdf826
Fix token lifetime, closes #35230 ( #35271 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
This is an attempt to fix #35230 as discussed in the ticket.
2025-08-14 06:57:05 +00:00
Karl T
ee4459488a
OneDev migration: fix broken migration caused by various REST API changes in OneDev 7.8.0 and later ( #35216 )
...
OneDev migration: fix broken migration caused by various REST API
changes in OneDev 7.8.0 and later
- in REST urls use `~api` instead of `api`
- check minimum required OneDev version before starting migration
- required OneDev version is now 12.0.1
(older versions do not offer necessary API:
https://code.onedev.io/onedev/server/~issues/2491 )
- support migrating OneDev subprojects (e.g.
http:/onedev.host/projectA/subProjectB)
- set milestone closed state if milestone is closed in OneDev
- moved memory allocation for milestone JSON decoding into for loop
(which gets 100 milestones per iteration) to fix wrong due dates when
having more than 100 milestones
2025-08-13 23:30:35 -07:00
Lunny Xiao
90a48e96c7
Fix a bug where lfs gc never worked. ( #35198 )
...
Fix #31113
After #22385 introduced LFS GC, it never worked due to a bug in the INI
library: fields in structs embedded more than one level deep are not
populated from the INI file.
This PR fixes the issue by replacing the multi-level embedded struct
with a single-level struct for parsing the cron.gc_lfs configuration.
Added a new test for retrieving cron settings to demonstrate the bug in
the INI package.
2025-08-12 05:38:17 +00:00
Lunny Xiao
87b28b3e83
Reload issue when sending webhook to make num comments is right. ( #35243 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Fix #35229
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2025-08-11 11:27:22 +00:00
Lunny Xiao
84d31bc842
A small refactor to use context in the service layer ( #35179 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
2025-07-31 03:43:54 +00:00
wxiaoguang
85b5877bb0
Fix various bugs ( #35177 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
* Fix #35144
* Fix #35117
* Fix https://github.com/go-gitea/gitea/issues/35054#issuecomment-3131793977
* Fix #35136
2025-07-30 07:08:59 +00:00
Lunny Xiao
65cd3f5309
Use db.WithTx/WithTx2 instead of TxContext when possible ( #35130 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
2025-07-22 10:02:01 -07:00
wxiaoguang
86aafea3fb
Fix session gob ( #35128 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Fix #35126
2025-07-20 01:49:36 +00:00
wxiaoguang
c4f5b2b531
Don't use full-file highlight when there is a git diff textconv ( #35114 )
...
Fix #35106
2025-07-18 19:16:27 +08:00
wxiaoguang
8f91bfe9d8
Fix submodule parsing when the gitmodules is missing ( #35109 )
...
Follow up #35096 , fix #35095 , fix #35115 and add more tests
The old code used some fragile behaviors which depend on the "nil"
receiver. This PR should be a complete fix for more edge cases.
2025-07-18 09:42:44 +00:00
wxiaoguang
de1114b4e8
Fix error logs and improve some comments/messages ( #35105 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
2025-07-17 19:09:54 +08:00
pvgoran
891a827158
Support Basic Authentication for archive downloads ( #35087 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Resolves #35083
2025-07-16 10:53:57 -07:00
Lunny Xiao
37958e486a
Rename pull request GetGitRefName to GetGitHeadRefName ( #35093 )
2025-07-16 21:33:33 +08:00
Risu
e1e4815a1c
Redirect to a presigned URL of HEAD for HEAD requests ( #35088 )
...
Resolves https://github.com/go-gitea/gitea/issues/35086 .
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-16 11:22:45 +00:00
NorthRealm
0d00ec7eed
Send email on Workflow Run Success/Failure ( #34982 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Closes #23725


/claim #23725
---------
Signed-off-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: ChristopherHX <christopher.homberger@web.de >
2025-07-15 18:54:31 -07:00
wxiaoguang
d08459820d
Improve submodule relative path handling ( #35056 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Fix #35054
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2025-07-14 23:28:34 +08:00
wxiaoguang
6599efb3b1
Fix user's sign email check ( #35045 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Fix #21692
2025-07-12 15:13:01 +08:00
Lunny Xiao
1352080ef7
Fix incorrect comment diff hunk parsing, fix github asset ID nil panic ( #35046 )
...
* Fix missing the first char when parsing diff hunk header
* Fix #35040
* Fix #35049
----
Introduced in
https://github.com/go-gitea/gitea/pull/12047/files#diff-de48c2f70e24ff5603180acf8b5ce9d0356ede8a45bfbf2a485707282ace6d6aR268
Before:
<img width="487" height="167" alt="image"
src="https://github.com/user-attachments/assets/17524c76-a296-4b4b-a4f9-c5150c41bae5 "
/>
After:
<img width="749" height="144" alt="image"
src="https://github.com/user-attachments/assets/bcb12c76-c1ae-40f1-81b7-183d15f891db "
/>
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-11 15:18:41 -07:00
Lunny Xiao
7a15334656
Fix git commit committer parsing and add some tests ( #35007 )
...
* Fix #34991
* Fix #34882
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-10 19:03:36 +00:00
wxiaoguang
a5a3d9b101
Refactor OpenIDConnect to support SSH/FullName sync ( #34978 )
...
* Fix #26585
* Fix #28327
* Fix #34932
2025-07-10 18:35:59 +00:00
wxiaoguang
6ab6d4e17f
Support base64-encoded agit push options ( #35037 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
2025-07-10 18:08:40 +00:00
Scion
af0196c145
Fix ListWorkflowRuns OpenAPI response model. ( #35026 )
...
Change the OpenAPI response of `ListWorkflowRuns` to `WorkflowRunsList`
like it is supposed to be.
---------
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-10 05:58:07 +00:00
wxiaoguang
55f350542c
Refactor mail template and support preview ( #34990 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
2025-07-09 10:25:25 +08:00
wxiaoguang
4e10adc871
Start automerge check again after the conflict check and the schedule ( #34989 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Fix #34988
Co-authored-by: posativ
2025-07-08 14:51:16 +00:00
silverwind
95a935aca0
Enable gocritic equalFold
and fix issues ( #34952 )
...
Continuation of https://github.com/go-gitea/gitea/pull/34678 .
---------
Signed-off-by: silverwind <me@silverwind.io >
2025-07-06 16:53:34 +00:00
wxiaoguang
e0745eb14d
Refactor webhook and fix feishu/lark secret ( #34961 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
2025-07-06 06:04:08 +00:00
wxiaoguang
3533263ced
Improve OAuth2 provider (correct Issuer, respect ENABLED) ( #34966 )
...
1. Make "Issuer" strictly follow the spec (see comment)
2. Make "/.well-known/openid-configuration" respond 404 if the OAuth2
provider is not enabled.
Then by the way, remove the JSEscape template helper because it is not
needed any more.
2025-07-06 13:36:45 +08:00
Dan Čermák
58759aeca0
Mark old reviews as stale on agit pr updates ( #34933 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Fixes: https://github.com/go-gitea/gitea/issues/34134
2025-07-05 11:30:06 -07:00
wxiaoguang
70685a9489
Fix git graph page ( #34948 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
fix #34946
2025-07-04 15:41:19 +00:00
wxiaoguang
d6d643fe86
Fix http auth header parsing ( #34936 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
cron-translations / crowdin-pull (push) Has been cancelled
Using `strings.EqualFold` is wrong in many cases.
2025-07-03 03:02:38 +00:00
Lunny Xiao
8cbec63cc7
Don't send trigger for a pending review's comment create/update/delete ( #34928 )
...
Fix #18846
Fix #34924
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-03 10:35:45 +08:00
RickyMa
6455c8202b
Support getting last commit message using contents-ext API ( #34904 )
...
Fix #34870
Fix #34929
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-03 09:45:42 +08:00
delvh
8dbf13b1cb
Follow file symlinks in the UI to their target ( #28835 )
...
Symlinks are followed when you click on a link next to an entry, either
until a file has been found or until we know that the link is dead.
When the link cannot be accessed, we fall back to the current behavior
of showing the document containing the target.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-01 06:55:36 +08:00