Merge pull request 'Updated Xbox controller selection. /JL' (#17) from 0.1.8 into main

Reviewed-on: #17

pygameControls/controller.py

@@ -9,7 +9,7 @@ from .xbox_series_x_controller import XboxSeriesXController
 from .generic_controller import GenericController
 from .logitech_dual_action_controller import LogitechDualActionController
 
-__version__ = "0.0.4"
+__version__ = "0.1.8"
 
 CONTROLLERS = {
     "DualSense Wireless Controller": DualSenseController,
@@ -18,7 +18,7 @@ CONTROLLERS = {
     "Logitech Gamepad F510": LogitechF510Controller,
     "Logitech Gamepad F710": LogitechF710Controller,
     "Logitech Dual Action": LogitechDualActionController,
-    "X box Series X Controller": XboxSeriesXController
+    "Xbox Series X Controller": XboxSeriesXController
     }
 
 class Controllers:

pygameControls/controlsbase.py

@@ -30,4 +30,12 @@ class ControlsBase(ABC):
     
     @abstractmethod
     def rumble(self):
+        pass
+    
+    @abstractmethod
+    def stop_rumble(self):
+        pass
+    
+    @abstractmethod
+    def close(self):
         pass

pygameControls/dualsense_controller.py

@@ -18,6 +18,12 @@ class DualSenseController(ControlsBase):
         self.powerlevel = self.device.battery.Level
         self.batterystate = BATTERY_STATE[str(self.device.battery.State)]
         self.set_player_id(PlayerID.PLAYER_1)
+        self.numaxis: int = joy.get_numaxes()
+        self.axis: list = [joy.get_axis(a) for a in range(self.numaxis)]
+        self.numhats: int = joy.get_numhats()
+        self.hats: list = [joy.get_hat(h) for h in range(self.numhats)]
+        self.numbuttons: int = joy.get_numbuttons()
+        self.buttons: list = [joy.get_button(b) for b in range(self.numbuttons)]
         self.mapping = {
             "left stick x": self.axis[0],
             "left stick y": self.axis[1],
@@ -43,6 +49,9 @@ class DualSenseController(ControlsBase):
         print(f"Power level: {self.powerlevel}")
         print(f"Battery state: {self.batterystate}")
     
+    def close(self):
+        self.device.close()
+        
     def handle_input(self, event):
         pass
     
@@ -67,9 +76,16 @@ class DualSenseController(ControlsBase):
     def pause(self):
         pass
     
-    def rumble(self):
-        pass
+    def rumble(self, left, right):
+        if not left in range(256) or not right in range(256):
+            raise ValueError("left and right values must be in the range 0 - 255")
+        self.device.setLeftMotor(left)
+        self.device.setRightMotor(right)
     
+    def stop_rumble(self):
+        self.device.setLeftMotor(0)
+        self.device.setRightMotor(0)
+        
     @property
     def name(self) -> str:
         return self._name

pygameControls/dualsense_edge_controller.py

@@ -10,6 +10,12 @@ class DualSenseEdgeController(ControlsBase):
         self.powerlevel = self.device.battery.Level
         self.batterystate = BATTERY_STATE[str(self.device.battery.State)]
         self.set_player_id(PlayerID.PLAYER_1)
+        self.numaxis: int = joy.get_numaxes()
+        self.axis: list = [joy.get_axis(a) for a in range(self.numaxis)]
+        self.numhats: int = joy.get_numhats()
+        self.hats: list = [joy.get_hat(h) for h in range(self.numhats)]
+        self.numbuttons: int = joy.get_numbuttons()
+        self.buttons: list = [joy.get_button(b) for b in range(self.numbuttons)]
         self.mapping = {
             "left stick x": self.axis[0],
             "left stick y": self.axis[1],
@@ -35,6 +41,9 @@ class DualSenseEdgeController(ControlsBase):
         print(f"Power level: {self.powerlevel}")
         print(f"Battery state: {self.batterystate}")
     
+    def close(self):
+        self.device.close()
+        
     def handle_input(self, event):
         pass
     
@@ -59,9 +68,16 @@ class DualSenseEdgeController(ControlsBase):
     def pause(self):
         pass
     
-    def rumble(self):
-        pass
+    def rumble(self, left, right):
+        if not left in range(256) or not right in range(256):
+            raise ValueError("left and right values must be in the range 0 - 255")
+        self.device.setLeftMotor(left)
+        self.device.setRightMotor(right)
     
+    def stop_rumble(self):
+        self.device.setLeftMotor(0)
+        self.device.setRightMotor(0)
+        
     @property
     def name(self) -> str:
         return self._name

pygameControls/generic_controller.py

@@ -36,6 +36,9 @@ class GenericController(ControlsBase):
             }
         print(f"{self.name} connected.")
     
+    def close(self):
+        pass
+    
     def handle_input(self, event):
         pass
     
@@ -57,6 +60,9 @@ class GenericController(ControlsBase):
     def rumble(self):
         pass
     
+    def stop_rumble(self):
+        pass
+    
     @property
     def name(self) -> str:
         return self._name

pygameControls/logitech_dual_action_controller.py

@@ -56,7 +56,10 @@ class LogitechDualActionController(ControlsBase):
             "logo button": None
             }
         print(f"{self.name} connected.")
-        
+    
+    def close(self):
+        pass
+    
     def handle_input(self, event):
         pass
     
@@ -78,6 +81,9 @@ class LogitechDualActionController(ControlsBase):
     def rumble(self):
         pass
     
+    def stop_rumble(self):
+        pass
+    
     @property
     def name(self) -> str:
         return self._name

pygameControls/logitech_f310_controller.py

@@ -57,6 +57,9 @@ class LogitechF310Controller(ControlsBase):
             }
         print(f"{self.name} connected.")
     
+    def close(self):
+        pass
+    
     def handle_input(self, event):
         pass
     
@@ -78,6 +81,9 @@ class LogitechF310Controller(ControlsBase):
     def rumble(self):
         pass
     
+    def stop_rumble(self):
+        pass
+    
     @property
     def name(self) -> str:
         return self._name

pygameControls/logitech_f510_controller.py

@@ -59,6 +59,9 @@ class LogitechF510Controller(ControlsBase):
             }
         print(f"{self.name} connected.")
     
+    def close(self):
+        pass
+    
     def handle_input(self, event):
         pass
     
@@ -80,6 +83,9 @@ class LogitechF510Controller(ControlsBase):
     def rumble(self):
         pass
     
+    def stop_rumble(self):
+        pass
+    
     @property
     def name(self) -> str:
         return self._name

pygameControls/logitech_f710_controller.py

@@ -59,6 +59,9 @@ class LogitechF710Controller(ControlsBase):
             }
         print(f"{self.name} connected.")
     
+    def close(self):
+        pass
+    
     def handle_input(self, event):
         pass
     
@@ -80,6 +83,9 @@ class LogitechF710Controller(ControlsBase):
     def rumble(self):
         pass
     
+    def stop_rumble(self):
+        pass
+    
     @property
     def name(self) -> str:
         return self._name

pygameControls/xbox_series_x_controller.py

@@ -1,7 +1,6 @@
-import time
-import threading
+from pygameControls.controlsbase import ControlsBase
 
-class XboxSeriesXController:
+class XboxSeriesXController(ControlsBase):
     def __init__(self, joy):
         self.device = joy
         self.instance_id: int = self.device.get_instance_id()
@@ -37,6 +36,9 @@ class XboxSeriesXController:
             }
         print(f"{self.name} connected.")
     
+    def close(self):
+        pass
+    
     def handle_input(self, event):
         pass
     
@@ -55,9 +57,14 @@ class XboxSeriesXController:
     def pause(self):
         pass
     
-    def rumble(self):
-        pass
+    def rumble(self, left, right):
+        if not left in range(256) or not right in range(256):
+            raise ValueError("left and right values must be in the range 0 - 255")
+        self.joy.rumble(left, right)
     
+    def stop_rumble(self):
+        self.joy.rumble(0, 0)
+        
     @property
     def name(self) -> str:
         return self._name

setup.py

@@ -3,7 +3,7 @@ if __name__ == "__main__":
 
     setup(
         name='pygameControls',
-        version='0.0.5',
+        version='0.1.8',
         packages=find_packages(),
         install_requires=[],
         author='Jan Lerking',