Update strapdown.js to support custom squirts and copyrights using the <squirt> and <copyright> tags in <head>. #11

2021-01-23T19:46:18+01:00

ElnuDev commented

2021-01-23 19:46:18 +01:00

(Migrated from github.com)

Fixes #10. Minified file needs to be updated.

My apologies if I've done something wrong, this is my first pull request on GitHub!

Fixes #10. Minified file needs to be updated. My apologies if I've done something wrong, this is my first pull request on GitHub!

👍 1

Naereen commented

2021-01-23 20:15:28 +01:00

(Migrated from github.com)

Oh, that's an interesting trick!

Can you please show a screenshot of how it looks on one of your page, with/without both and tags?

I'll try it myself, then merge your pull-request, and update the minified files.

I would also like to note that if HTML purists see your custom and tags, they won't be happy about them, but I don't care.

Oh, that's an interesting trick! Can you please show a screenshot of how it looks on one of your page, with/without both <squirt> and <copyright> tags? I'll try it myself, then merge your pull-request, and update the minified files. I would also like to note that if HTML purists see your custom <squirt> and <copyright> tags, they won't be happy about them, but I don't care.

❤️ 1

ElnuDev commented

2021-01-23 20:32:52 +01:00

(Migrated from github.com)

Thanks for taking a look!

Here's my page with <squirt> and <copyright>:

Here's my page without <squirt> and <copyright>:

I'm not sure, perhaps it would be better just to have one tag (<subtitle>, perhaps?) that allows complete customizability and covers the whole section, instead of being forced to used <squirt> and <copyright>.

Thanks for taking a look! Here's my page with `<squirt>` and `<copyright>`: ![Screenshot from 2021-01-23 11-25-30](https://user-images.githubusercontent.com/9874955/105612004-c9990800-5d6d-11eb-8321-5214d5a52e43.png) Here's my page without `<squirt>` and `<copyright>`: ![Screenshot from 2021-01-23 11-28-54](https://user-images.githubusercontent.com/9874955/105612071-3b715180-5d6e-11eb-8bdb-192c16d40b65.png) I'm not sure, perhaps it would be better just to have one tag (`<subtitle>`, perhaps?) that allows complete customizability and covers the whole section, instead of being forced to used `<squirt>` and `<copyright>`.

👍 1

Naereen commented

2021-01-25 12:57:31 +01:00

(Migrated from github.com)

I like your approach, as it allows to customize the location and content of the copyright notice.

I would also like to add an option, that works like the others currently supported by StrapDown.js :
see this page for more details : https://naereen.github.io/StrapDown.js/example5.html

I'll do it myself, probably adding nosquirt=y and nocopyright=y. Except if you have a better suggestion?
(I'll wait for a reply before merging this PR and adding my idea of these two tiny options)

I like your approach, as it allows to customize the location and content of the copyright notice. I would also like to add an option, that works like the others currently supported by StrapDown.js : see this page for more details : https://naereen.github.io/StrapDown.js/example5.html I'll do it myself, probably adding `nosquirt=y` and `nocopyright=y`. Except if you have a better suggestion? (I'll wait for a reply before merging this PR and adding my idea of these two tiny options)

👍 1

ElnuDev commented

2021-01-25 19:23:23 +01:00

(Migrated from github.com)

That sounds like a good idea! It's certainly cleaner than only being able to have empty <squirt> and <copyright> tags, which is the only way to remove the squirt and copyright in the system I set up.

That sounds like a good idea! It's certainly cleaner than only being able to have empty `<squirt>` and `<copyright>` tags, which is the only way to remove the squirt and copyright in the system I set up.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin ElnuDev/master:ElnuDev/master

git checkout ElnuDev/master

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Lerking/StrapDown.js#11