Wed Jan 31 21:20:39 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkctree.c (real_tree_move): If the node being moved isn't
viewable there is no way that moving the node will cause the
focus row to become not viewable, so omit check on the visibility
of new_sibling, which is irrelevant. (Fixes#8002, David Helder)
Thu Feb 1 02:26:18 2001 Tim Janik <timj@gtk.org>
* gtk/Makefile.am ($(srcdir)/gtkmarshal.c): avoid regeneration
of gtkmarshal.c from stamp file dep, when not @REBUILD@,
fixes#11008.
Wed Jan 31 19:23:01 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfontsel.c (gtk_font_selection_set_font_name):
Apply patch gtk-gharris-000907-0.patch (Guy Harris) fixing problem where
wrong row was selected when filters filtered out some fonts.
Wed Jan 31 18:49:33 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkoptionmenu.c (gtk_option_menu_item_state_changed_cb):
Make the sensitivity of the reparented child track that of
the original parent menu item. (#34218, David Hodson)
* gtk/gtkoptionmenu.c (gtk_option_menu_item_destroy_cb): Handle
the case where the current item is destroyed properly.
* gtk/gtkoptionmenu.c: Some additional code cleanups and fix
some edge cases with child-less menuitems.
Wed Jan 31 17:16:13 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcombo.c (gtk_combo_window_key_press): Make Return
key pop down window. (#12074, Jon K Hellan)
Wed Jan 31 16:21:42 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtklist.c (gtk_list_signal_item_toggle): Don't allow
toggling of rows off in BROWSE or EXTENDED mode. (#12072, Greg
Hudson.) The solution here isn't perfect - you get an extraneous
emission of "toggle", which could conceivably confuse an app,
but better than the current situation. LXR search seems to
indicate that no apps in GNOME CVS connect to "toggle".
Wed Jan 31 15:46:13 2001 Owen Taylor <otaylor@redhat.com>
* gtk/Makefile.am (libgtkinclude_HEADERS): Move gtkfeatures.h from
gtk_public_h_sources to directly here to avoid warning when
building srcdir != builddir. (#9656)
Tue Jan 30 19:49:02 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrange.c: Patch from Kipp Hickman to make the event
handlers in gtkrange.c return the proper values (TRUE == handled)
(#10316).
This is just the tip of the iceberg, but gtkrange.c is the
most common place where the propagation is problematical,
and also a place where it is almost certainly safe to change
this in the stable branch.
(You don't want right click popups on a range control or anything...)
Tue Jan 30 19:12:52 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_unmap): Call gdk_window_withdraw
rather than gdk_window_hide; this makes things work
correctly if the window is programmatically hidden while
iconified. [ Backport from HEAD, hope, hope it doesn't break
anything since it fixes a bunch of stuff. ] (#14082)
Tue Jan 30 18:57:59 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtktext.c (clear_focus_area): We need to clear the focus
area on focus out, even if a background pixmap isn't set.
(#13941)
Tue Jan 30 18:31:23 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkstyle.c (gtk_style_detach): Handle the case where
bg_pixmap[i] == GDK_PARENT_RELATIVE.
Tue Jan 30 18:24:10 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtknotebook.c (gtk_notebook_set_shape): Fix from Sean Cunningham
to deal with setting the shape properly when scrolling arrows are
turned on, but not visible because there is sufficient space.
(#13432)
Tue Jan 30 16:39:25 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkitemfactory.c (gtk_item_factory_delete_item): For menu
items with submenus, destroy the item along with the submenu.
(#7841, Brian Masney(?)) Also, handle paths of the form '<foo>/abcd...'
properly.
* gtk/testgtk.c (menu_items): Add a dummy branch that we delete
later.
Tue Jan 30 15:51:25 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_real_set_focus): Fix a problem where
the focus widget sometimes wasn't drawn with the default if there
was no default widget.
* gdk/gdkim.c (gdk_ic_destroy): Don't rely on
ic->mask, which is completely unreliably set, when
deciding what items to unref/free. (A bit of a hack,
but this code will be dead in GTK+-2.0.) (#6739)
* gtk/gtkstyle.c (gtk_style_detach): free colors,
unreference pixmaps.
* gtk/gtkstyle.c (gtk_style_init): Reference colormap
for some extra safety.
Mon Jan 29 19:44:26 2001 Owen Taylor <otaylor@redhat.com>
[ Backport from HEAD ]
* gtk/gtkmenuitem.c gtk/gtkmenushell.c: Patch from David Santiago
<mrcooger@cyberverse.com> so that when selecting menus with the
mouse, the first item will not be selected, but when selecting
with an accelerator, or navigating left-right on a menubar with
the menus popped up, the first item will be selected.
Mon Jan 29 19:00:01 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtk{ctree.c,clist.c} (set_cell_contents): Handle setting
the text of a cell to the old pointer value better, by
copying the new text before freeing the old text. Some code
cleanup. (#8079, Karl Nelson)
Mon Jan 29 19:00:01 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtk{ctree.c,clist.c} (set_cell_contents): Handle setting
the text of a cell to the old pointer value better, by
copying the new text before freeing the old text. Some code
cleanup. (#8079)
Mon Jan 29 18:33:24 2001 Owen Taylor <otaylor@redhat.com>
* gdk/gdk.c (gdk_init_check): Handle --display= forms
of options taking arguments. Fix some memory leaks with
repeated arguments. (#28842, Sam Hunter)
Mon Jan 29 16:34:28 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfontsel.c (gtk_font_selection_select_best_size): Return
if fontsel->font_index == -1 - that is, if no font is selected.
(Should fix#50290)
Mon Jan 29 15:22:51 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenu.c (gtk_menu_remove): When removing an
item from a menu, check to see if it matches
menu->old_active_menu_item, and if so, unref and clear
old_active_menu_item (Patch from Pavel Cisler)
* gtk/gtkmenushell.c (gtk_menu_shell_remove): Unset
menu_shell->active_menu_item, if it is the child being
removed. (Patch based on that of Gene Ragan, #50337)
2001-01-03 Alexander Larsson <alexl@redhat.com>
* gdk/gdkwindow.c:
Set the colormap of input only windows to the system colormap.
The previous GtkInvisible patch generated a lot of colormap ==
NULL warnings without this.
2000-12-20 Alexander Larsson <alexl@redhat.com>
* gtk/gtkinvisible.c (gtk_invisible_realize):
Attach the style to the window so that the style it is not
leaked when unrealizing the window.
* gdk/gdkimage.c: (gdk_image_get):
Deal with the possibility that XGetImage() might return NULL.
Allocate the GdkImagePrivate structure only after XGetImage()
succeeds in order not to dereference a NULL ximage pointer. This
prevents a core dump when XGetImage() fails - which is unlikely,
but can happen due to race conditions accessing the geometries of
drawables. An x error will still be triggered, but the gdk image
wrapper at least wont seg fault.
Sun Dec 3 11:44:07 2000 Owen Taylor <otaylor@redhat.com>
* gdk/gdkevents.c: Strip GDK_RELEASE_MASK out of
the state we get from X as a temporary hack to
deal with the fact that GDK_RELEASE_MASK has the
same values as bits used by XFree86 to indicate the
keyboard group. (After patch from Vlad Harchev)
Thu Nov 30 12:39:22 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkspinbutton.c (gtk_spin_button_insert_text): Fix
some signed/unsigned comparison problems. (#6510,
David Kaelbling)
Thu Nov 30 11:19:56 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkentry.c (gtk_entry_move_word): Fix stupid
bug causing extra word movement backwards. (#15282, Marco Goetze)
Wed Nov 29 21:47:26 2000 Owen Taylor <otaylor@redhat.com>
[ Backport from 1.3.x ]
* gtk/gtktoolbar.c (gtk_toolbar_prepend_widget): Fix to
prepend not append. (Pointed out by Brett Hall.)
#11887.
Wed Nov 29 20:56:38 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwidget.[ch] (gtk_widget_is_ancestor): Change
return type to boolean (Oskar Liljeblad, #18648)
Thu Oct 26 02:10:32 2000 Tim Janik <timj@gtk.org>
[ Backport from 1.3 / otaylor, 29 Nov 2000 ]
* gtk/Makefile.am: invoke maketypes.awk with LC_ALL=C to avoid
localization misbehaviour.
2000-11-27 Federico Mena Quintero <federico@helixcode.com>
* gtk/gtkspinbutton.c (gtk_spin_button_set_adjustment): Connect to
the "changed" callback of the adjustment. We need to redraw the
spin button's arrows when the adjustment's range changes.
(adjustment_changed_cb): Draw the arrows.
(gtk_spin_button_value_changed): Draw the arrows.
Sat Nov 18 11:56:39 2000 Owen Taylor <otaylor@redhat.com>
[ backport from 1.3.x ]
* gdk/gdkrgb.c: If possible, create only a single shm segment and
use multiple parts of it instead of creating a bunch of separate
segments, since the maximum number of segments per system is not
large.
* gdk/x11/gdkimage-x11.c (gdk_image_new): Don't set gdk_use_xshm
to False when we get EINVAL from shmget so that the caller of
gdk_image_new can retry with a smaller segment size.
Sat Nov 18 11:45:09 2000 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcalendar.c: Patch from ChiDeok Hwang to fix
memleaks found by Evan Martin.