Commit Graph

67903 Commits

Author SHA1 Message Date
Benjamin Otte
9abf9bb3b2 path: Always decompose conics into at least 2 segments
Conics are evil in that their parameter skews towards the center, and if
it's a very flat conic (weight almost equal to 0), then we'd approximate
it with a single segment and not subdivide, which would cause the
parameter to be wildly off around 0.25 or 0.75.

And that would cause offset calculations to fail.
2020-12-19 18:35:12 +01:00
Matthias Clasen
6bd5ffde76 testsuite Add curve tangent tests 2020-12-19 18:35:12 +01:00
Benjamin Otte
2bac9f4c1f testsuite: Add a test for the conic that got us segment() 2020-12-19 18:35:12 +01:00
Benjamin Otte
e0ed8006dc path: Add gsk_curve_segment()
Using split() twice with scaled t values does not work with conics.
2020-12-19 18:35:12 +01:00
Benjamin Otte
2a55b9d0df testsuite: Add a test for gsk_curve_decompose() 2020-12-19 18:35:12 +01:00
Benjamin Otte
afbbc79b3a testuite: Add tests for gsk_curve_get_tangent() 2020-12-19 18:35:12 +01:00
Matthias Clasen
636093f85e testuite: Add tests for gsk_curve_get_point()
Add a few tests for gsk_curve_get_point().

Since GskCurve is not public api, we add gskcurve.c
as source to the test binary.
2020-12-19 18:35:12 +01:00
Benjamin Otte
520fc04d4c curve: Split eval() into get_point() and get_tangent()
That's more in line with the get_start/end_point/tangent() functions.

Plus, those calls are independent and we usually want one or the other.
2020-12-19 18:35:12 +01:00
Matthias Clasen
a384b2a5fc Add gsk_curve_get_{start,end}_tangent
Add a way to get the tangents at the start and end of the curve.
This will be used in stroking.
2020-12-19 18:35:12 +01:00
Benjamin Otte
1108968272 testsuite: Add conics to the random paths 2020-12-19 18:35:12 +01:00
Benjamin Otte
076f2dc68c path: Add GskCurve
GskCurve is an abstraction for path operations. It's essentially a
collection of vfuncs per GskPathOperation.

GskStandardContour has been ported to use it where appropriate.
2020-12-19 18:34:42 +01:00
Benjamin Otte
53e0bb187f path: Introduce gskpathop
A gskpathop is a pointer to a graphene_point_t* with the low bits used
to encode the GskPathOperation. It's an easy way to introduce API for
operations.

So far it's just used to replace GskStandardOperation.
2020-12-19 18:34:42 +01:00
Benjamin Otte
844a5d439c WIP: css: Replace border rendering code with GskPath
The weight is wrong still, I need to compute the correct one to get real
45deg circle corners and not just roughly correct ones.
2020-12-19 18:34:42 +01:00
Benjamin Otte
042d87ea7f WIP: pathbuilder: Add gsk_path_builder_add_rounded_rect()
It works, but does not use a custom contour yet.
2020-12-19 18:34:42 +01:00
Benjamin Otte
ccbff7d27d path: Add conic curves
So far this just adds the API, if you use it, you'll get lots of
g_warnings().

This will be fixed in future commits.
2020-12-19 18:34:42 +01:00
Benjamin Otte
410753353e path: Rename to gtk_path_builder_add_segment()
It's about bulding paths, not about measuring them.
2020-12-19 18:34:42 +01:00
Benjamin Otte
7f3e5c5c00 path: Split contours into their own file
I'm not sure I want to keep all contours in one file, but for now that's
how it is.
2020-12-19 18:34:42 +01:00
Benjamin Otte
d667ae7e9e path: Make all private contour APIs take a GskContour
... instead of a path, index tuple.
2020-12-19 18:34:42 +01:00
Benjamin Otte
1290639650 stroke: Add support for dashes
... and hook it up in the node parser and for Cairo rendering.
2020-12-19 18:34:42 +01:00
Matthias Clasen
c34adf88be gsk: Implement parsing fill and stroke nodes
Make serialization and deserialization work for stroke and
fill nodes.
2020-12-19 18:34:42 +01:00
Benjamin Otte
8539f177b4 path: Add flags to gsk_path_foreach()
This way we can default to the siplest possible foreach() output - like
cairo_copy_path_flat() decomposing everything into lines - and add flags
to get more and more fancy.

This will be useful to have conics automatically decomposed for Cairo
drawing or if we want to add more line types in the future.
2020-12-19 18:34:42 +01:00
Benjamin Otte
b14b5dd4f5 testsuite: Add an in_fill() test 2020-12-19 18:34:42 +01:00
Matthias Clasen
b01e1a2ee8 Implement gsk_path_measure_in_fill
Implement this in the obvious way, using the decomposed form
of standard contours. Since the decomposed form is part of the
measure object, this api moves from gsk_path_in_fill to
gsk_path_measure_in_fill.
2020-12-19 18:34:42 +01:00
Benjamin Otte
27c307b838 testsuite: Add a parsing test
This test includes an implementation of a gsk_path_equal() func with
a tolerance that is necessary because parsing does not always work
100% exactly due to floating point rounding, so we can't just
compare the to_string() output.
2020-12-19 18:34:42 +01:00
Matthias Clasen
d11b02ad06 path: Special-case rects and circles
Write out the commands for rects and circles in a special
way, and add code in the parser to recognize this, so we
can successfully round-trip these through the SVG path format.

The special way - for people who want to use it for debugging -
for now is that we use uppercase "Z" to close standard paths, but
lowercase "z" to close our special paths.

A test is included, but the random path serializations should take care
of it, too.
2020-12-19 18:34:42 +01:00
Matthias Clasen
7deed20573 path: Fix serialization for circles
The svg A can not do a full circle, since it is a two point
parametrization - if the start and end point are the same,
it draws nothing. So, use two arcs.
2020-12-19 18:34:42 +01:00
Benjamin Otte
3e017d3ed3 testsuite: Add librsvg path tests 2020-12-19 18:34:42 +01:00
Matthias Clasen
81a23a0bbd path: Implement gsk_path_parse
Implement the SVG path syntax to read back the strings
that we generate when serializing paths. The tests for
this code are taken from librsvg.

This includes an elliptical arc implementation according
to the SVG spec. The code is mostly taken from librsvg,
but pretty directly follows the SVG spec implementation
notes. We don't export this, since the parametrization
is inconvenient. We do want an arc_to API, but
these are not the arcs we are looking for.
2020-12-19 18:34:42 +01:00
Matthias Clasen
cc6062446e path: Implement SVG arcs
This is elliptical arc implementation according to the SVG spec.
The code is mostly taken from librsvg, but pretty directly
follows the SVG spec implementation notes.

We don't export this, since the parametrization is inconvenient.
We do want an arc_to API, but these are not the arcs we are
looking for.

It will be used in parsing SVG path syntax.
2020-12-19 18:34:42 +01:00
Matthias Clasen
7da5e494e4 stroke: Add miter limit
Add a miter limit to GskStroke. This will be needed to
fully implement line joins.

Also introduce the GSK_LINE_JOIN_MITER_CLIP value,
following SVG 2.0. cairo does not have it, so translate
it to plain miter when using cairo.
2020-12-19 18:34:42 +01:00
Matthias Clasen
0d5d6e8b3e Documentation typo fixes 2020-12-19 18:34:42 +01:00
Benjamin Otte
77f351c4be testsuite: Add relative path functions
They're making the paths slightly weirder, but they test public API, so
woohoo!
2020-12-19 18:34:42 +01:00
Benjamin Otte
b4982b6cf3 pathbuilder: Add relative path commands
And gsk_path_builder_get_current_point().

They will be needed by the string parser.
2020-12-19 18:34:42 +01:00
Benjamin Otte
8eadf59676 path: Add GSK_CIRCLE_POINT_INIT() to initialize points on the circle
This is just splitting out a commonly done operation into a macro.
2020-12-19 18:34:42 +01:00
Benjamin Otte
1b46896164 pathbuilder: Redo semantics for starting curves
We now always have a "current point" which is either the last point an
operation was made to, or (0, 0) if no drawing operation has
been made yet.

Adding a contour of any kind to the builder will always update the
current point to that contour's end point.
2020-12-19 18:34:42 +01:00
Benjamin Otte
e8aef57587 xxx: demo 2020-12-19 18:34:42 +01:00
Benjamin Otte
3b94c3cb97 path: Split GskPathBuilder into its own file
... and add missing API docs.
2020-12-19 18:34:42 +01:00
Benjamin Otte
fe1dcc086a testsuite: Add a test using get_point() and get_closest_point() 2020-12-19 18:34:42 +01:00
Benjamin Otte
b4700fae93 testsuite: Add a test for get_point() 2020-12-19 18:34:42 +01:00
Benjamin Otte
e6763419f1 testsuite: Update create_random_path()
1. Allow specifying the max number of contours
2. Be smarter about creating the paths:
   With 10% chance, create a "weird" path like the empty one or only
   points or things like that.
   Otherwise create a bunch of contours, with 2/3 a standard contour,
   with 1/3 a predetermined one.
2020-12-19 18:34:33 +01:00
Benjamin Otte
d33fdb276e gtk-demo: Add cute maze demo 2020-12-19 06:41:22 +01:00
Benjamin Otte
5b8acfb3cd testsuite: Add tests for gsk_path_measure_get_closest_point() 2020-12-19 06:41:22 +01:00
Benjamin Otte
afa8cfa44c path: Add gsk_path_measure_get_closest_point()
... and gsk_path_measure_get_closest_point_full().

Those 2 functions allow finding the closest point on a path to a given
point.
2020-12-19 06:41:22 +01:00
Benjamin Otte
af380898d7 spline: Use Skia's tolerance checks
This avoids measuring being too far off (it's still off, but it's less
than a percent now.
2020-12-19 06:41:22 +01:00
Benjamin Otte
d4b393b0bf testsuite: Add tests for gsk_path_measure_add_segment() 2020-12-19 06:41:22 +01:00
Benjamin Otte
b33778c582 gtk-demo: Add a text-on-path demo 2020-12-19 06:41:22 +01:00
Benjamin Otte
5cf05db437 xxx: path_fill demo 2020-12-19 06:41:22 +01:00
Benjamin Otte
a300002431 path: Add gsk_path_measure_get_point()
Allows querying the coordinates and direction of any specific point on a
path.
2020-12-19 06:41:21 +01:00
Matthias Clasen
86617e0eb7 path: Add gsk_path_add_circle()
Adds a circle contour, too.
2020-12-19 06:41:21 +01:00
Benjamin Otte
f607314bb4 pathmeasure: Implement support for beziers
Instead of treating bezier curves as lines, we properly decompose them
into line segments now so that we can treat those as lines.
2020-12-19 06:41:21 +01:00