Commit Graph

36070 Commits

Author SHA1 Message Date
Olivier Brunel
c20721fd20 treemodelfilter: Fix using wrong path on row-deleted
A "typo" led to using a wrong GtkTreePath when converting the path of the
virtual root to check the ancestors, which would lead to either no checks being
performed, or maybe segfaulting when using an invalid path as result.

https://bugzilla.gnome.org/show_bug.cgi?id=722058
Signed-off-by: Olivier Brunel <jjk@jjacky.com>
2014-04-05 17:01:11 -04:00
John Lindgren
81a5243a47 Allow gtk_radio_menu_item_set_group() to be called twice without crashing.
https://bugzilla.gnome.org/show_bug.cgi?id=726859
2014-04-05 17:01:10 -04:00
Joanmarie Diggs
1994fc7ec4 Add missing AtkRelations for labelled containers in the print dialog
These AtkRelation types are added automatically for widgets with a label
specified (e.g. via gtk_label_set_mnemonic_widget, gtk_frame_set_label,
and gtk_frame_set_label_widget). When such specification is absent, the
accessible relationship must be manually set.

https://bugzilla.gnome.org/show_bug.cgi?id=726996
2014-04-05 17:01:10 -04:00
John Lindgren
f92a25d773 Fix typo (GTK_ENABLE_DEBUG vs. G_ENABLE_DEBUG).
https://bugzilla.gnome.org/show_bug.cgi?id=726858
2014-04-05 17:01:09 -04:00
Matthias Clasen
3d626d9094 font chooser: Update font list on font changes
We do get a style-updated emission when new fonts are installed.
Update the font list in this case.

https://bugzilla.gnome.org/show_bug.cgi?id=726476
2014-04-05 17:01:08 -04:00
Benjamin Otte
851b5d3c4c docs: Add more information to gtk_widget_set_realized()
It's important to point out that widgets should only be marked as
realized very late in the process. Even GTK widgets don't get this
right.

https://bugzilla.gnome.org/show_bug.cgi?id=726717
2014-04-05 17:01:07 -04:00
Benjamin Otte
6c9d0e1773 expander: Call set_realized() later
Widgets should only call set_realized() after having created and
registered their GDK windows. In this case, the creation of the style
context (or more exactly: figuring out the scale factor for it) requires
knowing if the widget is already realized. Which it isn't.

https://bugzilla.gnome.org/show_bug.cgi?id=726717
2014-04-05 17:01:07 -04:00
Benjamin Otte
2594f3452c cssprovider: Fix error message
expected a valid semicolon
sounds kinda not so great. Make it say
  expected semicolon

Unless somebody can tell me the difference between valid and invalid
semicolons?
2014-04-05 17:01:06 -04:00
Matthias Clasen
9d8ac6cacf Work around gcc stupidity
With -Wc++-compat, gcc warns about 'and' even in contexts where it
poses absolutely no danger.

https://bugzilla.gnome.org/show_bug.cgi?id=726136
2014-04-05 17:01:05 -04:00
Owen W. Taylor
6d593407d5 gdk_cairo_surface_create_from_pixbuf: Add missing (allow-none) annotation
The window is allowed to be %NULL
2014-04-05 17:01:05 -04:00
Owen W. Taylor
f27ad4df43 Fix font size when gdk_x11_display_set_window_scale() is used
We have a hack in the XSETTINGS code to substitute gtk-xft-dpi
with gdk-unscaled-dpi unless the screen has a fixed window scale,
in which case we just use gtk-xft-dpi.

But if the screen is changed to have a fixed window scale, then
the substituted value of gdk-unscaled-dpi will stick around until
the next (coincidental) change to XSETTINGS. To fix this, force
an immediate reread of the XSETTINGS property when
gdk_x11_display_set_window_scale() is used.

https://bugzilla.gnome.org/show_bug.cgi?id=725754
2014-04-05 17:01:04 -04:00
Carlos Garnacho
2a16425617 entry: Make DnD coordinate calculation compensate for entry icons
This made DnD have effect farther on the left when dragging text over
any entry with icons in it.

https://bugzilla.gnome.org/show_bug.cgi?id=725866
2014-04-05 17:01:03 -04:00
Carlos Garnacho
9341779f4d entry: use priv->dnd_position when rendering the DND cursor
This makes "cursor position" track the DnD point again, looks much
more intuitive than just rendering it on the pre-DnD position.

https://bugzilla.gnome.org/show_bug.cgi?id=725866
2014-04-05 17:01:03 -04:00
Matthias Clasen
e617464d50 Improve GtkStack documentation
As has been pointed out in
https://bugzilla.gnome.org/show_bug.cgi?id=725711
it is a little confusing that we have the concept of
a visible child and of the child being visible itself.
2014-04-05 17:01:03 -04:00
Claudio Saavedra
e43fd6f8c7 gtkentrycompletion: fix a critical warning
There are early returns in this method before the completion timeout
is set later on, so set the source to 0 to avoid trying to remove it
later again.

https://bugzilla.gnome.org/show_bug.cgi?id=725824
2014-04-05 17:01:02 -04:00
Lars Uebernickel
ba003f7f42 gtkmenu: displace popups by their css margin
Without a margin, the pointer is above the first (or last) menu item,
making it easy to accidentally activate that item.

https://bugzilla.gnome.org/show_bug.cgi?id=591258
2014-04-05 17:01:02 -04:00
Marek Kasik
d60a903407 GtkIconViewAccessible: Don't access freed item
Don't get index from deleted GtkIconViewItem.
Remove the item before traversing list of items.

https://bugzilla.gnome.org/show_bug.cgi?id=701884
2014-04-05 17:01:02 -04:00
Benjamin Otte
402776103a broadway: Print a useful error message
.. instead of the generic "failed to open display".
2014-04-05 17:01:01 -04:00
Matthias Clasen
cfeceb17b3 GtkRange: make autoscrolling work for inverted ranges
This problem was discovered in
https://bugzilla.gnome.org/show_bug.cgi?id=725225
2014-04-05 17:01:00 -04:00
Christoph Reiter
e70eebda16 treeselection docs: spelling fix
https://bugzilla.gnome.org/show_bug.cgi?id=725205
2014-04-05 17:00:59 -04:00
Andrés G. Aragoneses
3aae2dad40 trivial: fix typo in docs of gtk_css_provider_to_string 2014-04-05 17:00:59 -04:00
Andrés G. Aragoneses
949c6a15a6 autogen.sh: fail faster/clearer if g-i not found
GOBJECT_INTROSPECTION_CHECK macro can be missing if introspection
is not installed, so this way the following error is prevented:

"gtk/Makefile.am:1324: error: HAVE_INTROSPECTION does not appear
in AM_CONDITIONAL"

https://bugzilla.gnome.org/show_bug.cgi?id=723438
2014-04-05 17:00:58 -04:00
Andrés G. Aragoneses
fbf8089019 trivial: fix typo in docs of gtk_css_provider_to_string 2014-04-05 17:00:57 -04:00
Benjamin Otte
28df43806e reftests: Add a test for a widget stacking regression
GTK 3.10 fails to obey the stacking order when drawing widgets.

https://bugzilla.gnome.org/show_bug.cgi?id=725089
2014-04-05 17:00:56 -04:00
Benjamin Otte
9b5183a9ce fixed: Fix drawing order
Restore the drawing order in GtkFixed to what it was in 3.8. With the
GDK drawing changes this will not be correct in some cases (un-windowed
children can now overlap windowed children and native children overlap
everything), but fixes Eclipse drawing.

https://bugzilla.gnome.org/show_bug.cgi?id=725089
2014-04-05 17:00:56 -04:00
Giovanni Campagna
e4d551766b pixbuf-demo: don't lock the window size
What's the use of an animation demo, if you can interactively
resize it and show off how cool is your window system handling
updates?

https://bugzilla.gnome.org/show_bug.cgi?id=725172
2014-04-05 17:00:55 -04:00
Matthias Clasen
1a2bd60e14 Fix life-cycle handling of treeview columns
gtk_tree_view_remove_column was first removing the column from
its list, then call gtk_tree_view_column_unset_tree_view, which
would then call gtk_container_remove to remove its button from
the treeview. But the treeview remove implementation relied
on the column being still in the list in order to recognize
the button as 'special', so in effect the button was never
properly removed and thus, leaked.

Fix this by callling unset_tree_view before removing the
column from the list.

https://bugzilla.gnome.org/show_bug.cgi?id=724891
2014-04-05 17:00:54 -04:00
Paolo Borelli
16a197c311 Do not leak cairo_region 2014-04-05 17:00:53 -04:00
Matthias Clasen
418573eca8 GtkTooltip: Avoid extra work
When we are hiding the label or icon anyway, no need to change
it right before, causing reallocation overhead.
2014-04-05 17:00:53 -04:00
Matthias Clasen
e881f553c2 Fix a small memory leak
GtkPrintUnixDialog was leaking a GFile.
Spotted by Christian Persch in
https://bugzilla.gnome.org/show_bug.cgi?id=724631
2014-04-05 17:00:52 -04:00
Ignacio Casal Quinteiro
d0f593f5b8 Remove duplicated word "id" from warning message 2014-04-05 17:00:51 -04:00
Matthias Clasen
6e433c08e8 GtkLabel: don't eat too many button release events
We should only eat button release events when the label is
actually selectable, since the comment indicates that we
want to eat the release events belonging to press events
that triggered a selection. This fixes problems with actions
on parent widgets that are triggered by button release,
as seen in this bug:

https://bugzilla.gnome.org/show_bug.cgi?id=724541
2014-04-05 17:00:51 -04:00
Matthias Clasen
dc6edb553d tree view: clean up custom search entry on destroy
Suprisingly, this bug has been there for a very long time.
I'm fixing it now because we now use a custom search entry
in the app chooser dialog, and this is causing the templates
cleanup test to fail.
2014-04-05 17:00:50 -04:00
Ting-Wei Lan
0a6f0dfedd Do not return things from a void function
Reported in https://bugzilla.gnome.org/show_bug.cgi?id=724008
Author:    Ting-Wei Lan <lantw44@gmail.com>
2014-04-05 17:00:49 -04:00
Benjamin Otte
8e7dd6d8ff label: Avoid creating new attribute list
Only create an attribute list for merging if we actually need to merge.

This bug was introduced in 5230cfe805
2014-04-05 17:00:49 -04:00
Alexander Larsson
5e39ee3ab4 gdkwindow: Fix gdk_window_set_child_shapes()
This did the reverse of what it should, making the shape be
the part where the children were *not*.
2014-04-05 17:00:48 -04:00
Matthias Clasen
9a298efbac GtkMountOperation: Clean up a dangling signal handler
Based on a patch by Eugene Shatokhin,
https://bugzilla.gnome.org/show_bug.cgi?id=723366
2014-04-05 17:00:47 -04:00
Adam Jackson
917f00fab0 X11: Decode extension names in the error handler
This commit uses the Xlib cache to obtain the name of the X extension
for the request that caused the error.

https://bugzilla.gnome.org/review?bug=723555
2014-04-05 17:00:47 -04:00
Benjamin Otte
eec4afa26b css: Fix computation of pixels occupied by blur radius
These computations were done randomly in lots of places and more often
than not, they were also wrong.
This function was copied (with docs) from Firefox:
  http://lxr.mozilla.org/mozilla-central/source/gfx/2d/Blur.cpp

https://bugzilla.gnome.org/show_bug.cgi?id=723159
2014-04-05 17:00:46 -04:00
Benjamin Otte
4d2cc13ea2 a11y: Ignore deprecation warnings for ATK focus tracker 2014-04-05 17:00:45 -04:00
Jasper St. Pierre
971b3a5042 gdkwindow-x11: Fix compile warning
It doesn't actually matter, since we don't pass any real attributes
anyway, but this should be the correct type...
2014-04-05 17:00:45 -04:00
Jasper St. Pierre
eac915a5ae gdkwindow: Use an InputOnly window for focus_window
For XWayland, this is somewhat important to prevent a dummy XWayland surface
being made for all clients that connect...

https://bugzilla.gnome.org/show_bug.cgi?id=723390
2014-04-05 17:00:44 -04:00
Giovanni Campagna
f5393a1bce GtkStyleContext: don't use disconnect_by_func()
disconnect_by_func() is slow, and this becomes particularly evident
when disposing a number of widgets (and their associated style
context) at once, such as when using a language binding which
uses a GC.

https://bugzilla.gnome.org/show_bug.cgi?id=723183
2014-04-05 12:03:11 -04:00
William Jon McCann
2206667f10 docs: remove spurious quotation mark 2014-04-05 12:02:52 -04:00
Carlos Garnacho
65a1283b18 listbox: return GDK_EVENT_STOP if button events were handled
The button press/release handlers did invariably return FALSE, even
though it shouldn't if a row was found on the event coordinates. Also,
use GDK_EVENT_* defines for the return values.
2014-04-05 12:02:37 -04:00
Kjell Ahlstedt
9cdfc30962 Improve doc of gtk_widget_override_color()
Mention that it's not recursively applied to a container's children.

https://bugzilla.gnome.org/show_bug.cgi?id=566945
2014-04-05 12:02:11 -04:00
Matthias Clasen
70d8cd8142 Trivial typo fix 2014-04-05 12:01:44 -04:00
Matthias Clasen
d7297d1c4c Paper dialog: Use baseline alignment
This improves the positioning of the labels wrt to the spin
buttons.
2014-04-05 12:01:35 -04:00
Matthias Clasen
7121e4b3b5 Print dialog: Use baseline alignment in page setup tab
Based on a patch from
https://bugzilla.gnome.org/show_bug.cgi?id=722722
2014-04-05 12:01:28 -04:00
Nikita Churaev
519b1a8dbd Fix vertical alignment of labels in "Paper" section of the print dialog
https://bugzilla.gnome.org/show_bug.cgi?id=722722
2014-04-05 12:01:11 -04:00