Matthias Clasen
143770f16d
4.3.1
2021-06-09 18:23:47 -04:00
Matthias Clasen
8a890238f5
Merge branch 'ebassi/docs-for-master' into 'master'
...
docs: Mention Window::close-request in the migration guide
See merge request GNOME/gtk!3655
2021-06-09 17:30:02 +00:00
Emmanuele Bassi
71be3a8de1
docs: Mention the ::damage-event signal in the migration guide
...
There is no replacement for damage event tracking.
2021-06-09 18:11:10 +01:00
Emmanuele Bassi
17373c3e77
docs: Mention GdkSurface:mapped
...
It replaces the ::map-event and ::unmap-event signals on GtkWidget.
2021-06-09 18:08:31 +01:00
Emmanuele Bassi
078ada75d4
docs: Mention Window::close-request in the migration guide
...
The Widget::delete-event signal was moved to Window::close-request.
2021-06-09 18:03:12 +01:00
Matthias Clasen
51a60b88b7
Merge branch 'ci-install-build' into 'master'
...
Make a standalone hello world
See merge request GNOME/gtk!3652
2021-06-09 12:59:46 +00:00
Matthias Clasen
193903ce4a
ci: Update the image
...
v32 of the image includes wayland-protocols 1.21, and
other updates from Fedora 34.
While we are at it, drop gtk-doc from the image, and drop
the separate DOCS_IMAGE - no longer used.
2021-06-09 08:42:37 -04:00
Matthias Clasen
386002597b
ci: Collect hello build logs
2021-06-09 08:42:30 -04:00
Matthias Clasen
e5a6d4a1c8
ci: Test building against installed GTK
...
This is meant to ensure that we e.g. install the
right header files, and so on.
2021-06-09 08:42:30 -04:00
Matthias Clasen
06caa57f9a
Make a standalone hello world
...
We want to test building against the installed GTK
in ci, so lets add a standalone project.
2021-06-08 17:41:11 -04:00
Matthias Clasen
5ef6944a41
Merge branch 'row-activated-annotation' into 'master'
...
treeview: Add a few missing annotations
Closes #3828
See merge request GNOME/gtk!3647
2021-06-08 17:17:45 +00:00
Matthias Clasen
2e415e266f
Merge branch 'wip/carlosg/spin-button-swipe-gesture' into 'master'
...
spinbutton: Connect swipe gesture to the text entry
Closes #4008
See merge request GNOME/gtk!3649
2021-06-08 14:54:26 +00:00
Carlos Garnacho
915388cfdb
spinbutton: Mind the step in the swipe gesture
...
The swipe gesture forces values in the spin button that are
"impossible" according to the adjustment. This can break things
in creative ways.
Ensure the steps provided are always multiples of the adjustment
step value, and keep the remainder for further interaction.
2021-06-08 15:18:14 +02:00
Carlos Garnacho
1bf7f5eacb
spinbutton: Connect swipe gesture to the text entry
...
In the GTK3 days, the spin button was an entry, with buttons on
top, and the swipe gesture affected the input on the entry bits.
Now the spin button is a container, so this gesture in the capture
phase applies to all contained children (incl. buttons).
Attach this gesture to the entry itself, so the buttons are left
outside this business. The gesture is still in the capture phase
in order to prevent text selection/edition/etc to happen.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/4008
2021-06-08 15:17:56 +02:00
Matthias Clasen
6a86acb9ce
Apply 1 suggestion(s) to 1 file(s)
2021-06-08 12:59:57 +00:00
Matthias Clasen
e35e7bcd4a
Apply 1 suggestion(s) to 1 file(s)
2021-06-08 12:59:38 +00:00
Matthias Clasen
37acfcfcd5
Merge branch 'password-entry-buffer' into 'master'
...
Install gtkpasswordentrybuffer.h
See merge request GNOME/gtk!3646
2021-06-08 12:09:01 +00:00
Matthias Clasen
c2f2a45227
treeview: Documentation tweaks
2021-06-08 07:59:47 -04:00
Matthias Clasen
621e0a13e9
Install gtkpasswordentrybuffer.h
2021-06-08 07:49:42 -04:00
Matthias Clasen
92fcd37a19
Merge branch 'password-entry-buffer' into 'master'
...
Make GtkPasswordEntryBuffer public
See merge request GNOME/gtk!3645
2021-06-08 11:25:12 +00:00
Matthias Clasen
d8bde48b87
Make GtkPasswordEntryBuffer public
2021-06-08 11:25:11 +00:00
Matthias Clasen
825ffb9422
Merge branch 'ebassi/issue-3892' into 'master'
...
a11y: Update the level property for tree expanders
Closes #3892
See merge request GNOME/gtk!3470
2021-06-07 18:10:12 +00:00
Emmanuele Bassi
046ef010b3
Merge branch 'glib-main' into 'master'
...
subprojects: Use GLib main branch
See merge request GNOME/gtk!3642
2021-06-07 14:53:04 +00:00
Philip Withnall
b71ec6cb59
subprojects: Use GLib main branch
...
GLib upstream has renamed its `master` branch to `main`.
See https://gitlab.gnome.org/GNOME/glib/-/issues/2348 .
Signed-off-by: Philip Withnall <pwithnall@endlessos.org >
2021-06-07 14:56:49 +01:00
Matthias Clasen
b1beb3650b
treeview: Add a few missing annotations
...
gtk_tree_view_row_activated and the ::row-activated signal
can (and do) receive NULL for the column occasionally.
This is an introspection api change.
Fixes : #3828
2021-06-06 08:24:52 -04:00
Matthias Clasen
fca19e72ad
Merge branch 'matthiasc/for-master' into 'master'
...
Docs: Tweaks
Closes #3638
See merge request GNOME/gtk!3639
2021-06-05 22:13:21 +00:00
Matthias Clasen
98d2320c93
gtk-builder-tool: Replace can-focus with focusable
...
The focusable property has the meaning that can-focus had
in GTK 3.
Update tests, and mention this in the migration guide.
Fixes : #3638
2021-06-05 17:56:35 -04:00
Matthias Clasen
effc7a619d
Docs: Tweaks
...
Remove some more redundant "or NULL" blurbs.
2021-06-05 17:38:23 -04:00
Matthias Clasen
0ec017fcc0
Merge branch 'matthiasc/for-master' into 'master'
...
popovermenu: doc tweaks
See merge request GNOME/gtk!3638
2021-06-05 21:36:06 +00:00
Matthias Clasen
94ad177176
popovermenu: doc tweaks
2021-06-05 17:19:39 -04:00
Matthias Clasen
4616104742
Merge branch 'submenu-action-fixes' into 'master'
...
Submenu action fixes
Closes #3721
See merge request GNOME/gtk!3272
2021-06-05 13:36:10 +00:00
Matthias Clasen
a3a24b81c8
Merge branch 'msvc-aarch64' into 'master'
...
gtkpopcountprivate.h: Fix build on ARM/aarch64 Visual Studio
See merge request GNOME/gtk!3637
2021-06-05 13:05:15 +00:00
Matthias Clasen
debcc62775
menusectionbox: Fix submenu-action for nested menus
...
We were not updating the state of submenu-actions
for nested submenus.
Fixes : #3721
2021-06-05 08:49:18 -04:00
Matthias Clasen
b11f31afea
popovermenubar: Make submenu-actions work
...
We were not updating submenu-action state
for items in menubars.
2021-06-05 08:49:17 -04:00
Matthias Clasen
db2e5648c9
menutrackeritem: Make submenu-actions work again
...
This broke when GtkActionMuxer stopped being a
GActionGroup.
2021-06-05 08:49:17 -04:00
Matthias Clasen
46d1f04a7c
bloatpad: Bring back the menubar
...
This was lost at some point.
2021-06-05 08:49:17 -04:00
Matthias Clasen
fe774c1ad8
Merge branch 'powimod_icon' into 'master'
...
Load icon from executable on Windows
Closes #3713
See merge request GNOME/gtk!3326
2021-06-05 12:47:08 +00:00
Chun-wei Fan
08ee36e7c4
gtkpopcountprivate.h: Fix build on ARM/aarch64 Visual Studio
...
__popcnt() is not supported for ARM nor ARM64 Visual Studio builds, so we must
use the fallback implementation as intrinsics are not supported for this
purpose on ARM/ARM64 Visual Studio builds.
2021-06-05 15:41:14 +08:00
Matthias Clasen
1605ec0a44
Merge branch 'ci-file-filters' into 'master'
...
GtkFileFilter: Allow case-insensitive patterns
Closes #3705
See merge request GNOME/gtk!359
2021-06-05 01:47:24 +00:00
Matthias Clasen
4b46e11b22
Merge branch 'imcontext-ignore-more-keysyms' into 'master'
...
imcontext: Ignore more keysyms
See merge request GNOME/gtk!3634
2021-06-05 01:19:39 +00:00
Matthias Clasen
9993e91add
Add GtkFileFilter tests
2021-06-04 21:10:01 -04:00
Matthias Clasen
9ac22c1088
GtkFileFilter: Add suffix matches
...
This is less flexible than a glob pattern, but it is
explicitly case-insensitive, to match the behavior
on Windows.
Fixes : #3705
2021-06-04 21:10:01 -04:00
Matthias Clasen
47400e4bd8
Add a helper to make case-insensitive globs
...
This will be used in GtkFileFilter in the future.
Tests included.
2021-06-04 21:10:01 -04:00
Matthias Clasen
8981ba4bd2
imcontext: Ignore more keysyms
...
It finally dawned on my that #3673 is just another
case of unexpected keysyms getting sent our way via
fringe XKB features.
Ignore them all!
2021-06-04 19:01:57 -04:00
Matthias Clasen
74a41eeb70
Merge branch 'matthiasc/for-master' into 'master'
...
docs: Mention <packing> in migration guide
Closes #3950 and #2271
See merge request GNOME/gtk!3630
2021-06-04 20:24:23 +00:00
Matthias Clasen
ff874318c0
Merge branch 'master' into 'matthiasc/for-master'
...
# Conflicts:
# docs/reference/gtk/migrating-3to4.md
2021-06-04 20:24:09 +00:00
Matthias Clasen
a4598567b9
icontheme: Add detail to the 'not found' message
...
Name the icon theme we're using.
Fixes : #2271
2021-06-04 09:49:05 -04:00
Matthias Clasen
8f95661167
Clean up some comments
...
These XXX comments aren't useful enough to keep.
2021-06-04 09:49:05 -04:00
Matthias Clasen
e437c55142
Add a doc comment for gsk_rounded_rect_is_circular
2021-06-04 09:49:05 -04:00
Matthias Clasen
ff01067b8b
Merge branch 'matthiasc/for-master' into 'master'
...
docs: Mention <packing> in migration guide
Closes #3950
See merge request GNOME/gtk!3629
2021-06-04 13:21:37 +00:00
Matthias Clasen
7f4630abac
wayland: Add a comment
...
I just had to debug this to rediscover how it works, so
add a comment for next time.
2021-06-04 08:30:52 -04:00
Matthias Clasen
4c9bd6ed9a
wayland: Add a comment
...
I just had to debug this to rediscover how it works, so
add a comment for next time.
2021-06-04 08:29:23 -04:00
Matthias Clasen
b6cd97be1e
docs: Escape some xml tags
...
When mentioning xml tags in markdown, we must write
them as `<foo>`, or they will come out mangled.
2021-06-04 08:06:18 -04:00
Matthias Clasen
c4cbd6ec1b
docs: Mention <packing> in migration guide
...
Add another hint for what to do with child properties.
Fixes : #3950
2021-06-04 07:59:07 -04:00
Matthias Clasen
312289fb11
docs: Mention <packing> in migration guide
...
Add another hint for what to do with child properties.
Fixes : #3950
2021-06-04 07:42:21 -04:00
Matthias Clasen
036dd60a4e
Merge branch 'matthiasc/for-master' into 'master'
...
fnmatch: Support case-folding
See merge request GNOME/gtk!3628
2021-06-04 04:43:20 +00:00
Matthias Clasen
10c6c93f40
Merge branch 'gtk_combo_box_with_entry_docs_update' into 'master'
...
Documentation update for combo_box_new_with_entry
See merge request GNOME/gtk!3605
2021-06-04 04:02:48 +00:00
DarkTrick
4d894e08f7
Documentation update for combo_box_new_with_entry
2021-06-04 04:02:48 +00:00
Matthias Clasen
31407d0a4c
Move fnmatch testcases to the testsuite
...
We have a well-working way to test internal
apis now, lets use it for these tests.
2021-06-03 23:58:50 -04:00
Matthias Clasen
bb53cf53e7
fnmatch: Support case-folding
...
This will be used in GtkFileFilter in the future.
Update all callers.
2021-06-03 23:58:21 -04:00
Matthias Clasen
da9cd4659e
Merge branch 'bilelmoussaoui/markdown-links' into 'master'
...
docs: use markdown syntax for hyperlinks
See merge request GNOME/gtk!3589
2021-06-04 02:45:25 +00:00
Matthias Clasen
d3e6e303fc
Merge branch 'GtkCellLayoutWordingImprovement' into 'master'
...
Added information, that "attributes" refer to CellRenderer "properties".
See merge request GNOME/gtk!3602
2021-06-04 02:21:33 +00:00
DarkTrick
a0c23b1c3d
Added information, that "attributes" refer to CellRenderer "properties".
2021-06-04 02:21:31 +00:00
Matthias Clasen
50b3a952c8
Merge branch 'fix-appwindow-allocate' into 'master'
...
applicationwindow: Allocate tooltips
Closes #3997
See merge request GNOME/gtk!3627
2021-06-04 02:01:53 +00:00
Matthias Clasen
15b24a000d
Apply 1 suggestion(s) to 1 file(s)
2021-06-04 01:53:12 +00:00
Matthias Clasen
6a509608f9
applicationwindow: Allocate tooltips
...
GtkApplicationWindows size_allocate does not chain
up if the menubar is visible; don't forget to allocate
the tooltip window in that case.
Fixes : #3997
2021-06-03 21:43:13 -04:00
Matthias Clasen
df6a52520c
Merge branch 'matthiasc/for-master' into 'master'
...
Cosmetics: Eradicate gdouble
See merge request GNOME/gtk!3626
2021-06-03 21:59:26 +00:00
Matthias Clasen
578db92973
Cosmetics: Eradicate gint
...
Remove a handful of errant uses of gint.
2021-06-03 17:41:28 -04:00
Matthias Clasen
3ab97fac1f
Cosmetics: Eradicate gdouble
...
Remove 3 errant uses of gdouble.
2021-06-03 17:41:28 -04:00
Matthias Clasen
e8852c9a25
Merge branch 'primary-menu-button' into 'master'
...
menubutton: Enable F10 for primary menus
See merge request GNOME/gtk!3580
2021-06-03 19:37:23 +00:00
Matthias Clasen
fa0b379d30
Merge branch 'wip/carlosg/no-early-popup-ungrabs' into 'master'
...
gdk/wayland: Break only implicit grabs on wl_pointer.leave w/ pressed buttons
See merge request GNOME/gtk!3625
2021-06-03 18:10:06 +00:00
Emmanuele Bassi
1565053842
Merge branch 'akamfoad/readme-link-fixes' into 'master'
...
Update broken links in README.md
Closes #4001
See merge request GNOME/gtk!3623
2021-06-03 15:23:45 +00:00
Carlos Garnacho
8288d9e87c
gdk/wayland: Break only implicit grabs on wl_pointer.leave w/ pressed buttons
...
The releasing of grabs while a button is pressed (e.g. after starting dnd, or
dragging the window, or going to overview with a pressed button, etc...) was
generalized here in https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1879 .
However we shouldn't break all grabs here. In the case of grabbing popups,
compositors will still emit crossing events between client surfaces (e.g.
popping up and selecting a menu item via press-drag-release), breaking all
grabs here means inconsistent client state, that was
https://gitlab.gnome.org/GNOME/gtk/-/issues/2746 .
That was fixed in mutter, by essentially making implicit grabs
owner_events=FALSE, however that breaks the mentioned use pattern entirely.
Mutter is changing this behavior back, so GTK should handle these crossing
events.
The grab that we are interested in breaking here is the implicit pointer
one. Popups will be dismissed via other means if the compositor says their
active grab needs breaking. This still leaves dnd/move/resize drags in
one place, while not allowing #2746 to happen with popups.
2021-06-03 17:13:12 +02:00
Akam Foad
a900b30bcf
Changing old Gtk4 link to the new one hosted in gtk docs
2021-06-03 14:22:06 +00:00
Akam Foad
9b671d1f79
Update broken links in README.md
...
Updated Release notes links from https://developer.gnome.org/gtkX/unstable/YYYY.html
to https://developer.gnome.org/gtkX/stable/YYYY.html in the README.md file in the root
folder.
Closes #4001
2021-06-03 14:02:59 +00:00
Emmanuele Bassi
c2d82c23e6
Merge branch 'ebassi/doc-fixes' into 'master'
...
Small doc fixes
See merge request GNOME/gtk!3622
2021-06-03 10:32:01 +00:00
Emmanuele Bassi
a88b4f517e
docs: Fix link to the interactive debugging section
...
It's in the "running" document.
2021-06-03 09:31:13 +01:00
Emmanuele Bassi
f9f9fa6dc6
docs: Fix the license field
...
It's LGPL-2.1-or-later, not GPL.
2021-06-03 09:11:09 +01:00
Matthias Clasen
a1789ee2b8
Merge branch 'wip/chergert/fix-use-after-free-switcher' into 'master'
...
stackswitcher: clear timer when widget id disposed
See merge request GNOME/gtk!3621
2021-06-02 20:21:57 +00:00
Matthias Clasen
ffb7df2cc4
Merge branch 'macos-menubar' into 'master'
...
macos: fix weird menubar rendering.
Closes #3967
See merge request GNOME/gtk!3607
2021-06-02 20:13:16 +00:00
Christian Hergert
c2ca246aee
stackswitcher: clear timer when widget id disposed
...
If the widget is disposed while the cursor has a drag timeout queued, it
can activate after finalization.
2021-06-02 10:20:32 -07:00
Matthias Clasen
80c33ca2dd
Merge branch 'wip/otte/for-master' into 'master'
...
x11: Be more careful with NVIDIA workaround
See merge request GNOME/gtk!3620
2021-06-02 14:57:52 +00:00
Matthias Clasen
7307c6fdfb
Merge branch 'entry-docs-typo' into 'master'
...
entry: Fix a typo in the docs
See merge request GNOME/gtk!3619
2021-06-02 11:15:10 +00:00
Matthias Clasen
039fc2e567
entry: Fix a typo in the docs
2021-06-02 06:47:27 -04:00
Matthias Clasen
1dcf9d5c95
Merge branch 'wip/exalm/treeview-click' into 'master'
...
treeview: Don't handle clicks on any child widgets
Closes #3996
See merge request GNOME/gtk!3618
2021-06-02 10:33:50 +00:00
Matthias Clasen
742482e0e1
Merge branch 'box-orientation' into 'master'
...
progressbar: Avoid redundant storage
See merge request GNOME/gtk!3617
2021-06-02 10:16:17 +00:00
Alexander Mikhaylenko
80497debbb
treeview: Don't handle clicks on any child widgets
...
We already skip them on the edited cell widget, but it's also a problem for
header buttons. Overall, there's no real reason to let it propagate here.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3996
2021-06-02 13:49:11 +05:00
Matthias Clasen
bffc6c5b9a
spinbutton: Avoid redundant storage
...
GtkBoxLayout stores the orientation; no need for
GtkSpinButton to duplicate that.
2021-06-01 17:37:07 -04:00
Matthias Clasen
95747b1a40
progressbar: Avoid redundant storage
...
GtkBoxLayout stores the orientation; no need for
GtkProgressBar to duplicate that.
2021-06-01 17:37:01 -04:00
Matthias Clasen
775dbec2e6
Merge branch 'demo-appdata' into 'master'
...
demos: Generate appdata
Closes #3993
See merge request GNOME/gtk!3613
2021-06-01 20:17:16 +00:00
Matthias Clasen
25ee6d3f47
demos: Generate appdata
...
We don't maintain a release history here, but at least
we can put in the right version and date for the current
build.
Fixes : #3993
2021-06-01 15:36:33 -04:00
Matthias Clasen
1f3f2f1dca
Merge branch 'wip/chergert/switcher-orientable' into 'master'
...
stackswitcher: implement GtkOrientable
Closes #3988
See merge request GNOME/gtk!3606
2021-06-01 18:28:23 +00:00
Christian Hergert
c848a51395
stackswitcher: implement GtkOrientable
...
In GTK 3, GtkStackSwitcher implemented GtkOrientable via the parent GtkBox
type. In GTK 4, that was changed to inherit from GtkWidget and lost this
interface implementation.
This adds that back, along with a note in the documentation that the
interface was added in GTK 4.4.
Fixes #3988
2021-06-01 10:57:27 -07:00
Matthias Clasen
7d3c3cb653
Merge branch 'fix_cast_warning_adding_notebook_page' into 'master'
...
invalid cast from 'GtkButton' to 'GtkBox'
See merge request GNOME/gtk!3615
2021-06-01 16:18:31 +00:00
Caolán McNamara
9c79b8b877
invalid cast from 'GtkButton' to 'GtkBox'
...
on adding a page to a GtkNotebook
(soffice): Gtk-CRITICAL **: gtk_box_remove: assertion 'GTK_IS_BOX (box)' failed
2021-06-01 14:56:53 +01:00
Matthias Clasen
c137f4017f
Merge branch 'screensaver-async-4' into 'master'
...
gtkapplication-dbus: Fetch inital screen saver state async
See merge request GNOME/gtk!3599
2021-06-01 11:14:38 +00:00
Matthias Clasen
c92b21b5fd
Merge branch 'fix-has-actionable-function' into 'master'
...
texthistory: fix has_actionable function
See merge request GNOME/gtk!3612
2021-06-01 11:04:56 +00:00
liferooter
44f07f7708
texthistory: fix has_actionable function
2021-06-01 11:04:55 +00:00
Matthias Clasen
b85b4f2cd6
Merge branch 'box-orientation' into 'master'
...
box: Avoid redundant storage
See merge request GNOME/gtk!3611
2021-05-31 23:05:11 +00:00
Matthias Clasen
d1a7a55d7e
box: Avoid redundant storage
...
GtkBoxLayout stores the orientation; no need for
GtkBox to duplicate that.
2021-05-31 18:38:52 -04:00
Zhi
75868dfee4
macos: fix weird menubar rendering.
...
As app menu has been deprecated, the function of app menu should be
merged into the menubar, which behaves like the original API of NSApp.
This also brings back the default app menu, which looks like native
macOS apps.
For future refactoring, please note that the menubar must contain at
least one menu before being set to NSApp to avoid weird menubar
rendering.
Fixes #3967 .
2021-05-30 21:59:57 +08:00
Fabio Tomat
44bc9a24f8
Update Friulian translation
...
(cherry picked from commit a80804ccef
)
2021-05-27 16:13:50 +00:00
Matthias Clasen
c9785c4cd3
Merge branch 'placeholder-alignment' into 'master'
...
text: Propagate xalign to the placeholder
Closes #3979
See merge request GNOME/gtk!3604
2021-05-27 11:44:33 +00:00
Matthias Clasen
9f93883dc9
text: Propagate xalign to the placeholder
...
This is what we were doing in GTK 3, and there's
no reason not to continue.
Fixes : #3979
2021-05-27 06:57:23 -04:00
Matthias Clasen
4362f7e6e2
Merge branch 'bilelmoussaoui/for-gi-docgen-grid' into 'master'
...
docs: fix gtk grid formatting
See merge request GNOME/gtk!3603
2021-05-27 10:31:24 +00:00
Bilal Elmoussaoui
90a829f25a
docs: fix gtk grid formatting
2021-05-27 09:58:42 +00:00
Emmanuele Bassi
d0e29cc901
Merge branch 'bilelmoussaoui/for-gi-docgen' into 'master'
...
docs: fix broken links
See merge request GNOME/gtk!3601
2021-05-27 00:43:31 +00:00
Bilal Elmoussaoui
8ebdd256a5
docs: fix broken links
2021-05-27 00:18:23 +00:00
Matthias Clasen
4b5f8e6ceb
Merge branch 'test-text-buffer-undo' into 'master'
...
Add a test for text buffer history
See merge request GNOME/gtk!3596
2021-05-26 19:33:58 +00:00
Matthias Clasen
ffbfafb189
textbuffer: Add some docs for undo
...
Mention what is undoable and what isn't.
2021-05-26 14:36:16 -04:00
Matthias Clasen
994a38c7ad
textbuffer: Improve the docs
...
Add getter/setter annotations.
2021-05-26 14:36:16 -04:00
Matthias Clasen
0268c9d642
Add tests for text buffer history
...
Check that things can be undone.
2021-05-26 14:36:16 -04:00
Matthias Clasen
f729912913
Merge branch 'wip/chergert/fix-3977' into 'master'
...
textbuffer: ensure user actions are propagated to history
Closes #3977
See merge request GNOME/gtk!3600
2021-05-26 17:43:34 +00:00
Christian Hergert
6179886b14
textbuffer: ensure user actions are propagated to history
...
This was an oversight when porting the GtkTextHistory into GTK. We simply
need to bind the GtkTextBuffer action into the text history for grouping
to work correctly.
Fixes #3977
2021-05-26 10:11:33 -07:00
Guido Günther
3aa34c1211
gtkapplication-dbus: Fetch inital screen saver state async
...
Avoid a sync call that can make the application block for no good
reason.
Fixes 6bfe171058
2021-05-26 18:47:38 +02:00
Matthias Clasen
24f0ae1d39
Merge branch 'move-text-history-tests' into 'master'
...
Move text history tests
See merge request GNOME/gtk!3597
2021-05-26 12:01:58 +00:00
Matthias Clasen
c0ca3c642a
Merge branch 'picture-nullable-setters' into 'master'
...
picture: Make setters actually take NULL
Closes #3974
See merge request GNOME/gtk!3598
2021-05-26 11:46:23 +00:00
Matthias Clasen
b2b044ce95
Move text history tests
...
We can test internal apis in our testsuite now,
so move the text history tests there, to have them
run in ci.
2021-05-26 07:34:28 -04:00
Matthias Clasen
8f4b0cd30d
picture: Make setters actually take NULL
...
gtk_picture_set_file was claiming to be nullable,
but choked on NULL.
Fixes : #3974
2021-05-26 07:30:57 -04:00
Matthias Clasen
cbe2aa716d
Merge branch 'bilelmoussaoui/for-gi-docgen-link' into 'master'
...
gtk: drop unwanted char on Switch::state-set docs link
See merge request GNOME/gtk!3594
2021-05-25 23:23:39 +00:00
Bilal Elmoussaoui
23ea33b656
gtk: drop unwanted char on Switch::state-set docs link
2021-05-25 20:29:46 +00:00
Matthias Clasen
ee80a22db4
Merge branch 'wip/exalm/checks' into 'master'
...
checkbutton: Sync the indicator state with the widget
See merge request GNOME/gtk!3568
2021-05-25 20:29:06 +00:00
Matthias Clasen
d32c343657
Merge branch 'fix.vs2013.link' into 'master'
...
gtk/meson.build: Fix linking on Visual Studio 2013
See merge request GNOME/gtk!3575
2021-05-25 20:27:54 +00:00
Emmanuele Bassi
90d8c94819
Merge branch 'ebassi/introspection-error' into 'master'
...
Turn introspection scanner warnings into errors
See merge request GNOME/gtk!3588
2021-05-25 18:51:54 +00:00
Emmanuele Bassi
e13da35d4d
Turn introspection scanner warnings into errors
...
We want to catch errors in our annotations or our API.
2021-05-25 19:16:37 +01:00
Emmanuele Bassi
f50450485c
docs: Add missing documentation on Windows
...
The gtk_print_run_page_setup_dialog() function, and its asynchronous
variant, are declared in the common gtkprintoperation.h header, but
implemented in different source files depending on the platform.
2021-05-25 19:16:37 +01:00
Matthias Clasen
264d08abc4
Merge branch 'ignore-nosymbol-press' into 'master'
...
imcontext: Ignore NoSymbol key events
Closes #3973
See merge request GNOME/gtk!3591
2021-05-25 17:44:45 +00:00
Matthias Clasen
8c441756df
imcontext: Ignore NoSymbol key events
...
These can happen with some XKB options.
Fixes : #3973
2021-05-25 13:20:12 -04:00
Emmanuele Bassi
cdf2a9ddce
Merge branch 'bilelmoussaoui/for-gi-docgen' into 'master'
...
gdk: fix wrong doc annotation
See merge request GNOME/gtk!3590
2021-05-25 16:23:15 +00:00
Bilal Elmoussaoui
a196a35d1d
gdk: fix wrong doc annotation
2021-05-25 16:07:51 +00:00
Yuri Chornoivan
aeda5b2f58
Update Ukrainian translation
2021-05-25 13:19:55 +00:00
Bilal Elmoussaoui
02672a521a
docs: use markdown syntax for hyperlinks
2021-05-25 13:14:01 +00:00
Emmanuele Bassi
da1e43c1e6
Merge branch 'ebassi/docs-fixes' into 'master'
...
Enable fatal warnings for gi-docgen
See merge request GNOME/gtk!3587
2021-05-25 12:57:28 +00:00
Emmanuele Bassi
6d06b0f076
Enable fatal warnings when build the docs
...
We want to fail the CI pipeline when the documentation generator emits a
warning.
2021-05-25 13:32:32 +01:00
Emmanuele Bassi
7da2e86d4b
docs: Fix the PANGO_SCALE link
...
The fragment for constants is `const`.
2021-05-25 13:31:49 +01:00
Matthias Clasen
1f99723a9f
Merge branch 'fix-im-reset' into 'master'
...
imcontextsimple: Fix a possible problem
See merge request GNOME/gtk!3584
2021-05-25 12:09:38 +00:00
Matthias Clasen
c3c16bd2be
Merge branch 'matthiasc/for-master' into 'master'
...
doc: Syntax fixes
See merge request GNOME/gtk!3583
2021-05-25 11:57:48 +00:00
Matthias Clasen
4c2761302a
doc: Syntax fixes
...
No, we can't have links that say [constructor@...] or
[mehtod@...] or [methoc@...] or [methos@...] or [metohd@...].
And no, not [signals@...] either.
2021-05-25 07:33:55 -04:00
Emmanuele Bassi
3d19b1108a
Merge branch 'bilelmoussaoui/gi-docgen-link-fix' into 'master'
...
gtk: fix gi-docgen link type
See merge request GNOME/gtk!3582
2021-05-25 11:26:08 +00:00
Bilal Elmoussaoui
4728d7b70b
gtk: fix gi-docgen link type
...
constructors are supposed to use "ctor" as a link type, not new
2021-05-25 09:25:32 +00:00
Matthias Clasen
cbd34cd239
Merge branch 'quartz-elide-underscores' into 'master'
...
Bring back elide_underscores
See merge request GNOME/gtk!3581
2021-05-24 22:55:10 +00:00
Matthias Clasen
d0ca4a1255
imcontextsimple: Fix a possible problem
...
We were forgetting to handle the compose sequence
case in reset().
2021-05-24 18:53:14 -04:00
Matthias Clasen
16623d4e71
quartz: Elide underscores again
...
We don't want a literal _File to show up in the
global menubar on OS X, so use the revivied
_gtk_elide_underscores.
Related: #3967
2021-05-24 17:39:05 -04:00
Matthias Clasen
dab7ceaa24
Bring back elide_underscores
...
This used to live in gtktoolbar.c, which is gone.
We still need it, so put it in gtkprivate.c.
2021-05-24 17:37:05 -04:00
Matthias Clasen
a74420bc1a
menubutton: Enable F10 for primary menus
...
Add a ::primary property to GtkMenuButton, which can
be set to make the menu activatable with F10, like
menubars.
2021-05-24 17:27:40 -04:00
Emmanuele Bassi
b05f3f5614
Merge branch 'gallery-reflow-fix' into 'master'
...
docs: Convince the widget gallery to reflow
See merge request GNOME/gtk!3579
2021-05-24 15:44:26 +00:00
Matthias Clasen
808e5421a9
docs: Convince the widget gallery to reflow
2021-05-24 10:51:02 -04:00
Matthias Clasen
f1f225c6b3
Merge branch 'gst.gl.win32' into 'master'
...
media/gstreamer: Support using GL for video for Windows
See merge request GNOME/gtk!3506
2021-05-24 11:37:06 +00:00
Chun-wei Fan
16f307b305
media-gstreamer: Provide fallback mode for playback
...
Make the "gl-context" property of the GstGLSink readable as well so that
we can query whether the GstGLContext sharing really succeeded. If it
did, then we proceed to playback our video using the glimagesink as we
did before. If it didn't, throw out the GtkGstSink we were creating, and
re-create the GtkGstSink without the "gl-context" property, meaning that
we won't be using the glimagesink in this case.
2021-05-24 19:04:37 +08:00
Chun-wei Fan
ccdec5da77
gtkgstsink.c: Support EGL on Windows as well
...
Add support to look for and use the EGL context in Windows if it was activated
instead of desktop OpenGL.
GstGL may have been built with or without EGL/libANGLE support, so if it were,
check in GstGL whether we have gst_gl_display_new_with_type() to create a
GstGLDisplay that is of the GST_GL_WINDOW_WIN32 type when we are using
Desktop OpenGL (WGL), otherwise we show messages indicating that envvars
need to be set to initialize GstGL properly.
Due to a bug in GstGL, the GstGLContext can only be set up successfully
if one of the following is true:
* An OpenGL 3.x or later emulator, such as Mesa is used (for WGL)
* The latest GstGL master is being used, at the time of writing (for
WGL)
* GTK, libepoxy and GstGL are all built only with WGL support (for WGL)
* EGL is being used in GTK at runtime
Special thanks to Matthew Waters for the help during the process.
2021-05-24 19:04:14 +08:00
Chun-wei Fan
52d1c0c271
media/gstreamer: Support using GL for video for Windows
...
Add support to share the WGL context in GDK with the WGL context in GStreamer,
so that we can also use OpenGL in the gstreamer media backend to playback
videos. For now OpenGL/ES is not supported for this under Windows.
The process of setting this up in Windows is a little bit more involved, as:
* The OpenGL support in GstGL requires a GL 4.1 Core context, but we may just
get the GL version from wglCreateContextAttribsARB() that we pass into the
attributes, which is 3.2 by default. So, try to ask for a 4.1 Core context
first if we are asking for anything less.
* There is only one GstDisplay available for Windows, so we just use
gst_gl_display_new().
* We must explicitly tell libepoxy that we are using wglMakeCurrent() outside
of libepoxy that is being used in GdkGL, otherwise we would end up crashing
as the GL/WGL function pointers would become invalid.
* We must also deactivate temporarily the underlying WGL context that was made
current by gdk_gl_context_make_current() so that when
gst_gl_display_create_context() calls wglShareLists(), we won't get bitten
by error 0xaa (resource busy), as some drivers don't handle this well when
the GL context is current in another thread.
For the last two points we make use of macros defined by the platforms that the
build is done for to help us carry out the necessary tasks as needed.
Thanks to Matthew Waters for the info on integrating GstGL and windowing
toolkits on Windows.
2021-05-24 16:36:40 +08:00
Chun-wei Fan
943559da67
gtk/meson.build: Fix linking on Visual Studio 2013
...
Visual Studio 2013's linker does not suport `/WHOLEARCHIVE:`, so just
explicitly extract the objects from the static libraries that will
form the final GTK DLL.
2021-05-24 10:30:34 +08:00
Matthias Clasen
21057fb857
Merge branch 'focusable-fixes' into 'master'
...
label: Fix mnemonic activation
Closes #3965
See merge request GNOME/gtk!3578
2021-05-23 15:53:27 +00:00
Matthias Clasen
281bb5e2c4
treeviewcolumn: Use focusable when we mean it
...
The focusable property has taken over the role that
can-focus had in GTK 3.
2021-05-23 11:20:00 -04:00
Matthias Clasen
eb61f0fc63
treeexpander: Use focusable where we mean it
...
This does not fix keyboard activation for tree expanders,
but it is more correct than using can-focus.
2021-05-23 11:20:00 -04:00
Matthias Clasen
105b12f807
togglebutton: Fix mnemonic activation
...
We want to grab the focus when we're focusable, so
look at the focusable property.
2021-05-23 11:20:00 -04:00
Matthias Clasen
882893259d
floxbox: Fix focus navigation
...
We want to find focusable children, so we need to look at
the focusable property, not at can-focus. This is a change
from GTK 3, where can-focus was the correct property to
look at.
2021-05-23 11:20:00 -04:00
Matthias Clasen
052917a67d
label: Fix mnemonic activation
...
The intention of the code is to find a focusable ancestor,
so it needs to look at the focusable property, not at
can-focus. This is a change from GTK 3, where can-focus
was the correct property to look at.
Fixes : #3965
2021-05-23 11:19:40 -04:00
Matthias Clasen
226edf1f91
Merge branch 'matthiasc/for-master' into 'master'
...
demos: Clean up doc comments
See merge request GNOME/gtk!3574
2021-05-23 02:14:01 +00:00
Matthias Clasen
be944053e0
docs: More syntax fixes
...
The syntax for interface links is [iface@...], not
[interface@...].
2021-05-22 21:21:10 -04:00
Matthias Clasen
71aac48042
docs: More syntax fixes
...
[`func@Foo`] is not the right link syntax either.
2021-05-22 21:20:10 -04:00
Matthias Clasen
8bcc6b1d96
docs: Fix up syntax
...
There's no [type_func@...[ syntax, it is all [func@...].
2021-05-22 20:56:14 -04:00
Matthias Clasen
40f292cb13
docs: Sync up debug flag information
2021-05-22 20:46:59 -04:00
Matthias Clasen
601a8de422
treemodel: Cosmetic docs changes
2021-05-22 20:46:59 -04:00
Matthias Clasen
fe564318b6
sortlistmodel: Cosmetic docs changes
2021-05-22 20:46:16 -04:00
Matthias Clasen
09244edc15
expression: Cosmetic docs changes
2021-05-22 17:28:10 -04:00
Matthias Clasen
f5f8f83e3e
textbuffer: Cosmetic docs changes
2021-05-22 17:25:27 -04:00
Matthias Clasen
74a39bbae0
textview: Cosmetic docs changes
2021-05-22 17:25:27 -04:00
Matthias Clasen
3ab34ffdc0
text: Cosmetic docs fixes
2021-05-22 17:25:26 -04:00
Matthias Clasen
13a93489b7
widget: Cosmetic docs changes
2021-05-22 17:25:26 -04:00
Matthias Clasen
b35e02db20
shortcutscontroller: Cosmetic docs changes
2021-05-22 17:25:26 -04:00
Matthias Clasen
6cb4dda5d6
gdk: Cosmetic docs changes
2021-05-22 17:25:26 -04:00
Matthias Clasen
2d12a7d9ee
directorylist: Cosmetic docs changes
2021-05-22 17:25:26 -04:00
Matthias Clasen
9a7e4f4304
eventcontroller: Cosmetic docs changes
2021-05-22 17:25:26 -04:00
Matthias Clasen
876104835e
sorter: Cosmetic docs changes
2021-05-22 17:25:26 -04:00
Matthias Clasen
786e28fec0
filter: Cosmetic docs changes
2021-05-22 17:25:26 -04:00
Matthias Clasen
b617ba1c82
docs: Refer to backend APIs
...
Add links to the backend api docs.
2021-05-22 17:25:26 -04:00
Matthias Clasen
252edbdbc6
docs: Fix a typo
2021-05-22 17:25:26 -04:00
Matthias Clasen
0bba3610c5
docs: Avoid stairstepping
...
If you don't put empty lines between the items in a
definition list, markdown helpfully stairsteps them.
We don't want that!
2021-05-22 17:25:26 -04:00
Matthias Clasen
fc9f580fd3
docs: Update GSK_RENDERER docs
...
This did not mention the opengl and ngl values yet.
2021-05-22 17:25:26 -04:00
Matthias Clasen
91f7b9663f
gtk: Clean up docs syntax
...
Replace leftover gtk-doc syntax (#Type) with backquotes.
2021-05-22 17:25:26 -04:00
Matthias Clasen
2d266d107b
gsk: Clean up docs syntax
...
Replace leftover gtk-doc syntax (#Type) with backquotes.
2021-05-22 17:25:26 -04:00
Matthias Clasen
fff2b3c710
gdk: Clean up docs syntax
...
Replace leftover gtk-doc syntax (#Type) with backquotes.
2021-05-22 17:25:26 -04:00
Benjamin Otte
5af6c37f8c
x11: Be more careful with NVIDIA workaround
...
Check that we are indeed running inside an Xorg server before enabling
the workaround.
XWayland or other nested X servers deadlock when that workaround is
applied.
2021-05-22 01:43:31 +02:00
Matthias Clasen
2d0957b732
docs: Clean up docs syntax
...
Replace leftover gtk-doc syntax (#Type) with backquotes.
2021-05-21 15:34:47 -04:00
Matthias Clasen
0996552708
demos: Clean up doc comments
...
These don't show up anywhere, but might still clean
them up.
2021-05-21 13:53:38 -04:00
Piotr Drąg
620787e56b
Update POTFILES.in
2021-05-21 14:28:58 +02:00
Matthias Clasen
f5bd9f721c
Merge branch 'wip/exalm/check-activate' into 'master'
...
checkbutton: Don't allow to uncheck radios by activating them
See merge request GNOME/gtk!3569
2021-05-21 02:06:58 +00:00
Matthias Clasen
345edb8a89
Merge branch 'doc-tweaks' into 'master'
...
Fix documentation syntax
See merge request GNOME/gtk!3572
2021-05-21 01:18:58 +00:00
Matthias Clasen
4a0d3d7acc
docs: Reduce redundancy
...
Remove a boatload of "or %NULL" from nullable parameters
and return values. gi-docgen generates suitable text from
the annotation that we don't need to duplicate.
This adds a few missing nullable annotations too.
2021-05-20 20:45:06 -04:00
Matthias Clasen
7fe0610b68
introspection: Stop using allow-none
...
allow-none has been deprecated for a long time
already. Instead use optional and nullable everywhere.
2021-05-20 19:17:49 -04:00
Matthias Clasen
8ba16eb4f1
Documentation fixes
...
Mostly fixing up indentation of continuation lines,
and other small cleanups.
2021-05-20 19:17:49 -04:00
Matthias Clasen
ab6a5be0f8
Fix documentation syntax
...
Properties use : in their link syntax.
2021-05-20 19:16:59 -04:00
Matthias Clasen
94b0907534
Merge branch 'wip/exalm/switch-icons-2' into 'master'
...
icons: Fix switch-off icon
See merge request GNOME/gtk!3571
2021-05-20 22:49:29 +00:00
Alexander Mikhaylenko
0017b4b69a
icons: Fix switch-off icon
...
It wasn't converted to paths and so wasn't rendered correctly.
2021-05-20 23:36:30 +05:00
Matthias Clasen
430be6f2a9
Merge branch 'popover-docs' into 'master'
...
popover: Update docs
Closes #3960
See merge request GNOME/gtk!3570
2021-05-20 13:55:47 +00:00
Matthias Clasen
bff7ac4a1d
popover: Update docs
...
Remove mention of show/hide animations, and mention
cascading close instead.
Fixes : #3960
2021-05-20 09:18:47 -04:00
Alexander Mikhaylenko
fb6c6c85bf
checkbutton: Don't allow to uncheck radios by activating them
...
Do the same check as when clicking.
2021-05-20 14:38:33 +05:00
Yuri Chornoivan
894adea2f7
Update Ukrainian translation
2021-05-20 07:29:07 +00:00
Yuri Chornoivan
0e1d6fbbbc
Update Ukrainian translation
2021-05-20 07:27:43 +00:00
Alexander Mikhaylenko
bad01edd2c
checkbutton: Sync the indicator state with the widget
...
Clicking the whole check button toggles it, so make sure the hover and
active states are propagated to the indicator like in GTK3.
2021-05-20 12:17:45 +05:00
Matthias Clasen
e9ca8d689f
Merge branch 'bilelmoussaoui/gdk-return-error-annotation' into 'master'
...
gdk: annotate Content Serialize/Deserialize return_error
See merge request GNOME/gtk!3567
2021-05-20 03:54:15 +00:00
Bilal Elmoussaoui
c5eb2f5d16
gdk: annotate Content Serialize/Deserialize return_error
2021-05-19 18:10:34 +00:00
Benjamin Otte
7db87a8889
Merge branch 'fix-gst-media-file' into 'master'
...
gtkgstmediafile: Remove media-info-updated callback
Closes #3913
See merge request GNOME/gtk!3565
2021-05-19 16:22:35 +00:00
Ivan Molodetskikh
12a9a0faf7
gtkgstmediafile: Remove media-info-updated callback
...
Instead, rely on position-updated which is also called always, and also
a little later than media-info-updated, giving GstPlayer time to figure
out more of the video info. Tested on local and remote mount videos,
images, sound files.
Works around / fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3913 ,
https://gitlab.gnome.org/GNOME/gtk/-/issues/3914 .
2021-05-19 18:55:37 +03:00
Matthias Clasen
fc321d8282
Merge branch 'matthiasc/for-master' into 'master'
...
Actually pass the devel profile to flatpak builds
See merge request GNOME/gtk!3563
2021-05-18 11:42:33 +00:00
Matthias Clasen
7d27c615b7
Actually pass the devel profile to flatpak builds
...
I added that to the manifests, and did not notice that
we do the last build step manually :(
2021-05-18 07:38:18 -04:00
Matthias Clasen
7de266a620
Merge branch 'wip/carlosg/sequence-accepted-in-group' into 'master'
...
gtkgesture: Apply gesture group state after setting up sequence
Closes #3946
See merge request GNOME/gtk!3560
2021-05-18 10:58:19 +00:00
Matthias Clasen
4cbc5ed20a
Merge branch 'fix-gen-demo-conf' into 'master'
...
Fix generating demo_conf.h on builds without GIT in PATH
See merge request GNOME/gtk!3562
2021-05-18 10:31:57 +00:00
Chun-wei Fan
c18a1ac1a1
gen-demo-header.py: Fix running without git
...
The script assumes that the git program is in the PATH which may not be always
the case, so if git was not found, fallback to the former behavior of making
VCS_TAG an empty string if the profile option was not set to 'devel'.
Also fix the call to the script so that we do indeed call GIT on the source GIT
repo so that we can get the right short SHA1 sum.
Re-organize the code a bit in the process, so that things seem cleaner.
2021-05-18 11:25:20 +08:00
Matthias Clasen
ab6e4bfc8d
Merge branch 'wip/carlosg/reset-after-grab' into 'master'
...
Fixes to GTK grab notification
Closes #3942
See merge request GNOME/gtk!3561
2021-05-17 23:35:26 +00:00
Carlos Garnacho
6b7b232114
gtkwindow: Fix "shadowed" checks for GTK grabs
...
We iterate here from the target widget up the toplevel checking
for the previous and new grab, there's however 2 bugs here:
- The check for is_shadowed was different to the check for was_shadowed
- The loop started with the assumption that the widgets did not hold
a grab, just to change it if the grab widget was found. (or maybe
it's the other way around? it's unclear with the differing checks
for past/present state).
Make these checks consistent, and ensure we start with the right
assumption for the past/present grabbing state, and accounting that
new/old grab widgets may or may not be part of the pick stack.
2021-05-18 00:16:55 +02:00
Carlos Garnacho
0a5d21ca9e
gtkwindow: Rename function
...
With gtk_grab_notify_foreach() just taking care of emitting crossing
notifications due to the GTK grab change, rename it to a more apt
gtk_synthesize_grab_crossing().
2021-05-18 00:16:48 +02:00
Carlos Garnacho
f003a4c6cc
gtkwindow: Simplify GTK grab notification
...
The _gtk_widget_grab_notify() function just (maybe) did a) reset
controllers and b) hide toplevels. The second part was a testing
remnant introduced in commit 024d832d94
, not part of the original
fix.
Do the former more concisely, called from the place where we figure
out whether a widget's ability to receive events changed due to
GTK grabs. It's across those changes that we are interested in
resetting the controllers.
With the gestures being reset both ways, GtkWindowHandle (and
probably other) gestures are now able to reset after a GTK grab
takes input away (e.g. GtkMenuButton). This could be seen as
a sudden jump the next time they'd be dragged with the mouse,
as the gesture would "resume" the previous interaction.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3942
2021-05-18 00:16:48 +02:00
Carlos Garnacho
53df32e6cf
gtkgesture: Apply gesture group state after setting up sequence
...
When a new sequence is added to a GtkGesture, its state is looked
in other gestures in the same group, and made to match in this
gesture. This however happened a bit too early, before the
gesture touchpoint was fully set up. As this may result in signal
emission and whatnot, it's a good idea to make it happen with a
fully set up touchpoint.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3946
2021-05-18 00:16:12 +02:00
Matthias Clasen
8670034c86
Merge branch 'ebassi/rev-parse-fallback' into 'master'
...
build: Check CI envvars before rev-parse
See merge request GNOME/gtk!3559
2021-05-17 21:13:04 +00:00
Emmanuele Bassi
c1fbf654a0
build: Check CI envvars before rev-parse
...
The CI pipeline does not do a full clone, so we cannot use `git
rev-parse` to get the short SHA checksum for the current commit.
Of course, since nothing's ever easy, we cannot use vcs_tag() with a
custom command, so we need to generate our out `demo_conf.h` header
straight from a script.
2021-05-17 21:34:13 +01:00
Matthias Clasen
9066078928
Merge branch 'wip/exalm/activatable2' into 'master'
...
theme: Specificity bump for dropdowns
See merge request GNOME/gtk!3558
2021-05-17 20:10:12 +00:00
Alexander Mikhaylenko
4f16e661cf
theme: Specificity bump for dropdowns
...
Fix a fallout from d56711b5d8
2021-05-17 23:26:08 +05:00
Matthias Clasen
45b85767c4
Merge branch 'wip/exalm/activatable' into 'master'
...
listitemwidget: Have .activatable style class if the item is activatable
See merge request GNOME/gtk!3557
2021-05-17 15:56:02 +00:00
Alexander Mikhaylenko
d56711b5d8
listitemwidget: Have .activatable style class if the item is activatable
...
Match GtkListBox, so it's possible to use the same styles for them.
Update GtkListView and GtkGridView docs to reflect that, fix a few gtk-doc
formatting leftovers along the way.
2021-05-17 18:10:35 +05:00
Matthias Clasen
df28a57ae3
Merge branch 'matthiasc/for-master' into 'master'
...
ngl: Add padding between cached glyphs
See merge request GNOME/gtk!3555
2021-05-17 12:12:22 +00:00
Matthias Clasen
04bac8ef2a
testsuite: Run some installed tests exclusively
...
My suspicion is that the clipboard (and some other)
installed test interferes with others, because the
clipboard is a shared resource.
2021-05-17 07:16:42 -04:00
Matthias Clasen
7ad193787e
Merge branch 'wip/exalm/emojichooser' into 'master'
...
emojichooser: Set selection-mode=none on the toolbar flowbox
See merge request GNOME/gtk!3556
2021-05-17 11:10:33 +00:00
Alexander Mikhaylenko
27e662cfd1
emojichooser: Set selection-mode=none on the toolbar flowbox
...
Selection is never used there, avoid unwanted selected states if clicking
outside the buttons.
2021-05-17 14:09:03 +05:00
Pawan Chitrakar
661a572d82
Update Nepali translation
...
(cherry picked from commit 597a624fc5
)
2021-05-16 07:41:56 +00:00
Matthias Clasen
66b4f0cac4
ngl: Reuse texture coordinates
...
When uploading glyphs, reuse the position that
we get from gsk_ngl_texture_library_pack, instead
of recomputing it.
2021-05-15 22:23:14 -04:00
Matthias Clasen
81e0206465
ngl: Be consistent about padding
...
Make gsk_ngl_texture_library_pack always return
the position including the padding. And compute
texture coordinates accurately in all cases (we
were fudging the padding for standalone textures.
2021-05-15 22:21:26 -04:00
Matthias Clasen
cb1babeeba
ngl: Add padding between cached glyphs
...
Without this, adjacent items in the cache sometimes
bleed into the texture for a glyph.
2021-05-15 22:15:05 -04:00
Matthias Clasen
67dc778b8f
Merge branch 'gst-egl-optional' into 'master'
...
meson: Do not enforce GStreamer EGL lib
See merge request GNOME/gtk!3554
2021-05-15 14:21:09 +00:00
Rafał Dzięgiel
bbd4ee2986
meson: Do not enforce GStreamer EGL lib
...
GStreamer EGL headers are handled by GstGL lib.
No need to additionally import them.
2021-05-15 14:03:23 +02:00
Kjartan Maraas
42b2eae532
Update Norwegian Bokmål translation
...
(cherry picked from commit d952fa48e7
)
2021-05-15 07:35:38 +00:00
Matthias Clasen
0902f45d71
Merge branch 'gst-x11-egl' into 'master'
...
gtkgstsink: Support EGL under x11
See merge request GNOME/gtk!3553
2021-05-14 19:57:05 +00:00
Rafał Dzięgiel
c51eb7665e
gtkgstsink: Support EGL under x11
...
Add support for EGL under x11 windowing system to GStreamer sink
2021-05-14 19:29:00 +02:00
Matthias Clasen
1a426d6fff
Merge branch 'ebassi/issue-3948' into 'master'
...
x11: Loosen the match for the NVIDIA driver
Closes #3948
See merge request GNOME/gtk!3549
2021-05-14 10:50:59 +00:00
Matthias Clasen
07b5072c9c
Merge branch 'matthiasc/for-master' into 'master'
...
inspector: Use new get_egl_display apis
See merge request GNOME/gtk!3546
2021-05-14 00:40:05 +00:00
Matthias Clasen
3a0febfe79
Merge branch 'offscreen-fixes' into 'master'
...
Add some more transform tests
See merge request GNOME/gtk!3551
2021-05-14 00:38:52 +00:00
Matthias Clasen
8e7bc8d742
Improve transformed offscreen rendering
...
Preserve the scale for 2D transforms to
avoid a pixellated appearance.
2021-05-13 19:37:16 -04:00
Matthias Clasen
809299f9e4
Add some more transform tests
...
Test that gsk_transform_to_affine works.
2021-05-13 19:37:16 -04:00
Matthias Clasen
c391cf38e2
testzoom: Fix the in-place rotate
2021-05-13 19:37:16 -04:00
Matthias Clasen
8c75e6896e
inspector: Use new get_egl_display apis
...
This makes the code a bit more concise.
Also, get WGL information when we are using it.
2021-05-13 15:25:18 -04:00
Emmanuele Bassi
b3d6928f35
x11: Pair eglInitialize with eglTerminate
...
If we bail out after EGL initialization we want to go back to a stable
state and not leave EGL hanging.
2021-05-13 18:23:50 +01:00
Emmanuele Bassi
3d8ba93f59
x11: Loosen the match for the NVIDIA driver
...
It seems nVidia puts a different string in the GL_VENDOR than the one it
uses for GLX.
2021-05-13 18:22:30 +01:00
Emmanuele Bassi
889bf83020
Merge branch 'ebassi/boost-url' into 'master'
...
Update the URL for the Boost archive
See merge request GNOME/gtk!3548
2021-05-13 11:47:28 +00:00
Emmanuele Bassi
6c63f7b0e2
Update the URL for the Boost archive
...
The old URL seems to have failed, and now it returns 301.
Use the URL from the Boost website.
2021-05-13 11:29:22 +01:00
Matthias Clasen
3872c3a127
Merge branch 'fix-picking-with-transforms' into 'master'
...
Fix picking with transforms
See merge request GNOME/gtk!3547
2021-05-13 10:09:37 +00:00
Matthias Clasen
5be785bff8
Add a transform test
...
This reveals some issues with scale handling.
2021-05-12 21:50:32 -04:00
Matthias Clasen
bf454e948d
Fix picking with transforms
...
When transforms include scales, we weren't picking
children properly. The special-case in gtk_widget_do_pick
only applies to 2D translations.
2021-05-12 20:58:16 -04:00
Emmanuele Bassi
e66ec84c1e
Merge branch 'ebassi/issue-3945' into 'master'
...
docs: Fix indentation of the arguments
Closes #3945
See merge request GNOME/gtk!3544
2021-05-12 20:12:13 +00:00
Matthias Clasen
6537728c7b
Merge branch 'wip/chergert/fix-gi-typo' into 'master'
...
gdk: fix typo in G-I attribute
See merge request GNOME/gtk!3545
2021-05-12 18:43:33 +00:00
Matthias Clasen
95f3f8f3c4
Merge branch 'win32.egl.getter' into 'master'
...
Win32: Add EGLDisplay getter
See merge request GNOME/gtk!3543
2021-05-12 18:42:35 +00:00
Christian Hergert
ae9b4f8940
gdk: fix typo in G-I attribute
2021-05-12 10:53:56 -07:00
Emmanuele Bassi
8ef353a970
docs: Fix indentation of the arguments
...
The indentation of new lines inside documentation blurbs must be smaller
than 4 spaces, otherwise the Markdown parser will consider the line to
be part of a pre-formatted code block.
Fixes : #3945
2021-05-12 17:38:07 +01:00
Chun-wei Fan
6d33e9058c
Win32: Add EGLDisplay getter
...
Like what was done for Wayland and X11, add an API to retrieve the EGLDisplay
if one is being used in place of WGL.
2021-05-12 22:16:56 +08:00
Matthias Clasen
78852b181a
Merge branch 'ebassi/egl-display-get' into 'master'
...
Add backend-specific getter for the EGLDisplay
See merge request GNOME/gtk!3542
2021-05-11 12:42:50 +00:00
Emmanuele Bassi
2588f9cee6
wayland: Add EGLDisplay getter
...
Getting an EGLDisplay object is messy; might as well expose the function
we use internally to save some time, just like we did for the X11
backend.
2021-05-11 12:46:03 +01:00
Emmanuele Bassi
abc2d7e4a9
x11: Add EGLDisplay getter
...
Getting an EGLDisplay object is messy; might as well expose the function
we use internally to save some time.
2021-05-11 12:42:16 +01:00
Emmanuele Bassi
6189e343f3
build: Do not use C arguments with C++
...
Otherwise the C++ compiler will start to complain.
The C++ keyword test does not need additional warnings.
2021-05-11 12:24:34 +01:00
Matthias Clasen
8bfa182ed9
Merge branch 'misc-inspector-things' into 'master'
...
inspector: Show text direction
See merge request GNOME/gtk!3541
2021-05-11 10:51:31 +00:00
Matthias Clasen
ea162ed016
inspector: Avoid a crash with GL variants
...
When configuring the inspector display, preserve
debug flags that affect which GL variant we pick.
Otherwise, we may end up with a GLX context on the
default display, and an EGL context on the inspector
one. This hopelessly confuses libepoxy, and things
don't go well when that happens.
2021-05-10 21:25:08 -04:00
Matthias Clasen
e2aa161590
inspector: Show EGL info for X11 as well
2021-05-10 21:24:50 -04:00
Matthias Clasen
a723baec4b
inspector: Show text direction
...
This is not a property, so show it on the misc tab.
2021-05-10 20:55:43 -04:00
Emmanuele Bassi
6120519e8e
Merge branch 'ebassi/egl-x11' into 'master'
...
Prefer EGL to GLX for the GL support on X11
See merge request GNOME/gtk!3540
2021-05-10 22:51:11 +00:00
Emmanuele Bassi
69856a9aac
x11: Don't update GLX visuals with EGL
...
We're going to get into a messy situation, with both GLX and EGL
initialized.
If we're already using EGL, skip the whole cache.
2021-05-10 21:19:14 +01:00
Matthias Clasen
564d835fba
Merge branch 'broadway-display-scale' into 'master'
...
broadway: Add a setter for display scale
Closes #3934
See merge request GNOME/gtk!3538
2021-05-10 20:11:38 +00:00
Emmanuele Bassi
c35a6725b9
x11: Always fall back to GLX on NVIDIA
...
At least until we can guarantee that EGL-X11 works fine there.
2021-05-10 20:44:35 +01:00
Emmanuele Bassi
a57f79006a
x11: Move the damage fences into the GLX code
...
It's GLX-specific anyway, there's no need to complicate things by having
half the code in the generic path, and half in the GLX one.
2021-05-10 20:44:35 +01:00
Emmanuele Bassi
6600b0b507
x11: Add debug toggle for preferring GLX
...
Mostly as a way to compare the EGL and GLX implementations.
2021-05-10 20:44:35 +01:00
Emmanuele Bassi
9a19e3c741
x11: Add profiler marks for SwapBuffers
2021-05-10 20:44:35 +01:00
Emmanuele Bassi
8924d614c0
x11: Use EGL for GL support
...
This makes the X11 backend similar to the Wayland one, when it comes to
OpenGL.
Fall back to GLX only if EGL support is not available.
2021-05-10 20:44:35 +01:00
Emmanuele Bassi
03f76eccf5
x11: Decouple GLX from GdkX11GLContext
...
If we want to add an EGL implementation for the X11 backend, we are
going to need to move the GLX bits into their own class. The first step
is to declare GdkX11GLContext as an abstract type, and then subclass it
into a GdkX11GLContextGLX type, which includes the whole GLX
implementation.
2021-05-10 20:44:35 +01:00
Matthias Clasen
b13c2e17f1
inspector: Support scale changes on Broadway
2021-05-10 10:55:41 -04:00
Matthias Clasen
7c1c8c53e7
Merge branch 'ci-more-clang' into 'master'
...
ci: Add clang-extra-tools to the image
See merge request GNOME/gtk!3539
2021-05-10 13:26:54 +00:00
Matthias Clasen
497b843e76
ci: Add clang-extra-tools to the image
...
Hurray for bite-size packages! Splitting
this off broke our style check in ci.
2021-05-10 08:52:12 -04:00
Matthias Clasen
7745f67583
broadway: Add a setter for display scale
...
This is useful when using Broadway as a headless
display server.
Fixes : #3934
2021-05-10 07:19:26 -04:00
Matthias Clasen
374225ae6a
Cosmetics
2021-05-09 19:32:48 -04:00
Matthias Clasen
7259be35b0
Merge branch 'file-replace-trap' into 'master'
...
print-editor: Fix saving
See merge request GNOME/gtk!3536
2021-05-09 23:06:49 +00:00
Matthias Clasen
1601e204f4
Merge branch 'wip/exalm/image-button' into 'master'
...
Ensure consistent header bar buttons in the demo and tests
See merge request GNOME/gtk!3537
2021-05-09 23:06:25 +00:00
Alexander Mikhaylenko
43e33b2990
test: Ensure .image-button on header bar buttons
2021-05-09 20:55:26 +05:00
Alexander Mikhaylenko
7ebd9291d9
demo: Ensure .image-button on header bar buttons
2021-05-09 20:53:05 +05:00
Alexander Mikhaylenko
5d59415c2d
test: Use more appropriate back/forward icons
2021-05-09 20:52:48 +05:00
Alexander Mikhaylenko
c5d2d89930
demo: Use more appropriate back/forward icons
2021-05-09 20:35:39 +05:00
Matthias Clasen
0108ffe059
inspector: Fix saving css
...
g_file_replace_contents() does not accept -1
as length, unlike similar apis.
2021-05-09 11:19:43 -04:00
Matthias Clasen
087935f160
print-editor: Fix saving
...
g_file_replace_contents() does not accept -1 as
length, unlike similar apis.
2021-05-09 11:19:43 -04:00
Matthias Clasen
fef9f1187d
Merge branch 'matthiasc/for-master' into 'master'
...
fontbutton: Quote font family names
See merge request GNOME/gtk!3534
2021-05-09 14:43:03 +00:00
Matthias Clasen
83c9a24855
Merge branch 'wip/exalm/actionbar' into 'master'
...
GtkActionBar spacing fixes
See merge request GNOME/gtk!3535
2021-05-09 14:40:19 +00:00
Alexander Mikhaylenko
435a8f6337
theme: Fix GtkActionBar spacing
2021-05-09 17:01:36 +05:00
Alexander Mikhaylenko
2c8e4573f2
actionbar: Fix the css node docs
2021-05-09 16:55:48 +05:00
Alexander Mikhaylenko
b45721373a
action-bar: Add start and end style classes to GtkActionBar boxes
...
Make it possible to add spacing to them from the theme without affecting
the center child should it happen to be a box.
2021-05-09 16:54:59 +05:00
Matthias Clasen
e0ebf4e401
fontbutton: Quote font family names
...
Otherwise, spaces in family names will trip up
the css parser.
2021-05-08 20:54:50 -04:00
Matthias Clasen
dc878f24d2
Merge branch 'emoji-full-locale' into 'master'
...
emoji: Try to load emoji data using both language and territory
See merge request GNOME/gtk!3531
2021-05-08 02:07:18 +00:00
Matthias Clasen
be1f9b2cb0
Merge branch 'wip/carlosg/map-emulated-moveresize-window' into 'master'
...
gdk/x11: Ensure to map the non-ewmh moveresize emulation window before use
See merge request GNOME/gtk!3529
2021-05-07 14:55:16 +00:00
Marco Trevisan (Treviño)
0769dfbd32
emoji: Try to load emoji data using both language and territory
...
When loading the emoji data we just try to get the data for a language
while there may be territory specializations and emojibase provides
them.
So, split the loading function and try to load the data for the fully
defined language string (i.e. `it-ch`) before loading the generic one
for the language (i.e. `it`) and eventually falling back to the generic
english.
2021-05-07 16:10:29 +02:00
Carlos Garnacho
081e127377
gdk/x11: Ensure to map the non-ewmh moveresize emulation window before use
...
Otherwise, we don't deem it as able to be grabbed, which we intend to do
immediately after.
2021-05-07 15:51:52 +02:00
Matthias Clasen
17a799aeb2
Merge branch 'matthiasc/for-master' into 'master'
...
Add some calendar tests
See merge request GNOME/gtk!3528
2021-05-07 12:57:55 +00:00
Matthias Clasen
a3f5283018
Add some calendar tests
...
Check that the getters and setters work as documented.
This tests the fix in 1f8985e476
.
2021-05-07 07:52:11 -04:00
Matthias Clasen
633d783f0c
Merge branch 'carlosgc/calendar-day' into 'master'
...
calendar: value of day property is shifted by 1
See merge request GNOME/gtk!3524
2021-05-07 11:42:59 +00:00
Matthias Clasen
451a5fb6d4
Merge branch 'fix-3918' into 'master'
...
demos: Mark non-static signal handler symbols for export
Closes #3918
See merge request GNOME/gtk!3523
2021-05-07 11:08:57 +00:00
Matthias Clasen
3ad7d304bd
Merge branch 'update-emoji-data' into 'master'
...
emoji: Update data to CLRD v39
See merge request GNOME/gtk!3520
2021-05-07 11:05:46 +00:00
Carlos Garcia Campos
7b2b8b86e1
calendar: do not allow to set 0 as day
...
We no longer unselect the current day when 0 is set, so update the
documentation and the property definition.
2021-05-07 12:13:49 +02:00
Carlos Garcia Campos
1f8985e476
calendar: value of day property is shifted by 1
...
The day is a number between 1 and 31 and that's what we get from
GDateTime.
2021-05-07 11:10:36 +02:00
Chun-wei Fan
efb875daef
demos: Mark non-static signal handler symbols for export
...
The symbols in the .ui files for the signal handlers and functions must be
exported so that the system can pick them up during execution.
Fixes #3918 .
2021-05-07 10:38:02 +08:00
Matthias Clasen
59cc3a9f86
Merge branch 'hidden-mnemonics-fix' into 'master'
...
label: Make hidden mnemonics work again
See merge request GNOME/gtk!3518
2021-05-07 00:34:33 +00:00
Matthias Clasen
febd143ac8
Merge branch 'emoji-data-prefix-fix' into 'master'
...
emoji: Use a portable and configuration-dependent path to load the data
See merge request GNOME/gtk!3522
2021-05-06 15:33:15 +00:00
Matthias Clasen
e00785e958
Merge branch 'macos' into 'master'
...
Fix building both X11 and Quartz backends on macOS
See merge request GNOME/gtk!3508
2021-05-06 15:26:49 +00:00
Marco Trevisan (Treviño)
4a4525a65d
emoji: remove duplicated include
2021-05-06 16:00:06 +02:00
Marco Trevisan (Treviño)
c98dd1afb9
emoji: Use a portable and configuration-dependent path to load the data
...
Load the emojis data in all the platforms, respecting the configured
GTK_DATA_PREFIX
2021-05-06 16:00:06 +02:00
Dan Cîrnaț
12d591178e
Fix compilation of c++ test: cpp_args
...
The correct meson argument for c++ is cpp_args.
Remove unnecessary(?) "-Idummy-headers" - breaks build
2021-05-06 10:38:41 +02:00
Dan Cîrnaț
bd7b29a6c4
Only compile gtkmountoperation-stub if the X11 backend is not enabled
2021-05-06 10:38:41 +02:00
Dan Cîrnaț
13b94dab10
Conditional check for gdesktopappinfo header
...
GDesktopAppInfo is not available on macOS and needs to be disabled
2021-05-06 10:38:41 +02:00
Marco Trevisan (Treviño)
ba3cbac21a
emoji: Update data to CLRD v39
...
This is based on version 6.2.0 of emojibase, containing CLRD 39
http://cldr.unicode.org/index/downloads/cldr-39
https://github.com/milesj/emojibase/blob/b3c9a78/packages/data/CHANGELOG.md
2021-05-06 05:08:37 +02:00
Matthias Clasen
d94c386320
label: Make hidden mnemonics work again
...
The change in 875a92b95f
made labels strip
out underlines earlier, but overlooked that this made
mnemonics not work before the timeout to show them
has passed. That was unintentional. Make mnemonics
work regardless of their visibility, again.
2021-05-05 22:55:52 -04:00
Matthias Clasen
4e2a263c1f
Merge branch 'introspection-test' into 'master'
...
Add an introspection api test
See merge request GNOME/gtk!3514
2021-05-06 00:52:06 +00:00
Matthias Clasen
6a24e0c7c3
Add an introspection api test
...
Every beginning is small... just check one constant for now.
2021-05-05 19:18:32 -04:00
Matthias Clasen
c8eeb46aa5
Merge branch 'update-ci-to-f34' into 'master'
...
WIP ci: Update the image to Fedora 34
See merge request GNOME/gtk!3516
2021-05-05 23:17:07 +00:00
Matthias Clasen
d143f76568
Merge branch 'msvc-ci' into 'master'
...
ci: Add MSVC build
See merge request GNOME/gtk!3486
2021-05-05 23:16:39 +00:00
Matthias Clasen
930ff499ee
Confine -mf16c to a single source file
...
We can't use this flag for any code that may get run
outside the __builtin_cpu_supports() check, and meson
doesn't allow per-file cflags. So we have to split this
code off into its own static library.
2021-05-05 18:58:23 -04:00
Xavier Claessens
f4dc24c3da
Meson: gdk-pixbuf jpeg/png options changed to feature
2021-05-05 16:40:57 -04:00
Matthias Clasen
399fb76652
ci: Add pygobject to the images
...
This will let us add introspection tests in the future.
2021-05-05 16:31:03 -04:00
Matthias Clasen
de056a3319
ci: Show OS release for our containers
2021-05-05 16:22:32 -04:00
Matthias Clasen
bafa23fa2c
Add debug spew to gdk tests
2021-05-05 15:41:46 -04:00
Matthias Clasen
ab725b4ba9
Merge branch 'wl-phys-transform' into 'master'
...
gdk/wayland: Take transform into account when setting physical size
See merge request GNOME/gtk!3515
2021-05-05 15:23:26 +00:00
Xavier Claessens
d8f44c06e8
ci: Add MSVC build
...
This script is copied from glib CI.
2021-05-05 09:16:36 -04:00
Guido Günther
e40c869d0d
gdk/wayland: Take transform into account when setting physical size
...
Width and height of a GdkMonitor are derived via wl_output which
talks about physical dimensions of a device and compositors usually
implement this as the untransformed values (e.g. weston, wlroots).
Since the GTK client has no way to figure out if a monitor was rotated,
transform the physical dimensions according to the applied wayland
transform to have the physical dimensions match the logical ones.
Mutter flips the physical dimensions itself but doesn't announce the
transform so this shouldn't break anything there.
2021-05-05 14:55:07 +02:00
Matthias Clasen
3591da517a
Disable another font-challenged reftest
2021-05-05 08:17:26 -04:00
Matthias Clasen
014fb41448
Help the compiler out
...
gcc says: error: iteration 2147483649 invokes undefined behavior
[-Werror=aggressive-loop-optimizations]
which of course, never happens because ncols is always >= 2.
Add some assertions to tell the compiler.
2021-05-05 08:17:26 -04:00
Matthias Clasen
24072f26ca
ci: Update the image to Fedora 34
...
This is in preparation to using mutter --headless
for tests.
2021-05-05 08:17:26 -04:00
Matthias Clasen
65017a0031
Merge branch 'bilelmoussaoui/trick-gir-list-position' into 'master'
...
gtk: trick g-ir scanner to add INVALID_LIST_POSITION
See merge request GNOME/gtk!3513
2021-05-05 00:04:16 +00:00
Bilal Elmoussaoui
dc5aab62c8
gtk: trick g-ir scanner to add INVALID_LIST_POSITION
...
without it, the define doesn't get picked in the introspection data
2021-05-05 00:45:21 +02:00
Matthias Clasen
a3cccbeb53
Merge branch 'wip/exalm/text-handles' into 'master'
...
texthandle: Add a contents css node
Closes #3475
See merge request GNOME/gtk!3511
2021-05-04 21:40:48 +00:00
Matthias Clasen
cee6525213
Merge branch 'fix-reftest' into 'master'
...
Fix the icon-effect-missing reftest
See merge request GNOME/gtk!3512
2021-05-04 21:03:30 +00:00
Matthias Clasen
4f81dc1eaf
Fix the icon-effect-missing reftest
...
This was comparing the included image-missing icon
with the one in the current icontheme on the test
system. Works fine as long as we don't change
the icons (which we just did). To avoid this, set
the icontheme to hicolor for this test, which does
not have the image-missing icon, so we end up getting
the builtin icon for both ui files.
2021-05-04 16:21:37 -04:00
Alexander Mikhaylenko
0e58bfe90e
texthandle: Add a contents css node
...
Allow to theme it including using css transforms to avoid having assets.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3475
2021-05-04 23:53:05 +05:00
Matthias Clasen
e3e0342db7
Merge branch 'wip/exalm/switch-icons' into 'master'
...
icons: Fix switch icon names
Closes #3920
See merge request GNOME/gtk!3509
2021-05-04 16:18:29 +00:00
Matthias Clasen
b1f12a0535
Merge branch 'wip/exalm/icons' into 'master'
...
Update icons from adwaita-icon-theme
Closes #2656
See merge request GNOME/gtk!3510
2021-05-04 16:18:00 +00:00
Alexander Mikhaylenko
60f4b07196
icons: Update from adwaita-icon-theme
...
Also add the missing edit-clear RTL variant.
2021-05-04 19:12:04 +05:00
Alexander Mikhaylenko
4c60dac9cb
icons: Remove media-playback-start-symbolic-rtl
...
See https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/101
2021-05-04 19:12:04 +05:00
Matthias Clasen
8d14bd3339
Merge branch 'wip/exalm/css-error' into 'master'
...
cssselector: Fix max_selector usage
Closes #3100
See merge request GNOME/gtk!3507
2021-05-04 13:17:53 +00:00
Alexander Mikhaylenko
48d95d2d7a
icons: Fix switch icon names
...
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3920
2021-05-04 17:49:07 +05:00
Matthias Clasen
670a2be782
Merge branch 'test.msvc' into 'master'
...
clipboard-client.c: Include necessary headers for Windows
See merge request GNOME/gtk!3505
2021-05-04 11:53:13 +00:00
Alexander Mikhaylenko
f3633d46ca
cssselector: Fix max_selector usage
...
Reverts 2ae8ace784
other than code style
fixes.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3100
2021-05-04 12:34:29 +05:00
Chun-wei Fan
e56754d27c
clipboard-client.c: Include necessary headers for Windows
...
We need to include io.h and process.h for close() and exit(), as unistd.h may
not be universally available.
2021-05-04 12:12:50 +08:00
Matthias Clasen
40ebed3a03
4.3.0
2021-05-03 20:31:18 -04:00
Matthias Clasen
14ac4903b6
Fix dist script for theme reorg
2021-05-03 20:31:18 -04:00
Matthias Clasen
da613c504b
Merge branch 'wip/exalm/textview-selection' into 'master'
...
textview: Selection rendering fixes
See merge request GNOME/gtk!3503
2021-05-03 23:55:46 +00:00
Matthias Clasen
7ac3507be2
Merge branch 'gnome-todo-dnd-crash' into 'master'
...
dragsource: Keep the source alive long enough
See merge request GNOME/gtk!3504
2021-05-03 21:35:55 +00:00
Alexander Mikhaylenko
316c783fce
label: Update selection node and redraw on state changes
...
Mirror GtkText and GtkTextView.
2021-05-04 02:29:10 +05:00
Matthias Clasen
9e952bc7ff
dragsource: Keep the source alive long enough
...
When a drop causes the event controller to be finalized
(directly or indirectly), we end up segfaulting while
trying to wrap up the drag operation. So, keep a reference
on the GtkDragSource from when the drag begins to when
it is done.
This fixes a crash in gnome-todo when dragging tasks.
2021-05-03 17:00:17 -04:00
Alexander Mikhaylenko
e4832a9e94
text: Queue redraw on state changes
...
Mirror GtkTextView.
2021-05-04 01:20:53 +05:00
Alexander Mikhaylenko
70ee86c951
textlayout: Clip selection bounds to the line extents
...
The rest of the line will be painted separately.
2021-05-04 01:08:19 +05:00
Matthias Clasen
ed97339ef1
NEWS: Updates
2021-05-03 15:38:11 -04:00
Matthias Clasen
b012a5c67e
Merge branch 'static-analysis-fixes' into 'master'
...
Static analyis fixes
See merge request GNOME/gtk!3501
2021-05-03 19:21:42 +00:00
Matthias Clasen
642f32e14d
Merge branch 'ebassi/for-master' into 'master'
...
Install documentation in the appropriate place
See merge request GNOME/gtk!3408
2021-05-03 19:21:18 +00:00
Matthias Clasen
7b735b88b4
Merge branch 'wip/carlosg/xdg-activation' into 'master'
...
gdk/wayland: Support the xdg-activation wayland protocol
See merge request GNOME/gtk!3502
2021-05-03 19:20:18 +00:00
Alexander Mikhaylenko
167134e1a8
textlayout: Support fully transparent selection text
...
Pango treats 0 alpha value as a unset alpha, so we have to special case it.
2021-05-04 00:16:05 +05:00
Alexander Mikhaylenko
0fa4b7a249
textview: Invalidate selection when its style changes
2021-05-04 00:16:05 +05:00
Alexander Mikhaylenko
f413d5ef22
textlayout: Only special case selection rendering for opaque colors
...
If the selection is partially transparent, it may still be desirable to
see the colors from tags underneath.
2021-05-04 00:16:05 +05:00
Carlos Garnacho
be4216e051
gdk/wayland: Support the xdg-activation wayland protocol
...
This protocol implements the IPC necessary to focus application
windows across launcher/launchee. Add support for it.
2021-05-03 17:20:50 +02:00
Matthias Clasen
fa10264759
updateiconcache: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
5fbfe5203c
buildertool: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
f472cb53ae
printbackendlpr: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
a49ff5a1c4
textbtree: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
faf56a8abe
stack: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
e510538f37
printoperation: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
b2bf48c3f0
listbase: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
cf0330d601
filterlistmodel: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
2f51f5affe
emojichooser: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
a69ae36a99
fnmatch: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
6863528df1
a11y: Static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
e2722f03ac
x11: A few static analysis fixes
2021-05-03 07:44:38 -04:00
Matthias Clasen
1be4684441
gdktoplevelsize: Comment out some unused code
...
This is not currently useful, and clang complains.
2021-05-03 07:44:38 -04:00
Matthias Clasen
4a96e790b1
Merge branch 'inspector-layouts' into 'master'
...
Various small inspector improvements
See merge request GNOME/gtk!3500
2021-05-03 01:40:46 +00:00
Matthias Clasen
f9d6134247
inspector: Improve monitor information display
...
Avoid a nested listbox, show the connector,
don't show information we don't have. Also,
disconnect all signal handlers from the display
when the inspector is going away.
2021-05-02 21:02:09 -04:00
Matthias Clasen
dfecc8fe02
inspector: Show keyboard layouts
2021-05-02 21:02:09 -04:00
Matthias Clasen
2b0c474117
Add gdk_wayland_device_get_xkb_keymap
...
This can be useful to get more detailed information
about keyboard configuration.
2021-05-02 21:02:09 -04:00
Matthias Clasen
0f74798a82
Add 4.4 version macros
2021-05-02 21:02:09 -04:00
Matthias Clasen
ead06fdb35
Bump version to 4.3.0
...
We are going to add new API.
Fix up affected tests.
2021-05-02 21:01:56 -04:00
Matthias Clasen
687e589950
Merge branch 'shifted-mnemonics' into 'master'
...
shortcuts: Ignore consumed modifiers for mnemonics
Closes #3912
See merge request GNOME/gtk!3499
2021-05-02 23:51:41 +00:00
Matthias Clasen
945b32ca1b
Merge branch 'mesa.win32.fixes' into 'master'
...
gdkglcontext-win32.c: Fix running with Mesa drivers
See merge request GNOME/gtk!3483
2021-05-02 22:42:35 +00:00
Matthias Clasen
0768cfb7df
shortcuts: Ignore consumed modifiers for mnemonics
...
This is necessary to make mnemonics like Alt-1 work in
layouts where numeric keys are shifted, like AZERTY.
Fixes : #3912
2021-05-02 18:33:44 -04:00
Matthias Clasen
b5e245762d
Merge branch 'more-content-serializer-tests' into 'master'
...
Add a test for custom serializers
See merge request GNOME/gtk!3497
2021-05-02 14:00:51 +00:00
Matthias Clasen
4c6c0b9099
Add a test for custom serializers
2021-05-02 09:17:20 -04:00
Matthias Clasen
23af39b5b4
Merge branch 'matthiasc/for-master' into 'master'
...
Add tests for content serialization
See merge request GNOME/gtk!3496
2021-05-02 04:30:19 +00:00
Matthias Clasen
a5cab71c9b
Add tests for content serialization
...
Test that roundtripping various types of content
through a stream of a given mimetype works as
expected.
2021-05-02 00:01:57 -04:00
Matthias Clasen
d4f43f1a7c
Merge branch 'matthiasc/for-master' into 'master'
...
contentdeserializer: Fix an oversight
See merge request GNOME/gtk!3495
2021-05-02 03:09:41 +00:00
Matthias Clasen
7ab8109ef8
contentdeserializer: Fix an oversight
...
The argument passed with string_deserializer must be
a charset name. Passing the mimetype there does not
make sense.
2021-05-01 22:44:41 -04:00
Matthias Clasen
0f49a5068a
Merge branch 'fix-gst-type' into 'master'
...
gtkgstmediafile: Fix callback argument type
See merge request GNOME/gtk!3494
2021-05-01 16:06:26 +00:00
Matthias Clasen
a6e0b6e5ce
Merge branch 'wip/baedert/for-master' into 'master'
...
clipboard tests: Add noreturn annotations where possible
See merge request GNOME/gtk!3493
2021-05-01 15:59:30 +00:00
Matthias Clasen
bf563e0926
Merge branch 'matthiasc/for-master' into 'master'
...
wayland: Rewrite shm format debug spew
See merge request GNOME/gtk!3492
2021-05-01 15:59:21 +00:00
Ivan Molodetskikh
03ca7081df
gtkgstmediafile: Fix callback argument type
2021-05-01 18:17:40 +03:00
Matthias Clasen
97afffba4e
wayland: Rewrite shm format debug spew
...
Rewrite this in a way that doesn't depend on kernel
header defines at the time the wayland scanner was run.
This was causing the build to break on Centos 8, where
a bunch of fourcc formats are missing.
2021-05-01 11:17:28 -04:00
Timm Bäder
6b6246f7b4
clipboard tests: Add noreturn annotations where possible
...
Clang complains when they are missing.
2021-05-01 17:14:23 +02:00
Matthias Clasen
f1e006c88c
Merge branch 'matthiasc/for-master' into 'master'
...
Check for root being a GtkWindow in a few places
See merge request GNOME/gtk!3491
2021-04-30 19:29:15 +00:00
Matthias Clasen
32280090fe
Check for root being a GtkWindow in a few places
...
These things were showing up as crashes during DND,
when the root is a GtkDragIcon. I'm sure there's more.
2021-04-30 13:45:39 -04:00
Matthias Clasen
cdd8f7cd53
Merge branch 'bilelmoussaoui/gdk-content-formats-annotations' into 'master'
...
gdk: add length annotation to gdk_content_formats_get_mime_types
See merge request GNOME/gtk!3488
2021-04-30 16:48:04 +00:00
Matthias Clasen
d69ac108d4
Merge branch 'clipboard-test' into 'master'
...
Add more clipboard tests
See merge request GNOME/gtk!3478
2021-04-30 15:25:50 +00:00
Matthias Clasen
c1b614772c
Install the clipboard-client binary
...
It is needed for the installed test.
2021-04-30 09:59:58 -04:00
Bilal Elmoussaoui
ec38e53249
gdk: add zero-terminated annotation to content_formats_get_gtypes
2021-04-30 15:43:33 +02:00
Bilal Elmoussaoui
e473e7a83a
gdk: fix content_formats_get_mime_types annotation
2021-04-30 15:43:17 +02:00
Matthias Clasen
5636384449
Skip clipboard tests when they don't work
...
On headless weston, we have no seat, so focusing
the window won't work, and thus claiming the clipboard
won't either. Skip the tests in that case.
2021-04-30 09:17:39 -04:00
Matthias Clasen
f72ca060b5
Run gdk tests with an unset D-Bus address
...
If the session bus address is unset, GLib will
helpfully try to autolaunch a bus, which will
fail and timeout. If we set an empty address,
it gives up early.
2021-04-30 08:10:48 -04:00
Matthias Clasen
6482954c6e
Fix the clipboard test under X11
...
We don't have a signal handler to worry about here.
2021-04-30 08:02:35 -04:00
Matthias Clasen
e1a0e4bfbe
Make clipboard tests run installed
...
Use dedicated data files, and install them.
As usual, to run the test binary by hand, you
will need to set G_TEST_SRCDIR.
2021-04-30 07:47:19 -04:00
Pawan Chitrakar
ae3ae428a0
Update Nepali translation
...
(cherry picked from commit 24e924720d
)
2021-04-30 10:52:21 +00:00
Matthias Clasen
be42644091
Add more clipboard tests
...
This tests the simple cases of copying text,
files, colors or images between processes.
2021-04-30 06:48:52 -04:00
Chun-wei Fan
66e7f3b404
gdkglcontext-win32.c: Fix running with Mesa drivers
...
Some GL drivers such as Mesa-D3D12 do not allow one to call SetPixelFormat() on
a given HDC if one pixel format has been already set for it, so first check the
HDC with GetPixelFormat() to see whether a pixel format has already been set
with the HDC, and only attempt to acquire the pixel format if one has not been
set.
This will fix running with GL/NGL on Windows using the Mesa drivers.
2021-04-29 12:12:01 +08:00
Matthias Clasen
604d171d56
Merge branch 'bookmark-fix' into 'master'
...
gtkplacessidebar.c: add bookmark null checking
See merge request GNOME/gtk!3479
2021-04-28 16:09:32 +00:00
Geyslan G. Bem
65575fe0d0
gtkplacessidebar.c: fix coding style
...
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com >
2021-04-28 08:42:59 -03:00
Emmanuele Bassi
ac5f0ba341
Merge branch 'ebassi/issue-3905' into 'master'
...
docs: Add missing extra files for gdk4 sub-references
Closes #3905
See merge request GNOME/gtk!3481
2021-04-28 09:50:55 +00:00
Matthias Clasen
e637ed739f
Merge branch 'memfd_create' into 'master'
...
gdk/wayland/cursor/os-compatibility: fix build when memfd_create is not available
See merge request GNOME/gtk!3480
2021-04-28 00:50:42 +00:00
Emmanuele Bassi
29382360ed
docs: Add missing extra files for gdk4 sub-references
...
The Wayland and X11 references need the gtk-logo.svg and the urlmap.js
extra files.
Fixes : #3905
2021-04-28 01:44:47 +01:00
David Lechner
2a610267eb
gdk/wayland/cursor/os-compatibility: fix build when memfd_create is not available
...
When building for homebrew/linuxbrew on Ubuntu 16.04, memfd_create() is
not available and causes the build to fail.
This adds a proper check for the function.
2021-04-27 11:46:39 -05:00
Geyslan G. Bem
1635998ac3
gtkplacessidebar.c: add bookmark null checking
...
This fixes nautilus crash and perhaps other callers issues.
Nautilus (and sometimes glib) crashes with malformed URI inside of the
bookmarks file .config/gtk-3.0/bookmarks when it has no LABEL.
This is result from the closed glib MR #2065 analysis and agreement.
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2065#note_1091979
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com >
2021-04-27 11:58:31 -03:00
Matthias Clasen
82f8fc3bee
Merge branch 'fix-panel-monitor' into 'master'
...
x11: Try harder to find the right monitor
Closes #3900
See merge request GNOME/gtk!3477
2021-04-27 03:48:13 +00:00
Matthias Clasen
f37662c655
x11: Try harder to find the right monitor
...
If we deal with a panel, we end up with no monitor,
and crash, which isn't great and isn't necessary.
Fixes : #3900
2021-04-26 23:20:10 -04:00
Benjamin Otte
1a12ea6e5a
Merge branch 'wip/otte/for-master' into 'master'
...
clipboard: Make sure G_TYPE_STRING is nul-terminated
Closes #3899
See merge request GNOME/gtk!3476
2021-04-26 21:15:32 +00:00
Benjamin Otte
1be899459c
clipboard: Fix reading of files
...
Make sure writing a terminating null byte actually works and we don't
just ignore the error message.
2021-04-26 21:32:57 +02:00
Benjamin Otte
f34e3c573b
clipboard: Make sure G_TYPE_STRING is nul-terminated
...
When reading text, we need to check we terminate the G_TYPE_STRING
string with a null byte, because the clipboard does not guarantee one.
So just append a \0 to the stream.
Fixes #3899
2021-04-26 21:32:57 +02:00
Matthias Clasen
b23529d940
Merge branch 'matthiasc/for-master' into 'master'
...
wayland: Print all layouts in debug spew
See merge request GNOME/gtk!3475
2021-04-26 11:59:01 +00:00
Matthias Clasen
2c34abed20
wayland: Print all layouts in debug spew
2021-04-26 00:16:41 -04:00
Pawan Chitrakar
b3b63a2c8f
Update Nepali translation
...
(cherry picked from commit 193747fadf
)
2021-04-26 01:10:45 +00:00
Jordi Mas
4a1a9b1f44
Update Catalan translation
2021-04-25 20:08:19 +02:00
Matthias Clasen
215d4cbfe5
Merge branch 'fix-x11-shadows' into 'master'
...
x11: Fix shadows
Closes #3896
See merge request GNOME/gtk!3473
2021-04-25 11:43:23 +00:00
Matthias Clasen
8cd8aa2cb3
Merge branch 'matthiasc/for-master' into 'master'
...
Mention nightly flatpaks in the README
See merge request GNOME/gtk!3474
2021-04-24 21:27:38 +00:00
Matthias Clasen
b3b9dd493e
Apply 4 suggestion(s) to 1 file(s)
2021-04-24 17:47:43 +00:00
Matthias Clasen
8909ad1859
Mention nightly flatpaks in the README
2021-04-24 11:42:21 -04:00
Matthias Clasen
aa569acaa1
window: Don't let solid-csd linger
...
Just from reading the code, it seems that we
should unset .csd and .solid-csd at the same
time, since the are mutually exclusive and
we unset them here so realize() can set one
of them again.
2021-04-24 11:29:19 -04:00
Matthias Clasen
1c1c030b8e
Simplify shadow conditions
...
The code in gtkwindow.c for dealing with the various
combinations of client-side decorations and client-side
shadows is entirely too complicated.
This commit does not really clean it up, but simplifies
one of the shadow conditions far enough to make some
sense.
With this change, I get the expected decorations in
all the cases I can easily reproduce locally.
2021-04-24 11:07:20 -04:00
Matthias Clasen
628d5406d7
x11: Fix shadows
...
Commit a2cd21cab6
changed a condition and inadvertedly
broke client-side shadows on X11. Change this back.
Fixes : #3896
2021-04-24 09:19:18 -04:00
Emmanuele Bassi
5d563fcde6
Merge branch 'a11y-properties' into 'master'
...
a11y: Don't sent redundant property changes
See merge request GNOME/gtk!3472
2021-04-23 12:04:47 +00:00
Matthias Clasen
b2f3a3220e
a11y: Don't sent redundant property changes
...
We were sending a property changed event for every set
property whenever we were sending any updates.
2021-04-23 07:34:00 -04:00
Matthias Clasen
4e66e782ea
Merge branch 'synthetic-motion-grab' into 'master'
...
gdk: Avoid synthetic motion confusion
Closes #3439
See merge request GNOME/gtk!3471
2021-04-23 03:11:36 +00:00
Matthias Clasen
d225f14657
gdk: Avoid synthetic motion confusion
...
Don't emit a synthetic motion event on a surface
that is grab-shadowed by a popup. This has been
known to confuse GTK, at times.
Fixes : #3439
2021-04-22 21:09:54 -04:00
Matthias Clasen
13f9ca60d5
Merge branch 'gtk4-listbox-selection' into 'master'
...
Allow repeated selection extension on gtklistbox
Closes #3887
See merge request GNOME/gtk!3461
2021-04-22 23:29:45 +00:00
Emmanuele Bassi
8789e78796
a11y: Update the level property for tree expanders
...
We already have the depth of a tree expander in order to compute the
indentation.
Fixes : #3892
2021-04-22 14:40:35 +01:00
Matthias Clasen
be927d9ce6
Merge branch 'resize-borders' into 'master'
...
window: Fix up resize borders
Closes #3856
See merge request GNOME/gtk!3467
2021-04-22 11:13:20 +00:00
Matthias Clasen
dcb5a74275
Merge branch 'a11y-debug' into 'master'
...
Some a11y improvements
See merge request GNOME/gtk!3455
2021-04-22 11:04:30 +00:00
Matthias Clasen
8f70f1449d
Merge branch 'gtk4-compose-modifiers' into 'master'
...
imcontextsimple: Ignore more modifiers in compose
See merge request GNOME/gtk!3468
2021-04-22 10:58:24 +00:00
Matthias Clasen
b25bc36d33
Merge branch 'wip/muktupavels/solid-csd' into 'master'
...
theme: fix solid-csd style
See merge request GNOME/gtk!3460
2021-04-22 10:48:22 +00:00
Matthias Clasen
da4e2a2976
theme: Make solid borders look better
...
As pointed out by Alberts Muktupāvels, without this,
we are missing the inner edge of the frame.
2021-04-22 06:45:28 -04:00
Matthias Clasen
f8dcda80cf
theme: Fix solid-csd borders
...
The selectors did not apply anymore.
Based on a patch by Alberts Muktupāvels.
2021-04-22 06:45:28 -04:00
Matthias Clasen
01d81ffc17
window: Make resize border size independent
...
Deriving the resize border size from the shadows
carries the risk that we might end up with uneven
resize borders (or none at all, on some sides).
So, justs enforce that we have a big enough shadow
width on all sides.
2021-04-22 06:45:28 -04:00
Ulli Kehrle
c78ec37d83
imcontextsimple: Ignore more modifiers in compose
...
Previously it was impossible to compose characters on higher levels of
some keyboard layouts as pressing the level selection key would just
exit compose mode.
Examples for affected keyboard layouts include the Latvian
apostrophe-variant "lv(apostrophe)" (latched third level), the extended
German keyboard layout "de(e1)" (latched fifth level) as well as the
multilingual Canadian keyboard layout "ca(multix)" and the German
neo-layout "de(neo)" and its descendants (shifted fifth level).
To reproduce, set a compose key and select the Latvian apostrophe layout.
Notice that you now can input [ by pressing first the ' and then the 8-key.
Then pressing <compose>'8'8 should produce ⟦, but prior to this patch it
did not.
2021-04-22 03:56:30 +02:00
Matthias Clasen
a2cd21cab6
window: Tweak resize borders
...
Make windows resizable in the padding and border
area of the css box as well. This naturally makes
solid-csd borders work again.
2021-04-21 21:09:09 -04:00
Matthias Clasen
760e60fa04
window: Fix up resize borders
...
The invisible resize borders have been wider than they
should, for a while. Go back to a size close to what
we have in GTK3.
To summarize: resize borders will be at most 12 pixels
on each size, but never wider than the windows shadow.
The resize corners have 'legs' of 24 pixels where you
still get a corner resize cursor.
Fixes : #3856
2021-04-21 20:09:38 -04:00
John Renner
81914f466d
Allow repeated selection extension on gktlistbox
2021-04-21 14:18:29 -07:00
Matthias Clasen
ebd8338795
Merge branch 'im-cursor-pos' into 'master'
...
imcontext: Fix cursor positions
Closes #3885
See merge request GNOME/gtk!3464
2021-04-21 17:43:12 +00:00
Matthias Clasen
11d637f869
Merge branch 'wip/oholy/placesview-default-location-regression' into 'master'
...
placesview: Open location even if mount was not found
Closes nautilus#1811
See merge request GNOME/gtk!3435
2021-04-21 12:22:17 +00:00
Emmanuele Bassi
b24fedda49
a11y: Update the labelled-by relation of GtkTreeExpander
...
Whenever we change the :child property, we need to update the
labelled-by relation.
2021-04-21 11:43:16 +01:00
Emmanuele Bassi
57cc2c4918
a11y: Set state on the GtkTreeExpander widget
...
Instead of setting it on its internal child.
2021-04-21 11:43:11 +01:00
Matthias Clasen
15483ac9df
imcontext: Fix cursor positions
...
gtk_im_context_get_preedit_string is documented to
return the cursor position as a character offset,
not a byte count. So return that.
Fixed : #3885
2021-04-21 06:28:52 -04:00
Matthias Clasen
142984cbf7
Merge branch 'untrusted-beep' into 'master'
...
x11: Don't beep on untrusted displays
Closes #3862
See merge request GNOME/gtk!3463
2021-04-21 10:12:39 +00:00
Emmanuele Bassi
8f9145109b
a11y: Pair window:activate with window:deactivate signal
...
Orca needs both events in order to decide whether or not to subscribe to
other event/state changes in a window.
2021-04-21 10:22:20 +01:00
Matthias Clasen
5587ee0c30
x11: Don't beep on untrusted displays
...
This can trigger BadAccess, and we don't
want that.
Fixes : #3862
2021-04-20 21:42:57 -04:00
Matthias Clasen
99750ac7ed
a11y: Realize notebook tabs when switching
...
We're not moving focus here, so we can't rely
on that to conjure the a11y objects into existence.
2021-04-20 20:35:22 -04:00
Alberts Muktupāvels
f89bad7f33
theme: fix solid-csd style
...
Move .solid-csd style out of .csd parent and adjust it so windows
look similar / same to GTK 3 windows:
- 4px padding.
- extra shadow.
https://gitlab.gnome.org/GNOME/gtk/-/issues/3879#note_1086351
https://gitlab.gnome.org/GNOME/gtk/-/issues/3879#note_1086377
2021-04-20 22:02:10 +03:00
Matthias Clasen
b97d0a3940
a11y: Avoid spurious selection changed events
...
Only send selection-changed events when we either
had a non-empty selection before, or have one now.
This should help orca speak the right things, and
not the wrong things.
Related: #3549
2021-04-20 13:23:56 -04:00
Emmanuele Bassi
639932ad8a
a11y: Emit window:activate event
...
Orca uses the window:activate event type to track top levels, and avoid
being spammed by events coming from non-focused windows.
2021-04-20 17:24:13 +01:00
Matthias Clasen
1a944b2824
stackswitcher: Set accessible label properties
...
This makes the tabs in about dialogs come out as
'About', 'Credits', and 'System', instead of
'Tab', 'Tab', 'Tab'.
2021-04-19 22:11:55 -04:00
Matthias Clasen
ae83b79984
a11y: Emit focus events
...
Orca relies on these to keep track of the focus location,
ignoring the focused state. With this change, orca can
once again speak text in entries as I type.
2021-04-19 21:29:17 -04:00
Matthias Clasen
5f2c08cef1
a11y: Make things appear on focus in
...
We are starting with a pretty empty a11y object tree,
and we want orca to bring more of it into existence
by navigating the tree. But that only happens when we
send it events. Primarily focus events, which come in
from GTK via the platform_change mechanism. So realize
the context when we are sending platform_changes,
otherwise, orca never gets the mesage.
2021-04-19 20:39:32 -04:00
Matthias Clasen
119d0b666c
Merge branch 'fix-uri-crash' into 'master'
...
Fix a possible crash in gtk_show_uri
Closes #3883
See merge request GNOME/gtk!3457
2021-04-19 21:09:44 +00:00
Matthias Clasen
ce2a433ca1
Fix a possible crash in gtk_show_uri
...
g_file_get_basename can return NULL.
Deal with it somehow.
Fixes : #3883
2021-04-19 16:49:02 -04:00
Matthias Clasen
a455db01a0
a11y: Actually set accessible roles
...
With most context realization happening inside
GtkAtspiContext in response to D-Bus calls, the
code in gtk_widget_realize_at_context that sets
the role is not executed for most accessibles,
causing them to be stuck with the 'filler' role
that makes orca ignore them.
To fix this, split gtk_widget_realize_at_context
into the actual context realization (getting on
the bus) and the setting of widget-specific
properties, and do the latter part when the
widget is rooted.
This makes accerciser report proper roles for
entries and buttons. Orca still has an issue
with getting the hierarchy populated.
2021-04-19 19:22:20 +01:00
Matthias Clasen
9e8187bdc4
a11y: Track window states more closely
...
Orca ignores events unless the object is inside an object
with role window and states ACTIVE and SHOWING. To arrange
for this, introduce a new ACTIVE platform state, and set it
for windows when they are active.
This gets orca to be a lot more talkative.
2021-04-19 19:22:20 +01:00
Matthias Clasen
9fbd11e1be
a11y: Add the root object to the cache
...
Not 100% sure this is necessary, but maybe it helps
to get orca up to speed.
2021-04-19 19:22:20 +01:00
Matthias Clasen
aa09737d4d
atspicontext: Remove an unused field
...
We don't make any use of the cache field, so drop it.
2021-04-19 19:22:20 +01:00
Matthias Clasen
435ed3158c
Merge branch 'wip/exalm/shader' into 'master'
...
gsk: Fix shader gresource paths
See merge request GNOME/gtk!3453
2021-04-19 18:01:44 +00:00
Pawan Chitrakar
72600516b9
Update Nepali translation
...
(cherry picked from commit 2a8fd6a488
)
2021-04-19 16:00:38 +00:00
Pawan Chitrakar
fbc8317c5c
Update Nepali translation
...
(cherry picked from commit 4e243d7d12
)
2021-04-19 15:58:08 +00:00
Alexander Mikhaylenko
ae7f380396
gsk: Fix shader gresource paths
...
They were never updated after having been moved.
2021-04-19 20:01:33 +05:00
Piotr Drąg
2e031e47dd
Update Polish translation
2021-04-18 12:44:35 +02:00
Emmanuele Bassi
dbe4543969
Merge branch 'gtksecurememory-updates' into 'master'
...
gtksecurememory: Request that secure memory not be dumped to disk
See merge request GNOME/gtk!3452
2021-04-17 23:46:38 +00:00
Jason Francis
b27ec5ebde
meson: check for madvise()
2021-04-17 19:30:20 -04:00
Matthew Garrett
6622ebb310
gtksecurememory: Request that secure memory not be dumped to disk
...
Linux 3.4 added support for the MADV_DONTDUMP option to madvise(), which
requests that the covered memory not be included in coredumps. It makes
sense to use this to prevent cases where application crashes could
result in secrets being persisted to disk or included in dumps that are
uploaded to remote servers for analysis. I've avoided making this fatal
since there's a chance this code could be built on systems that have
MADV_DONTDUMP but run on systems that don't.
2021-04-17 19:29:42 -04:00
Matthias Clasen
1530c90e37
Merge branch 'a11y-debug' into 'master'
...
testatcontext: Print out platform changes
See merge request GNOME/gtk!3451
2021-04-17 16:39:20 +00:00
Matthias Clasen
a804e4bd8c
a11y: Add more debug spew
...
This is in an attempt to figure out why orca won't speak.
2021-04-17 12:00:17 -04:00
Matthias Clasen
a04ce41799
testatcontext: Print out platform changes
...
This helps debugging what changes orca sees.
2021-04-17 12:00:11 -04:00
Matthias Clasen
5e3e1dd6ba
Merge branch 'matthiasc/for-master' into 'master'
...
image, picture: Move pixbuf code to gdkpixbufutils
See merge request GNOME/gtk!3449
2021-04-16 23:51:10 +00:00
Matthias Clasen
379bb6c9f5
placesview: Fix server mount feedback
...
We weren't properly resetting the in-entry progress.
2021-04-16 19:34:24 -04:00
Matthias Clasen
3df3a0499f
placesview: Fix mounting remote locations
...
This was broken by a stupid copy-paste error.
2021-04-16 19:17:37 -04:00
Matthias Clasen
0d308d09f3
mountoperation: Some cosmetics
...
Fix up the dialog minimally.
2021-04-16 19:05:14 -04:00
Matthias Clasen
1331d5cf97
cssimageurl: Remove direct pixbuf use
...
Rely on the gdkpixbufutils api that gives us
a paintable.
2021-04-16 18:27:40 -04:00
Matthias Clasen
91f3f5c63b
image, picture: Move pixbuf code to gdkpixbufutils
...
This cleans up and moves the code to load files
while taking the scale into account. Along the way,
we drop the last uses of GdkPixbufAnimation, and
consolidate the pixbuf using code in one place.
2021-04-16 18:27:40 -04:00
Matthias Clasen
486a2c9651
Merge branch 'matthiasc/for-master' into 'master'
...
pixbufutils: Remove an unused function
See merge request GNOME/gtk!3447
2021-04-16 15:16:48 +00:00
Matthias Clasen
05af726446
Merge branch 'wayland-xdg-surface-setup' into 'master'
...
wayland: Don't duplicate xdg_surface setup code
See merge request GNOME/gtk!3191
2021-04-16 15:16:28 +00:00
Jonas Ådahl
36347b21e6
Merge branch 'wayland-parent-shadow-refactor' into 'master'
...
wayland: Avoid directly accessing shadow property of parent surface
See merge request GNOME/gtk!3190
2021-04-16 14:34:42 +00:00
David Keijser
db8bf5e7b9
wayland: Don't duplicate xdg_surface setup code
2021-04-16 16:23:16 +02:00
David Keijser
5bbdf3a807
wayland: Avoid directly accessing shadow property of parent surface
2021-04-16 16:13:07 +02:00
Matthias Clasen
08b101ace8
pixbufutils: Remove an unused function
2021-04-16 09:19:06 -04:00
Matthias Clasen
5e53c0473a
Merge branch 'latest.glib.msvc' into 'master'
...
Fix builds against latest stable GLib with MSVC
See merge request GNOME/gtk!3443
2021-04-16 12:25:43 +00:00
Matthias Clasen
9d1e5aa0dc
Merge branch 'fix-focus-unsetting' into 'master'
...
window: Fix deferred focus unsetting
Closes #3413
See merge request GNOME/gtk!3446
2021-04-16 11:47:44 +00:00
Matthias Clasen
4d19de4e03
window: Fix deferred focus unsetting
...
In commit 4a76abffd4
, we deferred unsetting focus
and default until after the next draw, overlooking the
case where the focus is set to another widget before we
ever get to the unsetting.
Fixes : #3413
2021-04-16 07:35:26 -04:00
Chun-wei Fan
153019a794
GTK: Fix builds against latest stable GLib with MSVC
...
GLib-2.68.x now considers warning C4098 ('void' function returning a value) as
an error, so avoid doing that.
2021-04-16 11:39:24 +08:00
Chun-wei Fan
8df32e93be
GSK: Fix builds against latest stable GLib with MSVC
...
GLib-2.68.x now considers warning C4098 ('void' function returning a value) as
an error, so avoid doing that.
2021-04-16 11:39:17 +08:00
Chun-wei Fan
14632e11da
GDK: Fix builds against latest stable GLib with MSVC
...
GLib-2.68.x now considers warning C4098 ('void' function returning a value) as
an error, so avoid doing that.
2021-04-16 11:39:09 +08:00
Matthias Clasen
24cd05672e
Merge branch 'im-context-event-leak' into 'master'
...
imcontext: Eat key events during preedit
See merge request GNOME/gtk!3440
2021-04-15 22:16:49 +00:00
Matthias Clasen
74a68a5803
Merge branch 'theme-fallback-fix' into 'master'
...
themes: Make fallback work a bit better
See merge request GNOME/gtk!3441
2021-04-15 21:31:09 +00:00
Matthias Clasen
9f6b3e179f
themes: Make fallback work a bit better
...
One case we did not include in fd329e0ec5
is
Adwaita-dark -> Default:dark
It turns out that it is needed.
2021-04-15 17:09:46 -04:00
Matthias Clasen
20fb64704d
imcontext: Eat key events during preedit
...
Avoid passing through random key press or release
events while we are showing preedit. That prevents
'accidents' like typing Ctrl-. bringing up the
Emoji chooser during preedit, or hitting Ctrl-a
after the Compose key moving the 'dot' around in
vim in terminals.
2021-04-15 16:59:02 -04:00
Matthias Clasen
9b7f927b3c
Merge branch 'demo-manpages' into 'master'
...
meson: only build demo manpages when demos are enabled
See merge request GNOME/gtk!3438
2021-04-15 11:15:24 +00:00
Matthias Clasen
eb3df6a2e8
Merge branch 'theme-icon-filter-fixes' into 'master'
...
theme: Use -gtk-icon-filter for full-color icons
See merge request GNOME/gtk!1990
2021-04-15 11:12:28 +00:00
nana-4
c6483d431f
theme: Use -gtk-icon-filter for full-color icons
...
Not for symbolic icons.
Don't apply `-gtk-icon-filter: opacity(0.5);` to the symbolic icons as
they already have the "gray" colors indicating the disabled state.
Symbolic icons can be styled using the `color` property.
Also remove the obsolete comment.
2021-04-15 18:39:08 +09:00
Eli Schwartz
e5b0d225de
meson: only build demo manpages when demos are enabled
...
Installing them even when manpages are enabled, but the demos are
disabled, produces manpages for unavailable programs...
2021-04-13 22:55:03 -04:00
Matthias Clasen
d1d009b491
Merge branch 'x11-quiet-exit' into 'master'
...
x11: Be quiet on exit by default
See merge request GNOME/gtk!3436
2021-04-14 00:32:05 +00:00
Matthias Clasen
4465ee5414
Merge branch 'ngl-crash' into 'master'
...
ngl: Fix a rare assertion violation
Closes #3853
See merge request GNOME/gtk!3434
2021-04-13 22:02:44 +00:00
Matthias Clasen
6f11165dd1
x11: Be quiet on exit by default
...
The condition we check for to catch X servers going away
may not be accurate anymore, and the warning shows up in
logs, causing customers to be concerned. So, be quiet by
default, unless the user explicitly asked for a message.
2021-04-13 14:52:48 -04:00
Ondrej Holy
ddeabc7e19
placesview: Open location even if mount was not found
...
Some locations have to be mounted, but their mounts are not user-visible
(e.g. smb-browse). Though this is maybe a bit weird, it is how it works
for years. The problem is that the commit 267ea755
, which tries to get the
default location for opening, caused regression as it doesn't expect such
possibility. Before this commit, such locations were opened without any
issue, but nothing happens currently after clicking to "Connect" except of
clearing the "Connect to Server" entry. Let's fallback to the original
location if the mount was not found to fix this regression.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1811
2021-04-13 17:33:03 +02:00
Matthias Clasen
f5d90826f3
Merge branch 'flatpak-highlight' into 'master'
...
flatpak: Include highlight in gtk4-demo flatpak
Closes #3867
See merge request GNOME/gtk!3433
2021-04-13 11:38:45 +00:00
Matthias Clasen
11154ba119
flatpak: Include highlight in gtk4-demo flatpak
...
Include the highlight utility to make syntax
highlighting work in gtk4-demo. This requires
building its dependencies as well, boost and lua.
2021-04-12 23:55:11 -04:00
Matthias Clasen
c66b030427
ngl: Fix a rare assertion violation
...
When we clean up the uniform allocations after a frame,
it can happen that our space requirements actually increase,
due to padding that depends on the order of allocations.
Instead of asserting that it doesn't happen, just make
it work by growing our allocation.
Fixes : #3853
2021-04-12 22:53:48 -04:00
Matthias Clasen
0c3dd0cf30
Merge branch 'testsuite-asserts' into 'master'
...
testsuite: Reduce the use of g_assert
Closes #3864
See merge request GNOME/gtk!3432
2021-04-13 02:46:07 +00:00
Matthias Clasen
4164abd9f7
build: Quiet the compiler
...
Don't use -Wnull-dereference when assertions are
disabled, since that causes the compiler to see
NULL everywhere.
2021-04-12 22:11:05 -04:00
Emmanuele Bassi
b0990aa8e2
wayland: Build with G_DISABLE_ASSERT
2021-04-12 21:26:02 -04:00
Emmanuele Bassi
a871a1bdb5
build: Don't append multiple flags as a string
...
The gtk_debug_cflags variable is an array, with each argument stored in
a separate string; if we add multiple arguments inside the same string
we break the escaping rules.
Fixes : #3864
2021-04-12 21:23:57 -04:00
Emmanuele Bassi
31e08d4629
gsk/ngl: Build with G_DISABLE_ASSERT enabled
2021-04-12 21:23:18 -04:00
Matthias Clasen
f98353c20b
Force g_test_init to cooperate
...
Change all g_test_init calls in the testsuite
to avoid the macro, so they work regardless of
G_DISABLE_ASSERT.
2021-04-12 21:22:46 -04:00
Matthias Clasen
13ece4ee9b
Make gtk_test_init work without assertions
...
The g_test_init macro 'helpfully' refuses to work when
assertions are disabled. So we just use the function.
2021-04-12 21:22:46 -04:00
Matthias Clasen
6e40f4f357
Remove assertions in tests
2021-04-12 21:22:46 -04:00
Matthias Clasen
ecfba2d31b
Inspector: Fix a possible undefined use
2021-04-12 21:22:46 -04:00
Matthias Clasen
367dfee36e
Fix unused variable warnings
...
These happen for variables which are only used
in assertions, when assertions are disabled.
2021-04-12 21:22:46 -04:00
Matthias Clasen
5e7b5fe085
gtk-demo: Avoid compiler warnings without assertions
...
Avoid an unused variable warning.
2021-04-12 21:22:46 -04:00
Matthias Clasen
9d3aa2cfce
gsk: Avoid compiler warnings without assertions
...
Disabling assertions was provoking some unused variable
warnings from the compiler. Avoid these.
2021-04-12 21:22:46 -04:00
Matthias Clasen
8c156e6b80
testsuite: Reduce the use of g_assert
...
Stop using g_assert() in the gtk tests.
2021-04-12 21:22:46 -04:00
Matthias Clasen
4d1075a082
testsuite: Reduce the use of g_assert
...
Stop using g_assert() in the gsk tests.
2021-04-12 21:22:46 -04:00
Matthias Clasen
442f485591
Merge branch 'f16c.msvc' into 'master'
...
Fix F16C build/runtime detection on Visual Studio
See merge request GNOME/gtk!3429
2021-04-12 20:35:10 +00:00
Matthias Clasen
74238b5429
Merge branch 'testsuite-asserts' into 'master'
...
testsuite: Reduce use of g_assert
See merge request GNOME/gtk!3431
2021-04-12 12:47:09 +00:00
Matthias Clasen
f9fa92766b
testsuite: Reduce use of g_assert
...
Stop using g_assert() in the css tests.
2021-04-12 08:33:41 -04:00
Matthias Clasen
90d187894d
testsuite: Reduce use of g_assert
...
Stop using g_assert() in the reftests.
2021-04-12 08:30:56 -04:00
Matthias Clasen
03db2690e2
testsuite: Reduce use of g_assert
...
Stop using g_assert() in the gdk tests.
2021-04-12 08:18:00 -04:00
Chun-wei Fan
65b35457fd
meson.build: Check for F16C on 32-bit Visual Studio
...
It is also possible to enable F16C instructions on 32-bit Visual Studio builds,
so also check for the compiler's ability to build F16C code on Visual Studio
32-bit instead of just bailing out.
2021-04-12 18:13:42 +08:00
Chun-wei Fan
d5ced21264
gsk/ngl/fp16.c: Implement runtime F16C detection on MSVC
...
We need to use __cpuid() to check for the presence of F16C instructions on
Visual Studio builds, and call the half_to_float4() or float_to_half4()
implementation accordingly, as the __builtin_cpu...() functions are strictly
for GCC or CLang only.
Also, since __m128i_u is not a standard intrisics type across the board, just
use __m128i on Visual Studio as it is safe to do so there for use for
_mm_loadl_epi64().
Like running on Darwin, we cannot use the alias __attribute__ as __attribute__
is also for GCC and CLang only.
2021-04-12 18:13:42 +08:00
Chun-wei Fan
6d6c8c59eb
meson.build: Improve F16C detection on Visual Studio
...
The __builtin_cpu...() intrisics are strictly for GCC/CLang-based compilers, so
don't use them in the checking code on Visual Studio. The test code will still
compile without this change, but will certainly fail if we want it to link.
2021-04-12 18:13:42 +08:00
Matthias Clasen
46ed7540b2
Merge branch 'ngl-shadow-fixes' into 'master'
...
ngl: Fix outset blurred shadows
See merge request GNOME/gtk!3427
2021-04-12 05:07:29 +00:00
Matthias Clasen
3ad56a762f
Merge branch 'grouped-toggle-fix' into 'master'
...
togglebutton: Fix expected group behavior
See merge request GNOME/gtk!3425
2021-04-12 02:40:43 +00:00
Matthias Clasen
21a1a40555
Merge branch 'shadow-reduction' into 'master'
...
gsk: Don't overshadow
See merge request GNOME/gtk!3419
2021-04-12 02:39:55 +00:00
Matthias Clasen
849692b24b
ngl: Fix unevenly scaled shadows
...
Ensure that we don't cut them off at the edges.
2021-04-11 22:35:02 -04:00
Matthias Clasen
f3bf4e4876
ngl: Don't slice unsliceable shadows
...
When the corners are too big to make slicing work,
don't do it, since it leads to broken results.
2021-04-11 22:10:33 -04:00
Matthias Clasen
46270d3dcd
ngl: Fix a case of flipped shadow
...
In the non-sliced case, we were rendering the shadow
upside down.
2021-04-11 22:10:33 -04:00
Matthias Clasen
da6096faaf
ngl: Add code to dump shadows
...
This can be helpful in understanding shadow bugs.
2021-04-11 21:13:47 -04:00
Matthias Clasen
2a7b5a5156
Merge branch 'matthiasc/for-master' into 'master'
...
menubutton: Propagate focus-on-click
See merge request GNOME/gtk!3424
2021-04-11 22:41:26 +00:00
Matthias Clasen
233e662294
togglebutton: Fix expected group behavior
...
The expectation is that a grouped button stays
active when you click it. Grouped check buttons
behave this way, and grouped toggle buttons should
too.
2021-04-11 18:29:53 -04:00
Matthias Clasen
ae41697d83
node-editor: Make header buttons not steal focus
...
This is rarely useful, and is confusing when it
happens as side-effect of dragging the window.
2021-04-11 15:32:15 -04:00
Matthias Clasen
e2fb59798e
icon browser: Make header buttons not steal focus
...
This is rarely useful, and is confusing when it
happens as side-effect of dragging the window.
2021-04-11 15:32:15 -04:00
Matthias Clasen
d0fc3e166d
widget-factory: Make header buttons not steal focus
...
This is rarely useful, and is confusing when it
happens as side-effect of dragging the window.
2021-04-11 15:32:15 -04:00
Matthias Clasen
e4ce46e75f
gtk-demo: Make header buttons not steal focus
...
This is rarely useful, and is confusing when it
happens as side-effect of dragging the window.
2021-04-11 15:32:15 -04:00
Matthias Clasen
e2420f62fe
menubutton: Propagate focus-on-click
...
Propagate the focus-on-click setting to the button
inside, so that setting menubuttons as !focus-on-click
works as expected. This helps for menubuttons in
header bars, where dragging on the button will otherwise
steal focus from the content.
2021-04-11 15:32:15 -04:00
Yuri Chornoivan
6712106c25
Update Ukrainian translation
2021-04-11 18:39:40 +00:00
Matthias Clasen
5b55138729
Merge branch 'matthiasc/for-master' into 'master'
...
some small optimizations
See merge request GNOME/gtk!3423
2021-04-11 18:23:54 +00:00
Matthias Clasen
1d9c581f10
ngl: Allow passing bounds to update_clip
...
update_clip only uses the bounds of the node that
we are currently passing. This opens the door to
updating the clip while handling a single node.
2021-04-11 12:54:17 -04:00
Matthias Clasen
6bfb57db16
ngl: Small optimization for shadows
...
When 9-slicing shadows, omit the center tile when it is
entirely contained in the outline (that is not always
the case, depending on corners and offsets).
2021-04-11 12:54:07 -04:00
Matthias Clasen
f8f2f2944f
roundedrect: Speed up contains_rect and friends
...
gsk_rounded_rect_contains_rect was calling
gsk_rounded_rect_contains_point, which potentially
checks all four corners, for a total of up to 16
corner/point checks. But there is no need to do
more than 4 such checks to answer the question.
2021-04-11 12:52:30 -04:00
Matthias Clasen
aaf17fd3d0
ngl: Small optimization
...
We really want equality here.
2021-04-11 12:50:50 -04:00
Matthias Clasen
678e6fc6d6
nodeeditor: Make the help window wide enough
...
Make the help window wide enough to show the
tables without wrapping.
2021-04-11 12:50:34 -04:00
Matthias Clasen
fcf39170e1
Merge branch 'media-memory-leak' into 'master'
...
media: Fix a memory leak
See merge request GNOME/gtk!3420
2021-04-10 13:42:41 +00:00
Matthias Clasen
187072c3fa
media: Fix a memory leak
...
This was introduced in e7dc82fa32
.
2021-04-10 09:02:59 -04:00
Matthias Clasen
e6599c6c4f
gsk: Don't overshadow
...
Reduce the cairo shadows to the same size as their GL brethren.
2021-04-09 21:47:55 -04:00
Matthias Clasen
87a8ff90d6
Merge branch 'popover-list-lockup' into 'master'
...
window: Defer focus setting until after paint
Closes #3725
See merge request GNOME/gtk!3417
2021-04-10 00:34:24 +00:00
Matthias Clasen
4a76abffd4
window: Defer focus setting until after paint
...
Commit 3dbf5038fa
tried to defer focus changes
until after rendering is done. But it failed to do so, since
the toplevel ::render handler is still before rendering of
popups that are attached to that toplevel. To do this
properly, we need to do it in the AFTER_PAINT frame clock
phase.
Fixes : #3725
2021-04-09 19:44:10 -04:00
Matthias Clasen
715449695c
Merge branch 'ngl-coloring-underlines' into 'master'
...
Optimize underlines in text
See merge request GNOME/gtk!3414
2021-04-09 15:36:21 +00:00
Matthias Clasen
d15b0afca9
Merge branch 'no-scroll-cursor' into 'master'
...
scrolledwindow: Stop using scroll cursors
See merge request GNOME/gtk!3416
2021-04-09 13:30:36 +00:00
Matthias Clasen
0d6bbc035d
Merge branch 'ebassi/ci-docs' into 'master'
...
ci: Drop the split Fedora images
See merge request GNOME/gtk!3415
2021-04-09 12:35:49 +00:00
Matthias Clasen
9313d4b6b4
scrolledwindow: Stop using scroll cursors
...
We used to override cursor to use all-scroll while the
content is being scrolled. Unfortunately, there is several
problems with this:
- It is really only expected certain devices, and we don't
have the device information on Wayland
- With the way cursor setting works in GTK4, non-NULL cursors
of the content (eg the text views ibeam) win, making the
scroll cursor not show up
- Under X11, we seem to miss scroll end events and then
the scroll cursor gets stuck
Therefore, just remove this feature.
2021-04-09 08:26:09 -04:00
Emmanuele Bassi
ed412f43d1
ci: Drop the split Fedora images
...
Now that we don't need the whole of Pandoc to build our documentation,
we can go back to a single Fedora image for our CI.
2021-04-09 12:28:08 +01:00
Matthias Clasen
bfe4aea981
ngl: Add a program change counter
...
Count how often we change programs during a frame.
2021-04-09 00:52:18 -04:00
Matthias Clasen
0caa28c1de
ngl: Optimize underlines in text
...
Opportunistically use the coloring program for
drawing underlines instead of the color program.
This avoids program changes in the middle of
text.
For the Emoji text scrolling benchmark, this reduces
the program changes per frame from > 1000 to around 100.
2021-04-08 23:37:51 -04:00
Matthias Clasen
d8ba4b4114
ngl: Reserve a pixel in texture atlases
...
This will be used for coloring from the texture.
2021-04-08 23:34:37 -04:00
Matthias Clasen
e7963945bb
ngl: Fix an oversight
...
All the rest of debug spew goes to stderr here.
2021-04-08 23:34:37 -04:00
Matthias Clasen
e4a6101ae0
gtk-demo: Make one text scroll benchmark harder
...
Add underlines into the mix with the Emoji heavy
text, to see if we can optimize lines.
2021-04-08 23:34:36 -04:00
Matthias Clasen
5d0a3bd4cb
Merge branch 'half-float' into 'master'
...
ngl: Use fp16 for colors
See merge request GNOME/gtk!3405
2021-04-09 03:34:05 +00:00
Matthias Clasen
1c2238cc2a
Merge branch 'font-fallback-fix' into 'master'
...
wayland: Improve font setting fallback more
Closes #3838
See merge request GNOME/gtk!3412
2021-04-08 11:24:09 +00:00
Matthias Clasen
2d7169fd5f
Work around compiler shortcomings on macOS
...
alias attributes don't work on Darwin, so
do without.
2021-04-07 22:38:47 -04:00
Matthias Clasen
885a6b8ebc
gsk: Add runtime checks for F16C
...
Use an IFUNC resolver to determine whether we can use
intrinsics for FP16 conversion. This requires the functions
to be no longer inline.
Sadly, it turns out that __builtin_cpu_supports ("f16c")
doesn't compile on the systems where we want it to prevent
us from getting a SIGILL at runtime.
2021-04-07 22:21:23 -04:00
Matthias Clasen
9d81c129fc
Add an option to disable F16C
...
And add a compile time check for the presence of this
CPU feature.
2021-04-07 22:21:23 -04:00
Matthias Clasen
38c6fe2ce4
Move color conversion up
...
Doing the color conversion early lets us reuse
the results whenever we do more than one draw
per node.
2021-04-07 21:30:43 -04:00
Matthias Clasen
7fe7b7ac7d
ngl: Use a constant for (fp16)-1
...
No need to convert that again for every glyph.
2021-04-07 21:30:43 -04:00
Matthias Clasen
ae7f52d301
ngl: Reduce vertex storage
...
We only have one shader that uses the color2 attribute,
and it doesn't use the uv attribute, so save vertex
memory by putting those in the same space.
This reduce the per vertex space from 32 to 24 bytes.
2021-04-07 21:30:43 -04:00
Matthias Clasen
8b1fcb58e8
ngl: Use fp16 for colors
...
This reduces the size of our Vertex struct from
48 to 32 bytes. It would be nicer if we could store
the colors in fp16 format in the rendernodes, and
avoid conversion here. But this is still good.
2021-04-07 21:30:43 -04:00
Matthias Clasen
cce36ae701
wayland: Improve font setting fallback more
...
We may get a response from the portal that contains
no useful settings at all. In that case, we should
fallback as well.
Fixes : #3838
2021-04-07 19:24:09 -04:00
Matthias Clasen
2f0a02eecb
Merge branch 'wip/carlosg/stuck-frames' into 'master'
...
surface: Always set PHASE_PAINT as pending when updates are scheduled
Closes #3750
See merge request GNOME/gtk!3411
2021-04-07 23:18:25 +00:00
Carlos Garnacho
07167fdf22
surface: Always set PHASE_PAINT as pending when updates are scheduled
...
At times (most often when closing subsurfaces that are scheduling
relayouts) the PHASE_PAINT handling gets broken with the following
sequence:
1. Surface receives wl_callback.done for the previous frame.
Surface is thawed.
2. A new update on the surface is scheduled. PHASE_PAINT is
requested directly on the frame clock. priv->pending_phase is
left unset in the surface.
3. Surface gets frozen
4. Frame clock processes the update scheduled at 2. The surface
is frozen, so paint is prevented. PHASE_PAINT is considered
handled.
5. Compositor emits wl_callback.done again. Surface is thawed.
6. At this point the machinery is off
- The surface didn't paint but has pending update regions
- priv->draw_needed is set in the toplevel and other portions
of the widget tree
- So queueing redraws is ineffective at eventually calling
gdk_surface_schedule_update() again on the toplevel surface.
- We don't paint anymore, so this broken state is not flushed
until other subsurface changes manage to schedule the missing
update.
To fix this, always set PHASE_PAINT in priv->pending_phase when
doing gdk_surface_schedule_update(). If the frame clock turns
around before the surface is thawed, it will still be waiting to
be processed the next iteration.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3750
2021-04-07 23:06:06 +02:00
Emmanuele Bassi
99c7ba7840
Install documentation in the appropriate place
...
We're already installing each reference into its own namespaced
directory, so we don't need to add further path elements.
Additionally, with the changes in:
https://gitlab.gnome.org/GNOME/devhelp/-/merge_requests/20
https://gitlab.gnome.org/GNOME/gi-docgen/-/merge_requests/54
we can browse the GTK API references in DevHelp.
2021-04-07 14:57:31 +01:00
Matthias Clasen
5710df685b
Merge branch 'font-settings-fallback-4' into 'master'
...
wayland: Improve font setting fallback
See merge request GNOME/gtk!3407
2021-04-07 13:21:38 +00:00
Matthias Clasen
62f10b1b8f
wayland: Improve font setting fallback
...
When we don't get stettings from the portal, the current
fallback is 'awful fonts'. There is no need for that. Instead,
set the fallback values to grayscale antialiasing with slight
hinting.
2021-04-07 08:50:14 -04:00
Matthias Clasen
d50d55228b
Merge branch 'textview-last-line' into 'master'
...
textview: Fix a problem with the last line
Closes #3835
See merge request GNOME/gtk!3403
2021-04-06 16:15:55 +00:00
Matthias Clasen
288a5d4151
textview: Fix a problem with the last line
...
Sometimes, we missed the last line for display.
Fixes : #3835
2021-04-06 11:09:05 -04:00
Matthias Clasen
748b8497c9
Merge branch 'matthiasc/for-master' into 'master'
...
window: Actually enable the inspector by default
Closes #3831
See merge request GNOME/gtk!3401
2021-04-05 19:05:15 +00:00
Matthias Clasen
303ff60d5e
modelbutton: Avoid a crash
...
We may not have a popover menu ancestor. The check for
this was forgotten in one of the branches here.
Fixes : #3831
2021-04-05 14:06:42 -04:00
Matthias Clasen
b79eb55b34
window: Actually enable the inspector by default
...
427d216081
changed the default in the schema,
but didn't handle cases where the schema isn't found.
2021-04-05 11:54:37 -04:00
Matthias Clasen
0ca573142a
Merge branch 'matthiasc/for-master' into 'master'
...
textlayout: Remove some unnecessary code
See merge request GNOME/gtk!3400
2021-04-05 13:19:29 +00:00
Matthias Clasen
a1ece16143
ngl: Fix an oversight
...
We were special-casing 2D affine transforms,
but overlooked even simpler transforms.
2021-04-05 08:47:53 -04:00
Matthias Clasen
2e18f1b6e3
textlayout: Remove an unused function
2021-04-05 08:47:53 -04:00
Matthias Clasen
6cf712591f
textlayout: Avoid allocations for line iteration
...
No need to collect the lines firs, and allocate memory
for that. We can just iterate over them right away.
2021-04-04 23:42:58 -04:00
Matthias Clasen
b32cd5d328
textlayout: Introduce some locals
...
No need to call _gtk_text_buffer_get_btree over and over.
2021-04-04 22:44:09 -04:00
Matthias Clasen
2af99bd65e
textlayout: Create the cursor snapshot on demand
...
We don't need it all the time.
2021-04-04 22:27:53 -04:00
Matthias Clasen
5b0ea70d1c
textattributes: Small docs fix
2021-04-04 22:27:53 -04:00
Matthias Clasen
d719a3d877
textbtree: Return tags in a GPtrArray
...
One of the callers prefers that, it lets us avoid
copying the array in one place, and generally makes
for better code.
2021-04-04 22:27:53 -04:00
Matthias Clasen
b0df8910ba
textlayout: Only get selection color once
...
No need to do this for every paragraph that is
inside the selection.
2021-04-04 14:20:25 -04:00
Matthias Clasen
5b8bf04035
texttag: Just use qsort
...
No point in trying to optimize this.
2021-04-04 14:20:25 -04:00
Matthias Clasen
58e44e296f
textbtree: Inline node data handling
2021-04-04 14:20:25 -04:00
Matthias Clasen
0334d002c0
textbtree: Speed up _gtk_text_btree_find_line_top
...
Another place where we can avoid allocating a stack
piecemeal.
2021-04-04 14:20:25 -04:00
Matthias Clasen
d731ce49ad
textbtree: Don't opencode realloc
...
We can just use g_realloc here.
2021-04-04 14:20:25 -04:00
Matthias Clasen
a93614409e
textbtree: Speed up _gtk_text_line_char_index
...
No need to allocate a stack piecemeal here.
2021-04-04 14:20:25 -04:00
Matthias Clasen
214e2d14be
textbtree: Avoid malloc in one place
2021-04-04 14:20:25 -04:00
Matthias Clasen
67ee6b2740
textlayout: Don't call render_para too much
...
render_para produces no nodes for an empty paragraph.
Don't call it over and over for those.
2021-04-04 14:20:25 -04:00
Matthias Clasen
07a3fb833c
textlayout: Remove some unnecessary code
...
The same field is set again 2 lines down.
2021-04-04 14:20:25 -04:00
Chao-Hsiung Liao
1c419f762b
Update Chinese (Taiwan) translation
...
(cherry picked from commit 3d3912d7f4
)
2021-04-03 23:54:29 +00:00
Matthias Clasen
8d6c7b81e9
Merge branch 'matthiasc/for-master' into 'master'
...
gsk: Rename resource paths
See merge request GNOME/gtk!3399
2021-04-03 20:14:29 +00:00
Matthias Clasen
fcaadf6724
Merge branch 'dotted-lines3' into 'master'
...
Modernize error underlines
See merge request GNOME/gtk!3398
2021-04-03 20:14:13 +00:00
Matthias Clasen
ff38d8cdc0
Modernize error underlines
...
Implement PANGO_UNDERLINE_ERROR as a dotted line, instead of
squiggly, which looks quite dated.
2021-04-03 13:52:56 -04:00
Matthias Clasen
900a4e4d31
gsk: Move shader resources
...
Move the resources of each renderer to its subdirectory.
We've previously done that for the ngl renderer, but it
is better to be consistent and do it for all the renderers.
2021-04-03 08:24:58 -04:00
Matthias Clasen
ee63b84b6a
gsk: Rename resource paths
...
Make the shaders of the gl renderer live under
/org/gtk/libgsk/gl. This is purely cosmetic.
2021-04-03 08:10:58 -04:00
Matthias Clasen
2f1ff307da
Merge branch 'matthiasc/for-master' into 'master'
...
node test: Improve --generate
See merge request GNOME/gtk!3397
2021-04-03 03:20:17 +00:00
Matthias Clasen
a8e8e04496
settings: Make font-size changes apply immediately
...
We need to invalidate the style when font-size changes,
because we propagate this value through the initial
value of the CSS font-size property, and it will not
be recomputed otherwise.
2021-04-02 23:04:09 -04:00
Matthias Clasen
91bcf6f0ba
immulticontext: Unset client widget on delegate change
...
Forgetting to do so was causing the Wayland im context
to leave behind a dead event controller. This was showing
up as a crash when closing the inspector after changing
the im-module property of a GtkText widget. The crash
was delayed until closing the inspector because the
inspector keeps a ref on the event controllers of the
currently shown widget.
2021-04-02 22:24:19 -04:00
Matthias Clasen
a228b2de64
imwayland: Name event controllers
...
This helps with debugging.
2021-04-02 22:24:00 -04:00
Matthias Clasen
cb18437908
widget-factory: Name an event controller
...
This helps with debugging.
2021-04-02 22:23:34 -04:00
Matthias Clasen
23dab885cd
text: Name all event controllers
...
This helps with debugging.
2021-04-02 22:23:03 -04:00
Matthias Clasen
e7284c23da
inspector: Support copying nodes to clipboard
...
Add a button that copies the serialization of the
selected node to the clipboard.
2021-04-02 21:38:14 -04:00
Matthias Clasen
1e1f199b56
node-editor: Support pasting the image
...
Add a button that copies the image to the clipboard.
2021-04-02 21:24:59 -04:00
Matthias Clasen
efb5e793a4
nodeparser: Change the serialization
...
Arrange things so that non-child parameters
are always printed before the children. This
greatly helps with readability, which really
suffers when there's hundreds of lines of indented
children between the node start and its parameters.
Update all affected tests.
2021-04-02 20:38:32 -04:00
Matthias Clasen
f2edf40e48
node test: Improve --generate
...
This is a pet peeve of mine: When we call
g_test_init() before handling --generate,
the random seed spew pollutes the output.
Highly annoying. I've fixes many test binaries
over the years, but more keep popping up.
2021-04-02 20:35:39 -04:00
Matthias Clasen
7cb99a0866
Merge branch 'fix-downscaled-textures' into 'master'
...
ngl: Fix downscaled textures
See merge request GNOME/gtk!3395
2021-04-03 00:18:48 +00:00
Matthias Clasen
36da7c3075
Merge branch 'matthiasc/for-master' into 'master'
...
comboboxtext: Remove misleading docs
Closes #3824
See merge request GNOME/gtk!3396
2021-04-03 00:04:36 +00:00
Matthias Clasen
a3b69f1101
Merge branch 'fix-initial-font-selection' into 'master'
...
fontchooser: Fix initial font selection
Closes #3687
See merge request GNOME/gtk!3392
2021-04-02 23:45:59 +00:00
Matthias Clasen
9f2d1ff264
comboboxtext: Remove misleading docs
...
The entry is no longer accessible.
The docs were outdated.
Fixes : #3824
2021-04-02 19:44:30 -04:00
Matthias Clasen
8d603dfe99
ngl: Avoid huge intermediate textures
...
Instead of rendering the unclipped child to a texture
(and risking blowing the texture size limit, and bad
downscaling), just render the clipped region, and live
with the fact that we can't cache the rendered texture.
This avoid bad artifacts when scrolling long textviews
in rounded clips.
2021-04-02 19:33:44 -04:00
Matthias Clasen
3ff04976e3
ngl: Plug a memory leak
...
This was introduced in f9457af128
.
2021-04-02 18:41:53 -04:00
Matthias Clasen
54ff4fd45f
ngl: Fix downscaled textures
...
It is not pretty, but at least it works now.
2021-04-02 18:33:01 -04:00
Matthias Clasen
0d135d90f0
Merge branch 'flat-button-activating' into 'master'
...
button: Style .keyboard-activating on frameless buttons
See merge request GNOME/gtk!3394
2021-04-02 18:50:16 +00:00
Chris Mayo
ffa9814dd0
button: Style .keyboard-activating on frameless buttons
...
The use of the keyboard-activating CSS class for buttons was added
in [1], but the style did not apply to buttons with has-frame=FALSE.
[1] 00923615f4
("button: Add back visual feedback for keynav", 2021-04-01)
2021-04-02 19:24:51 +01:00
Nathan Follens
a2fec9134b
Update Dutch translation
...
(cherry picked from commit a356bf6fac
)
2021-04-02 18:09:34 +00:00
Matthias Clasen
8caadaf404
fontchooser: Fix initial font selection
...
The change in 740559a54f
to populate the list incrementally
broke initial font selection. Fix that, by trying to select
until the incremental filling is done.
Fixes : #3687
2021-04-02 01:06:23 -04:00
Matthias Clasen
469228fcd7
Merge branch 'theme-reorg' into 'master'
...
Reorganize our themes
See merge request GNOME/gtk!3079
2021-04-02 03:02:49 +00:00
Matthias Clasen
fd329e0ec5
Make theme fallback working with the new names
...
Since we are likely going to see theme names like
Adwaita and HighContrast, make fallback work as follows:
Adwaita -> Default
Adwaita:dark -> Default:dark
HighContrast -> Default:hc
HighContrast:dark -> Default:hc-dark
HighContrastInverse -> Default:hc-dark
Other themes will fall back to Default, as before.
2021-04-01 22:02:38 -04:00
Matthias Clasen
7f4041ec30
Merge branch 'matthiasc/for-master' into 'master'
...
testsuite: Sort gsk compare tests
See merge request GNOME/gtk!3389
2021-04-02 00:38:55 +00:00
Matthias Clasen
5cb5bdc4eb
testsuite: Sort gsk compare tests
...
Easier to find things that way.
2021-04-01 20:07:13 -04:00
Matthias Clasen
08913deba5
Add some more gsk tests
...
The css-background test contains a node pattern that
is optimized in the ngl renderer.
2021-04-01 20:06:40 -04:00
Matthias Clasen
aceeef47f4
Add one more compose test
2021-04-01 20:06:40 -04:00
Matthias Clasen
ddda0ca1db
Merge branch 'button-activate-feedback' into 'master'
...
button: Add back visual feedback for keynav
Closes #3813
See merge request GNOME/gtk!3390
2021-04-01 23:36:32 +00:00
Matthias Clasen
00923615f4
button: Add back visual feedback for keynav
...
We lost the visual feedback for activating a button
via Space or Enter when the :active pseudo-state became
managed. Bring it back with a style class.
Fixes : #3813
2021-04-01 18:38:11 -04:00
Matthias Clasen
63945bc408
Merge branch 'matthiasc/for-master' into 'master'
...
Add one more compose test
See merge request GNOME/gtk!3388
2021-04-01 20:50:04 +00:00
Matthias Clasen
076f79745b
Add one more compose test
2021-04-01 16:32:30 -04:00
Matthias Clasen
8e9effcc1e
Merge branch 'us-intl-compose' into 'master'
...
Revert Compose sequence changes
Closes #3807
See merge request GNOME/gtk!3386
2021-04-01 20:01:06 +00:00
Matthias Clasen
7f4522a3f1
Add more compose tests
...
Test the sequences whose demise made people
unhappy.
2021-04-01 15:32:32 -04:00
Matthias Clasen
f98abe4400
Revert Compose sequence changes
...
This was breaking muscle memory of people with
the us intl keyboard layout, for important keys
such as '. The unfortunate side-effect is that
our handling of <dead_acute> is a bit hampered
by sequences that don't fit the pattern. But
such is life.
Fixes : #3807
2021-04-01 15:31:21 -04:00
Emmanuele Bassi
2ee8f676c3
Merge branch 'builder-tag' into 'master'
...
docs: Escape tags in GtkBuilder description
See merge request GNOME/gtk!3385
2021-04-01 18:49:38 +00:00
Chris Mayo
7216f71825
docs: Escape tags in GtkBuilder description
...
Fixes the tags and the rest of the gi-docgen created HTML page not being
visible in a browser.
2021-04-01 19:21:57 +01:00
Matthias Clasen
0bf3e4c25b
Drop Adwaita and HighContrast themes
...
These themes will reappear in libadwaita in due course.
2021-04-01 12:39:30 -04:00
Matthias Clasen
e964e176f9
widget-factory: Use the new themes
...
Update the Style menu to switch between the variants
of the Default theme.
2021-04-01 12:27:35 -04:00
Matthias Clasen
8938b09bc9
Change the default theme to "Default"
...
We are not shipping Adwaita anymore.
2021-04-01 12:27:35 -04:00
Matthias Clasen
3654bcfbe8
Make the theme variants available as themes
...
This makes it easier to implement the theme switching
in widget-factory, since we don't have a variant setting.
2021-04-01 12:27:26 -04:00
Matthias Clasen
0dcf95b898
Reorganize our themes
...
Rename the included theme to Default, with 4 variants:
light, dark, hc, hc-dark. This replaces Adwaita,
Adwaita:dark, HighContrast and HighContrastInverse.
We still make the themes available under these names,
and we still set up Adwaita-dark and HighContrastInverse
as the dark variants of Adwaita and HighContrast.
The unification of the theme variants under Default
is not quite perfect; it would be nice to merge
the assets/ and assets-hc/ subdirectories and render
all assets from a single svg file.
2021-04-01 11:42:17 -04:00
Benjamin Otte
405fab8b36
Merge branch 'wip/otte/for-master' into 'master'
...
snapshot: scale border widths when appending border nodes
Closes #3819
See merge request GNOME/gtk!3384
2021-04-01 15:10:50 +00:00
Benjamin Otte
ef455f5c85
snapshot: Move sanity checks to a better place
...
Fixes cases where the sanity checks would reject valid code, like when
using GL shaders on a scaled transform.
Fixes #3819
2021-04-01 16:53:33 +02:00
Benjamin Otte
05e4cd1579
snapshot: scale border widths when appending border nodes
...
Found by Matthias on IRC while arguing about GtkSnapshot being too
complicated.
2021-04-01 16:37:43 +02:00
Matthias Clasen
0ea96e3b0c
Merge branch 'filechooser-signal-disconnect' into 'master'
...
filechooserwidget: Disconnect settings signal on dispose
See merge request GNOME/gtk!3383
2021-04-01 14:25:08 +00:00
Carlos Garnacho
1e9e7bf0d9
Merge branch 'wip/exalm/overshoot-changes' into 'master'
...
scrolledwindow: Cancel overshoot on dimension changes
Closes #3752
See merge request GNOME/gtk!3300
2021-04-01 12:11:15 +00:00
Alexander Mikhaylenko
d7a5dedd4f
scrolledwindow: Cancel overshoot on dimension changes
...
If we scroll down in a list that's still being filled, we hit the edge and
initiate overshoot, and then the adjustment's upper value increases. This
leads to an unwanted bounce back.
Additionally, if in a similar situation the upper value decreases, the
overscroll glow gets stuck.
Update kinetic scrolling upper and lower value on changes, and immediately
cancel it if dimensions on that side change.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3752
2021-04-01 16:37:30 +05:00
Rafał Dzięgiel
2e65416270
filechooserwidget: Reduce code duplication for disconnecting settings signal
...
Instead of getting current display before calling settings signal removal,
do it inside remove function and only if there is a signal connection to remove.
2021-04-01 09:36:23 +02:00
Rafał Dzięgiel
13c22e4e2f
filechooserwidget: Disconnect settings signal on dispose
...
Settings signal was not being disconnected on dispose causing
application crash when user changed icon theme after dialog disposal.
2021-04-01 09:28:37 +02:00
Matthias Clasen
65a061f3c2
Merge branch 'ebassi/broadway-docs' into 'master'
...
docs: Update the Broadway instructions
See merge request GNOME/gtk!3380
2021-03-31 21:42:59 +00:00
Matthias Clasen
fc63e6856f
Merge branch 'ebassi/docs-links' into 'master'
...
docs: Update the links to the docs of GTK dependencies
Closes #3817
See merge request GNOME/gtk!3381
2021-03-31 21:42:49 +00:00
Matthias Clasen
94747d53eb
Merge branch 'offscreen-fixes' into 'master'
...
Offscreen fixes
See merge request GNOME/gtk!3379
2021-03-31 21:27:18 +00:00
Matthias Clasen
b5df1299ec
gsk: Add another test
...
Compare clipped repeat nodes. Must skip cairo here
since it blurred the child by scaling after rendering.
Also skip the gl renderer, since it hasn't been fixed
for this yet. ngl passes this test.
2021-03-31 16:49:31 -04:00
Emmanuele Bassi
7bfff6c51e
docs: Update the links to the docs of GTK dependencies
...
Use docs.gtk.org where appropriate.
Fixes : #3817
2021-03-31 20:51:27 +01:00
Emmanuele Bassi
3fdedce8f6
docs: Update the Broadway instructions
...
The Broadway server binary is now versioned, and it's not compatible
with the GTK3 server.
2021-03-31 20:06:54 +01:00
Matthias Clasen
6f62107656
testsuite: Rename next to ngl
...
Use specific names for renderers in the gsk tests.
Otherwise the tests may use the wrong renderer, or
the same renderer twice.
2021-03-31 14:59:43 -04:00
Matthias Clasen
f9457af128
ngl: Fix offscreen rendering with transforms
...
There was confusion here about the handling of the
modelview transform. The modelview transform we are
getting is already set up for rendering the node
we are given, so keep it - except for possible adding
an extra scale on top when the texture would otherwise
be too big.
2021-03-31 14:36:24 -04:00
Matthias Clasen
94f0a4ef2c
ngl: Be explicit about offscreen clipping
...
Explicitly set all the input arguments.
This makes it clearer what is going on.
2021-03-31 14:34:16 -04:00
Matthias Clasen
53e75936cb
ngl: Add sonme comments
...
The GskNglRenderOffscreen struct is a mix of in and
out arguments. Better annotate that a little bit.
2021-03-31 14:32:47 -04:00
Matthias Clasen
5f0fe09423
Merge branch 'ebassi/for-master' into 'master'
...
Update the gi-docgen repository
See merge request GNOME/gtk!3352
2021-03-31 11:34:56 +00:00
Benjamin Otte
9e402fa064
Merge branch 'wip/otte/for-master' into 'master'
...
gstmedia: Properly detect stream metadata when preparing
See merge request GNOME/gtk!3377
2021-03-30 21:54:57 +00:00
Emmanuele Bassi
d84440969a
Merge branch 'ebassi/docs-ci' into 'master'
...
ci: Add missing graphviz dependency
See merge request GNOME/gtk!3376
2021-03-30 20:44:51 +00:00
Benjamin Otte
e7dc82fa32
gstmedia: Properly detect stream metadata when preparing
...
We can look at the GstPlayerMediaInfo to get all the info we care about.
2021-03-30 22:26:26 +02:00
Emmanuele Bassi
f1b3492700
ci: Add missing graphviz dependency
...
We generate the hierarchy graph for GTK types, and in order to do so, we
need the dot utility from graphviz in the CI image.
2021-03-30 21:08:43 +01:00
Anders Jonsson
6c95fc7e87
Update Swedish translation
2021-03-30 17:13:11 +00:00
Matthias Clasen
f4cc9a47ad
Merge branch 'docs' into 'master'
...
docs: Cover corner-case of @line_number = total lines in buffer
See merge request GNOME/gtk!3373
2021-03-30 16:09:34 +00:00
Matthias Clasen
ccbbc2f2ba
4.2.0
2021-03-30 11:00:55 -04:00
Matthias Clasen
8bc2ee63eb
Actually build docs for releases
2021-03-30 11:00:54 -04:00
Matthias Clasen
68d634b31c
Disable the border-image-url reftest
...
It seems to make assumptions about text positioning that
are not holding with subpixel positioning. I'm not 100%
sure how that leads to exactly the artifacts that are seen
here, but I am just disabling the test until that is fully
understood.
2021-03-30 11:00:54 -04:00
Matthias Clasen
d1c66f75e3
Disable flaky focus tests
2021-03-30 11:00:54 -04:00
Matthias Clasen
eba9cd8775
Disable the label-background reftest
...
It makes assumptions about text positioning that are
not holding with subpixel positioning. There is no
guarantee that the next word in a multi-word text
starts on an even pixel boundary, as it does when
you break the text into multiple, separately rendered
blocks.
2021-03-30 11:00:54 -04:00
Matthias Clasen
9606945ed8
Fix tests for new version
2021-03-30 11:00:54 -04:00
Matthias Clasen
d50d382032
Merge branch 'ebassi/dist-docs' into 'master'
...
build: Dist the API references
See merge request GNOME/gtk!3375
2021-03-30 14:58:53 +00:00
Emmanuele Bassi
5da3308572
build: Dist the API references
...
Copy them into the dist root from the build root, so that they will be
available in the release archive.
2021-03-30 15:42:40 +01:00
Jonas Ådahl
fb48699ba4
Merge branch 'issue3791-gtk4' into 'master'
...
gdk/wayland: Defer processing of globals closures
Closes #3791
See merge request GNOME/gtk!3374
2021-03-30 14:06:33 +00:00
Robert Mader
56d37ceed0
gdk/wayland: Defer processing of globals closures
...
... until all globals have been received.
The dependency tracking introduced in 4e9be39518
only allows to
specify required globals and processes the closures as soon as
the requirements have been met. There are, however, also optional
dependencies - most notably the primary_selection protocol.
Currently we rely on the fact that compositors like Mutter announce
it before `wl_seat`, even though the order is not specified in
the spec.
Process globals closures only after all globals have been announced,
so optional dependencies can be accommodated.
Closes https://gitlab.gnome.org/GNOME/gtk/-/issues/3791
2021-03-30 15:20:00 +02:00
Avinash Sonawane
622bb9186e
docs: Cover corner-case of @line_number = total lines in buffer
2021-03-30 17:00:33 +05:30
Matthias Clasen
b77e05ce37
Merge branch 'ngl-text-tweaks' into 'master'
...
Ngl text tweaks
See merge request GNOME/gtk!3367
2021-03-30 11:15:13 +00:00
Matthias Clasen
ba4e66d189
ngl: Avoid a goto
...
Reshuffle the code slightly, so we can use a continue
instead.
2021-03-30 00:34:52 -04:00
Matthias Clasen
2c33550048
gsk: Avoid empty glyphs early
...
Strip out PANGO_GLYPH_EMPTY when text nodes are
constructed. Then we don't have to check this special
case in the inner loop in visit_text_node.
2021-03-30 00:34:52 -04:00
Matthias Clasen
3add99a9a8
ngl: Speed up glyph loop
...
Move some work out of the loop in visit_text_node.
This takes advantage of the fact that the yoffset
of most glyphs is zero, so yphase generally does
not change in a line of text.
2021-03-30 00:19:28 -04:00
Matthias Clasen
d4ea2e848d
ngl: We only need two bits for phases
...
We use 4 phases, so 2 bits are enough.
2021-03-30 00:19:28 -04:00
Matthias Clasen
4c06889243
Updates
2021-03-30 00:18:48 -04:00
Matthias Clasen
ef544a8c3b
Merge branch 'ngl-trivia' into 'master'
...
Ngl trivia
See merge request GNOME/gtk!3372
2021-03-30 04:16:00 +00:00
Matthias Clasen
6db9215dd1
Merge branch 'video-player-images' into 'master'
...
gtk-demo: Allow opening images in video player
See merge request GNOME/gtk!3371
2021-03-30 03:54:13 +00:00
Matthias Clasen
8b64f0147c
gtk-demo: Allow opening images in video player
...
It works, so why not.
2021-03-29 23:40:17 -04:00
Matthias Clasen
5847f75c57
ngl: Cosmetics
...
Remove a local variable in gsk_render_job_visit_text_node.
2021-03-29 15:17:20 -04:00
Matthias Clasen
ce2c3efc91
ngl: Improve packing
...
Pack texture cache entries slightly better.
There was a 4 byte hole here.
2021-03-29 15:17:10 -04:00
Matthias Clasen
2599c5aed3
gsk: Typo fix
2021-03-29 15:16:44 -04:00
Matthias Clasen
bca39e2605
ngl: Typo fix
2021-03-29 15:16:25 -04:00
Matthias Clasen
ca0e1be03e
Merge branch 'frame-rate-benchmark' into 'master'
...
Add a frame benchmark
See merge request GNOME/gtk!3364
2021-03-29 15:52:51 +00:00
Benjamin Otte
6569a877d8
Merge branch 'wip/otte/for-master' into 'master'
...
Wip/otte/for master
Closes #3810
See merge request GNOME/gtk!3366
2021-03-29 15:41:55 +00:00
Benjamin Otte
38fff37dae
mediastream: Insist streams are prepared when they start playing
...
Applications expect that behavior, so don't let implementations get away
without preparing the stream.
2021-03-29 17:08:34 +02:00
Benjamin Otte
06be1f8b52
gstmedia: Ensure we prepare files without duration
...
In particular this fixes playback of images.
Fixes #3810
2021-03-29 17:08:34 +02:00
Matthias Clasen
43a1641dd7
Add a frame benchmark
...
This can be used to gauge what fps we can hope for
in the best case, on a given system.
2021-03-29 08:27:43 -04:00
Yosef Or Boczko
b21fba117f
Update Hebrew translation
...
(cherry picked from commit 1beb550830
)
2021-03-28 22:34:55 +00:00
Yosef Or Boczko
37d5f93610
Update Hebrew translation
...
(cherry picked from commit 4a7e08bb8e
)
2021-03-28 21:31:44 +00:00
Matthias Clasen
52aea624a6
Merge branch 'text-node-tweak' into 'master'
...
textview: Tweak render nodes
See merge request GNOME/gtk!3362
2021-03-28 17:25:36 +00:00
Matthias Clasen
711acb6aa7
Merge branch 'smarter-diff' into 'master'
...
Smarter diff
See merge request GNOME/gtk!3361
2021-03-28 17:24:23 +00:00
Hugo Carvalho
3e94c5afa4
Update Portuguese translation
...
(cherry picked from commit ef7cbad45d
)
2021-03-28 16:35:59 +00:00
Matthias Clasen
a75c038e09
textview: Tweak render nodes
...
Arrange for the contents to be in a single transform
node that is updated as we scroll. This makes the job
of the render node differ a lot easier, since it does
not have to compare to big containers one-by-one.
2021-03-28 10:59:55 -04:00
Matthias Clasen
146069058f
Add some tests for node diffing
...
Nothing deep yet, but more can be added.
2021-03-28 10:45:40 -04:00
Matthias Clasen
2d5dd7b3d7
gsk: Make rendernode diffing smarter
...
Allow comparing container nodes to any other
node, by pretending the other node is a single
child container (if it isn't one already).
This fixes a glitch where we redraw the full
entry text when the blinking cursor goes to
opacity 0, since GskSnapshot then optimizes
away first the opacity node, and then the
single-child container.
2021-03-28 10:26:06 -04:00
Matthias Clasen
0904dd29c2
gsk: Use floorf for floats
2021-03-28 10:26:06 -04:00
Matthias Clasen
279b9347fd
gsk: Cosmetics
2021-03-28 10:26:02 -04:00
Matthias Clasen
2a2ae16894
ngl: Cosmetics
...
Remove a commented out line that snuck in with
a recent commit.
2021-03-28 10:26:02 -04:00
Matthias Clasen
3e1a8aa286
Merge branch 'fix-memleaks' into 'master'
...
Fix memleaks
See merge request GNOME/gtk!3360
2021-03-28 14:23:35 +00:00
Matthias Clasen
db126a19b6
Plug a test memleak
2021-03-27 21:52:49 -04:00
Matthias Clasen
ffa50f4c24
Plug a memory leak in an error path
2021-03-27 21:44:19 -04:00
Matthias Clasen
e1866d8fbe
Ignore pthread allocations in valgrind
2021-03-27 21:43:59 -04:00
Matthias Clasen
d24a0e9606
tests: Plug a memory leak
2021-03-27 21:13:25 -04:00
Matthias Clasen
b8693cc4f4
tests: Make the pixbuf test use TAP
...
Otherwise, meson just considers this test skipped.
2021-03-27 21:03:43 -04:00
Matthias Clasen
5d5adf6ee7
asan: Ignore leaks from librsvg
...
Turns out that there are some leaks from librsvg.
2021-03-27 21:03:43 -04:00
Matthias Clasen
dda69bd16d
tests: Plug memory leaks
...
This one was pointed out by asan.
2021-03-27 21:03:43 -04:00
Matthias Clasen
926b855d14
Merge branch 'fix-memleaks' into 'master'
...
Fix memleaks
See merge request GNOME/gtk!3359
2021-03-27 23:47:05 +00:00
Matthias Clasen
afc3de6e04
notebook: Don't leak the pages property
...
We were misuing a transfer-full getter here.
2021-03-27 19:11:56 -04:00
Matthias Clasen
45f4090eec
stack: Don't leak the pages property
...
We were misusing a transfer-full getter here.
2021-03-27 19:11:56 -04:00
Matthias Clasen
4cf69fbc5e
builder: Plug a small memory leak
...
We were forgetting to free expression info
objects in one place.
2021-03-27 19:11:56 -04:00
Matthias Clasen
0c6da97147
builder: Add an assertion
...
This case is clearly not meant to happen.
Assert that it doesn't.
2021-03-27 19:11:56 -04:00
Matthias Clasen
8994635d39
settings: Plug a memory leak
...
It is rare that settings are finalized, but we
still shouldn't leak in that case.
2021-03-27 19:11:56 -04:00
Matthias Clasen
7644605dfc
Plug a small memory leak
2021-03-27 19:11:56 -04:00
Matthias Clasen
97a9e23b85
bookmarklist: Avoid an invalid read
...
This shows up when running the objects-finalize
test under valgrind.
2021-03-27 19:11:56 -04:00
Matthias Clasen
478ecf8db4
Merge branch 'ngl-uninitialized-matrix' into 'master'
...
Ngl uninitialized matrix
See merge request GNOME/gtk!3358
2021-03-27 20:59:54 +00:00
Anders Jonsson
0e857862ab
Update Swedish translation
...
(cherry picked from commit 86f3c11d1e
)
2021-03-27 20:43:39 +00:00
Matthias Clasen
2bb4859031
ngl: Fix an uninitialized read
...
We were using the wrong matrix here.
valgrind pointed this point.
2021-03-27 16:32:58 -04:00
Matthias Clasen
7aef77a21a
reftests: Plug a few memory leaks
...
Noticed in passing.
2021-03-27 16:25:28 -04:00
Matthias Clasen
e7f9d56da5
ngl: Fix an uninitialized read
...
We were using the wrong matrix here.
valgrind pointed this point.
2021-03-27 16:23:40 -04:00
Matthias Clasen
34883b7142
reftests: Plug a few memory leaks
...
Noticed in passing.
2021-03-27 16:23:17 -04:00
Matthias Clasen
23706a4a6d
release: Actually include docs
2021-03-27 14:22:19 -04:00
Matthias Clasen
c52c944e33
Updates
2021-03-27 14:21:04 -04:00
Matthias Clasen
8540bea65e
Merge branch 'file-chooser-fixes' into 'master'
...
File chooser fixes
See merge request GNOME/gtk!3356
2021-03-27 14:23:15 +00:00
Matthias Clasen
8ea4721d1e
filechooser: Make / work as shortcut again
...
Typing / is meant to open the location entry, so
prevent search from capturing that key.
2021-03-27 09:57:00 -04:00
Matthias Clasen
e8a6b504f3
filechooser: Fix fallout from GtkText
...
Ever since the GtkText split, the focus is no longer
on an entry, but inside it. The filechooser was never
updated for that.
2021-03-27 09:54:20 -04:00
Matthias Clasen
06ab8f2167
filechooser: Make Ctrl-L work again
...
Prevent search from preempting the Ctrl-L shortcut
that is meant to show the location entry.
2021-03-27 09:53:43 -04:00
Matthias Clasen
b5558f3e97
layout: Be quiet about trivialities
...
Commit 8b82993dde
added a noisy warning
to gtk_distribute_natural_allocation to quiet a
compiler warning. It turn out that the file chooser
managed to trigger this warning, so make it a quiet
return.
2021-03-27 08:59:21 -04:00
Matthias Clasen
bdd281c9ea
release: Update included subprojects
2021-03-27 08:55:51 -04:00
Matthias Clasen
c9ab7c5750
Merge branch 'double-dead-keys' into 'master'
...
Double dead keys
See merge request GNOME/gtk!3355
2021-03-27 01:22:41 +00:00
Matthias Clasen
01f4e5c8cd
Add some more compose tests
...
These tests changes to the algorithmic dead key
matching.
2021-03-26 20:38:45 -04:00
Matthias Clasen
8a567d7932
imcontext: Tweak dead key handling
...
Reshuffle things to allow for a limited amount of
dead key 'chaining'. We keep up to 2 dead keys in
the preedit, so you can type
<dead_acute> <dead_cedilla> <c>
to produce ḉ, while still getting ```c with
<dead_grave> <dead_grave> <dead_grave> <c>.
2021-03-26 20:38:45 -04:00
Matthias Clasen
dbcd24adf4
composetable: Limit algorithmic checking
...
Only check for combinations of up to 2 dead keys with
a base character. We don't want to spend ages generating
all permutations of long sequences.
2021-03-26 20:27:55 -04:00
Matthias Clasen
f6f07ba238
Merge branch 'icon-fallback' into 'master'
...
Icon fallback
See merge request GNOME/gtk!3353
2021-03-26 19:33:13 +00:00
Matthias Clasen
3ab07203ce
widget-factory: Add missing icons
...
This removes all the cases where we were showing a missing-image
when running with the hicolor icontheme.
2021-03-26 14:34:40 -04:00
Emmanuele Bassi
70e26d12fb
Update the gi-docgen repository
...
Do not use my personal workspace.
2021-03-26 17:41:58 +00:00
Matthias Clasen
6ba414216c
widget-factory: Drop two icons from the iconview
...
This avoids the scrollbar by default, which is nice.
2021-03-26 13:30:46 -04:00
Matthias Clasen
775b45ef57
icons: Add text-x-generic
...
The file chooser needs at least one icon that we can
fall back to for non-directories. text-x-generic is
that icon.
2021-03-26 13:17:51 -04:00
Matthias Clasen
23cb72875d
filechooser: Check that icons exist
...
Otherwise we end up showing missing-image in the
file chooser, and thats sad.
2021-03-26 13:17:51 -04:00
Matthias Clasen
5940de98dd
icontheme: Add gtk_icon_theme_has_gicon
...
Add a utility function to check whether the icontheme
will produce something better than missing-image for
a GIcon. Obviously, we can only answer this question
if the GIcon is a themed icon the begin with.
2021-03-26 13:17:51 -04:00
Matthias Clasen
4028bd5bce
widget-factory: Add emblem-shared-symbolic icon
...
We use it, so include it.
2021-03-26 11:59:37 -04:00
Matthias Clasen
b5608e93d2
icons: Sync color-select-symbolic with Adwaita
...
This icon changed a bit since we incorporated it.
2021-03-26 11:59:01 -04:00
Matthias Clasen
1ea2ea520f
icons: Add system-run-symbolic
...
This is used by Adwaita for devel headers, so include it.
2021-03-26 11:42:09 -04:00
Matthias Clasen
922b2683b3
Merge branch 'matthiasc/for-master' into 'master'
...
Matthiasc/for master
See merge request GNOME/gtk!3351
2021-03-26 15:30:51 +00:00
Matthias Clasen
6dcef28e12
icon: Add a printer icon
...
This showed up as missing icon in the print dialog when
used with the hicolor icontheme.
2021-03-26 11:30:14 -04:00
Matthias Clasen
08f68cce40
gdk: Add an arg check to gdk_device_get_timestamp
...
Pointed out by Emmanuele Bassi.
2021-03-26 11:09:50 -04:00
Matthias Clasen
7849590a82
gdk: Add gdk_device_get_timestamp
...
Give each device a timestamp that reflects the last
user activity with that device, as reflected in the
events that are produced for this device.
2021-03-26 11:09:05 -04:00
Matthias Clasen
c9b312c860
icons: Add icons that are used in the inspector
...
These were showing up as missing icons when opening
the Inspector with the hicolor icontheme:
system-search-symbolic
go-previous-symbolic
go-next-symbolic
display-brightness-symbolic
2021-03-26 11:00:01 -04:00
Matthias Clasen
6110980012
Merge branch 'device-timestamp' into 'master'
...
Device timestamp
Closes #3792
See merge request GNOME/gtk!3350
2021-03-26 14:51:37 +00:00
Matthias Clasen
019855a27f
textview: Use device timestamps for obscured cursors
...
Stash away the device timestamp when obscuring
the pointer, and compare it when we decice whether
to unobscure it. This fixes a problem where synthetic
motion events would make the cursor reappear
prematurely.
Fixes : #3792
2021-03-26 10:30:33 -04:00
Matthias Clasen
cdfdf031b5
text: Use device timestamps for obscured cursors
...
Stash away the device timestamp when obscuring
the pointer, and compare it when we decice whether
to unobscure it. This fixes a problem where synthetic
motion events would make the cursor reappear
prematurely.
2021-03-26 10:30:33 -04:00
Matthias Clasen
f131d68fef
gdk: Add gdk_device_get_timestamp
...
Give each device a timestamp that reflects the last
user activity with that device, as reflected in the
events that are produced for this device.
2021-03-26 10:30:33 -04:00
Matthias Clasen
3014649455
Merge branch 'pixbuf-loader-check' into 'master'
...
Make testsuite fail if we lack pixbuf loaders
See merge request GNOME/gtk!3348
2021-03-26 11:29:47 +00:00
Matthias Clasen
2496ab0902
Be explicit when building gdk-pixbuf subproject
...
We require png and jpeg loaders.
2021-03-25 22:52:30 -04:00
Matthias Clasen
50d42093b5
Make testsuite fail if we lack pixbuf loaders
...
Add a test that requires that we have png and jpeg
loaders.
2021-03-25 21:23:11 -04:00
Matthias Clasen
44481d355e
Make testsuite fail if we lack pixbuf loaders
...
Add a test that requires that we have png and jpeg
loaders.
2021-03-25 21:22:23 -04:00
Matthias Clasen
6f82408056
Add logging for icon fallback
...
Add GTK_DEBUG=iconfallback which prints out what icon names
we fall back to image-missing for.
2021-03-25 17:26:15 -04:00
Matthias Clasen
cc64dbafbc
Merge branch 'carlosgc/clipboard-crash' into 'master'
...
clipboard: Fix a crash when GdkContentProviderUnion doesn't support the given data format
See merge request GNOME/gtk!3346
2021-03-25 20:48:28 +00:00
Carlos Garcia Campos
50b70298c0
clipboard: Fix a crash when GdkContentProviderUnion doesn't support the given data format
...
After iterating all the providers, all of them returning unsupported
error, gdk_content_provider_union_get_value() returns FALSE without
filing the given GError. Then gdk_clipboard_read_value_internal()
assumes there's a GError when FALSE is returned and
g_task_return_error() fails. We can just chain up to parent
implementation to ensure the GError is filled with unsupported error.
2021-03-25 15:10:00 +01:00
Matthias Clasen
bd7df4b816
Merge branch 'shader' into 'master'
...
ngl: Fix crash with intel driver on Windows when compiling shaders
Closes #3783
See merge request GNOME/gtk!3344
2021-03-25 12:37:12 +00:00
Xavier Claessens
086e1ed39f
ngl: Fix crash with intel driver on Windows when compiling shaders
...
Fixes #3783 .
2021-03-25 08:20:30 -04:00
dparisot
82b11623f4
Load icon from executable on Windows
2021-03-21 15:24:28 +01:00