TreeView: Don’t get CSS row separator height >once

We were looping the columns and, if is_separator, assigning from get_separator_height() on each iteration. We should just do it once, so we don’t go through a lot of CSS machinery for each column for no reason
2018-06-20 22:27:06 +01:00
1 changed files with 7 additions and 1 deletions
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -5822,6 +5822,7 @@ validate_row (GtkTreeView *tree_view,
  gint depth = gtk_tree_path_get_depth (path);
  gboolean retval = FALSE;
  gboolean is_separator = FALSE;
+  gboolean got_separator_height = FALSE;
  gboolean draw_vgrid_lines, draw_hgrid_lines;
  gint expander_size;

@@ -5883,7 +5884,12 @@ validate_row (GtkTreeView *tree_view,

      if (is_separator)
        {
-          height = get_separator_height (tree_view);
+          /* Avoid wading thru CSS just to get the same size for every column */
+          if (!got_separator_height)
+            {
+              height = get_separator_height (tree_view);
+              got_separator_height = TRUE;
+            }
        }
      else
        {